Page MenuHomePhabricator
Create Task
Maniphest T277731

WikibaseRepo + WikibaseClient: Remove SingleEntitySourceServicesFactory Service
Closed, ResolvedPublic
Actions

Description

As part of the wikibase service migration a temporary factory class to generate instances of SingleEntitySourceServices was created in order to mitigate the usage of such services in prefetching callback definitions.

Once the services used in these callbacks are migrated into WikibaseClient.ServiceWiring and WikibaseRepo.ServiceWiring, this factory service is no longer needed, and can be removed. These services are:

  • getTermInLangIdsResolver (T281341)
  • getEntityRevisionLookup (T281342)

See child tasks for more information.

Depends on T277858: Stop Passing an instance of SingleEntitySourceServices into PrefetchingTermLookup callbacks

NOTE: This is a prerequisite for completely migrating all services to the service container and removing DataAccessServices, WikibaseServices, MultipleEntitySourceServices and SingleEntitySourceServices.

Details

SubjectRepoBranchLines +/-
Remove SingleEntitySourceServicesFactory from service containermediawiki/extensions/Wikibasemaster+71 -218
Stop using SingleEntitySourceServicesFactory for term lookupsmediawiki/extensions/WikibaseMediaInfomaster+1 -4
Stop using SingleEntitySourceServicesFactory for term lookupsmediawiki/extensions/Wikibasemaster+2 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

ItamarWMDE created this task.Mar 18 2021, 7:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2021, 7:22 AM
ItamarWMDE renamed this task from Remove `WikibaseRepo.SingleEntitySourceServiceFactory` Service to WikibaseRepo: Remove SingleEntitySourceServiceFactory Service.Mar 18 2021, 9:14 AM
ItamarWMDE moved this task from Waiting for other services to Incoming on the Wikibase Service Migration board.Mar 18 2021, 4:18 PM
Lucas_Werkmeister_WMDE mentioned this in T280643: Remove TermSearchInteractorFactory from WikibaseServices/SingleEntitySourceServices.Apr 20 2021, 9:54 AM
ItamarWMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Apr 22 2021, 10:11 AM
ItamarWMDE renamed this task from WikibaseRepo: Remove SingleEntitySourceServiceFactory Service to WikibaseRepo + WikibaseClient: Remove SingleEntitySourceServiceFactory Service.Apr 28 2021, 9:42 AM
ItamarWMDE mentioned this in T281341: Migrate TermInLangIdsResolver to service container.Apr 28 2021, 9:51 AM
ItamarWMDE mentioned this in T281342: Migrate EntityRevisionLookup to service container.Apr 28 2021, 9:54 AM
ItamarWMDE updated the task description. (Show Details)Apr 28 2021, 10:14 AM
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE closed subtask T281343: Stop Passing SingleEntitySourceServicesFactory into PrefetchingTermLookup callbacks as Invalid.Apr 30 2021, 3:17 PM
ItamarWMDE updated the task description. (Show Details)Apr 30 2021, 3:46 PM
ItamarWMDE added a project: [DEPRECATED] wdwb-tech.
Addshore moved this task from Inbox to Active on the [DEPRECATED] wdwb-tech board.May 3 2021, 7:22 AM
Lucas_Werkmeister_WMDE renamed this task from WikibaseRepo + WikibaseClient: Remove SingleEntitySourceServiceFactory Service to WikibaseRepo + WikibaseClient: Remove SingleEntitySourceServicesFactory Service.May 3 2021, 4:12 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE closed subtask T281341: Migrate TermInLangIdsResolver to service container as Resolved.May 4 2021, 9:45 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Addshore moved this task from Active to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.May 4 2021, 10:52 AM
Addshore added a project: Wikidata-Campsite.May 4 2021, 10:54 AM
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore triaged this task as Low priority.Jul 14 2021, 11:12 AM
Addshore removed a project: Wikidata-Campsite.Jul 20 2021, 2:56 PM
Addshore mentioned this in T246467: SingleEntitySourceServices should only be created with callbacks for the types supported by the entity source..Aug 24 2021, 9:13 AM
gerritbot added a comment.Jul 15 2022, 11:52 AM

Change 814147 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using SingleEntitySourceServicesFactory for term lookups

https://gerrit.wikimedia.org/r/814147

gerritbot added a project: Patch-For-Review.Jul 15 2022, 11:52 AM

Change 814149 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@master] Stop using SingleEntitySourceServicesFactory for term lookups

https://gerrit.wikimedia.org/r/814149

gerritbot added a comment.Jul 15 2022, 11:52 AM

Change 814150 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove SingleEntitySourceServicesFactory from service container

https://gerrit.wikimedia.org/r/814150

Lucas_Werkmeister_WMDE claimed this task.Jul 15 2022, 11:53 AM
gerritbot added a comment.Jul 20 2022, 3:59 PM

Change 814147 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using SingleEntitySourceServicesFactory for term lookups

https://gerrit.wikimedia.org/r/814147

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 20 2022, 4:00 PM
gerritbot added a comment.Jul 20 2022, 4:02 PM

Change 814149 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Stop using SingleEntitySourceServicesFactory for term lookups

https://gerrit.wikimedia.org/r/814149

gerritbot added a comment.Jul 20 2022, 4:03 PM

Change 814150 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove SingleEntitySourceServicesFactory from service container

https://gerrit.wikimedia.org/r/814150

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2022, 4:30 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 21 2022, 10:24 AM
Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Done on the Wikibase Service Migration board.

This is done, if we strictly interpret the task to mean removing the factory from the service container. The factory itself still exists, but it is no longer available as a service of its own; it’s only used inside the service wiring of the WikibaseServices service. If we later want to remove that service, we can do whatever we want with SingleEntitySourceServicesFactory (moving the code around as needed), since it’s already no longer used anywhere else.

(The EntityRevisionLookup subtask T281342 is currently still open, but only to track a follow-up patch in the Math extension. Oherwise, that task is done as well, in that EntityRevisionLookup is now in the service container for repo and client.)

Lucas_Werkmeister_WMDE closed subtask T281342: Migrate EntityRevisionLookup to service container as Resolved.Jul 21 2022, 1:54 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE mentioned this in T331903: Remove DataAccessServices, WikibaseServices, MultipleEntitySourceServices.Mar 13 2023, 5:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits