Page MenuHomePhabricator

Stop Passing an instance of SingleEntitySourceServices into PrefetchingTermLookup callbacks
Closed, ResolvedPublic

Description

Currently, an instance of SingleEntitySourceServices is passed into the prefetching term lookup callbacks, creating a dependency between SingleEntitySourceServices and PrefetchingTermLookup.

While working on T277314, work on this has already begun, but was stopped in order to not create a dependency between WikibaseRepo (or Client) and Lib.

See referenced patches for what was done. As a solution, it was concluded that perhaps passing the factory as well as the entity source to the callback will enable the users of this callback to decide whether they need to instantiate the single entity source services or not.

This task is a suggestion of an approach to be implemented, and of course, if we eventually decide to go with a different approach it can be declined.

Depends on T277856: Remove PrefetchingTermLookup from WikibaseServices

Event Timeline

Change 673204 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Stop passing SingleEntitySourceServices into prefetching callbacks

https://gerrit.wikimedia.org/r/673204

Change 673205 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/WikibaseMediaInfo@master] Update prefetching term lookup callback

https://gerrit.wikimedia.org/r/673205

ItamarWMDE renamed this task from Stop Passing SingleEntitySourceServices into PrefetchingTermLookup callbacks to Stop Passing an instance SingleEntitySourceServices into PrefetchingTermLookup callbacks.Apr 28 2021, 9:57 AM
ItamarWMDE renamed this task from Stop Passing an instance SingleEntitySourceServices into PrefetchingTermLookup callbacks to Stop Passing an instance of SingleEntitySourceServices into PrefetchingTermLookup callbacks.

Change 673205 abandoned by Itamar Givon:

[mediawiki/extensions/WikibaseMediaInfo@master] Update prefetching term lookup callback

Reason:

https://gerrit.wikimedia.org/r/673205

Change 673204 abandoned by Itamar Givon:

[mediawiki/extensions/Wikibase@master] Stop passing SingleEntitySourceServices into prefetching callbacks

Reason:

https://gerrit.wikimedia.org/r/673204

Change 683863 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Move prefetching term lookup callback to seperate entitytype files.

https://gerrit.wikimedia.org/r/683863

Change 683864 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Stop passing SingleEntitySourceServices into prefetching term... ... lookup callbacks

https://gerrit.wikimedia.org/r/683864

Change 683865 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseMediaInfo@master] Prepare to pass entity source instead of services

https://gerrit.wikimedia.org/r/683865

Change 683886 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseMediaInfo@master] Stop passing SingleEntitySourceServices into prefetching term... ... lookup callbacks

https://gerrit.wikimedia.org/r/683886

Change 683863 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move prefetching term lookup callback to seperate entitytype files.

https://gerrit.wikimedia.org/r/683863

Change 683865 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Prepare to pass entity source instead of services

https://gerrit.wikimedia.org/r/683865

Change 683864 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop passing SingleEntitySourceServices into prefetching term lookup CBs

https://gerrit.wikimedia.org/r/683864

Change 683886 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Stop passing SingleEntitySourceServices into prefetching term lookup CBs

https://gerrit.wikimedia.org/r/683886