Page MenuHomePhabricator
Create Task
Maniphest T277859

Exception caught: MediaWiki\User\UserEditTracker::getUserEditCount requires a user ID on beta
Closed, ResolvedPublic
Actions

Description

Repropduction:

{
error: {
code: "internal_api_error_InvalidArgumentException",
info: "[YFSJPKwQBHcAACBxYkUAAAAB] Exception caught: MediaWiki\User\UserEditTracker::getUserEditCount requires a user ID",
errorclass: "InvalidArgumentException",
*: "InvalidArgumentException at /srv/mediawiki/php-master/includes/user/UserEditTracker.php(65)
from /srv/mediawiki/php-master/includes/user/UserEditTracker.php(65)
#0 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Variables/LazyVariableComputer.php(302): MediaWiki\User\UserEditTracker->getUserEditCount(User)
#1 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Variables/VariablesManager.php(88): MediaWiki\Extension\AbuseFilter\Variables\LazyVariableComputer->compute(MediaWiki\Extension\AbuseFilter\Variables\LazyLoadedVariable, MediaWiki\Extension\AbuseFilter\Variables\VariableHolder, Closure)
#2 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterParser.php(1204): MediaWiki\Extension\AbuseFilter\Variables\VariablesManager->getVar(MediaWiki\Extension\AbuseFilter\Variables\VariableHolder, string, integer, string)
#3 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(136): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterParser->getVarValue(string)
#4 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(260): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#5 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(267): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#6 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(110): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#7 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(67): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalTree(MediaWiki\Extension\AbuseFilter\Parser\AFPSyntaxTree)
#8 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterParser.php(399): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->intEval(string)
#9 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterParser.php(410): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterParser->parse(string)
#10 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterParser.php(289): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterParser->parseDetailed(string)
#11 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(378): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterParser->checkConditions(string, string)
#12 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(344): MediaWiki\Extension\AbuseFilter\FilterRunner->checkFilter(MediaWiki\Extension\AbuseFilter\Filter\ExistingFilter, boolean)
#13 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(231): MediaWiki\Extension\AbuseFilter\FilterRunner->checkAllFiltersInternal()
#14 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/AbuseFilterHooks.php(102): MediaWiki\Extension\AbuseFilter\FilterRunner->run()
#15 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/AbuseFilterHooks.php(45): MediaWiki\Extension\AbuseFilter\AbuseFilterHooks::filterEdit(DerivativeContext, User, Wikibase\Repo\Content\ItemContent, string, string)
#16 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(330): MediaWiki\Extension\AbuseFilter\AbuseFilterHooks::onEditFilterMergedContent(DerivativeContext, Wikibase\Repo\Content\ItemContent, Status, string, User, boolean, string)
#17 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#18 /srv/mediawiki/php-master/includes/Hooks.php(137): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#19 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/EditEntity/MediawikiEditFilterHookRunner.php(115): Hooks::run(string, array)
#20 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/EditEntity/StatsdTimeRecordingEditFilterHookRunner.php(47): Wikibase\Repo\EditEntity\MediawikiEditFilterHookRunner->run(Wikibase\DataModel\Entity\Item, User, string)
#21 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/EditEntity/MediawikiEditEntity.php(718): Wikibase\Repo\EditEntity\StatsdTimeRecordingEditFilterHookRunner->run(Wikibase\DataModel\Entity\Item, User, string)
#22 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEditEntity.php(77): Wikibase\Repo\EditEntity\MediawikiEditEntity->attemptSave(Wikibase\DataModel\Entity\Item, string, integer, string, boolean, array)
#23 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Api/EntitySavingHelper.php(377): Wikibase\Repo\EditEntity\StatsdSaveTimeRecordingEditEntity->attemptSave(Wikibase\DataModel\Entity\Item, string, integer, string, NULL, array)
#24 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Api/ModifyEntity.php(329): Wikibase\Repo\Api\EntitySavingHelper->attemptSaveEntity(Wikibase\DataModel\Entity\Item, string)
#25 /srv/mediawiki/php-master/includes/api/ApiMain.php(1646): Wikibase\Repo\Api\ModifyEntity->execute()
#26 /srv/mediawiki/php-master/includes/api/ApiMain.php(616): ApiMain->executeAction()
#27 /srv/mediawiki/php-master/includes/api/ApiMain.php(587): ApiMain->executeActionWithErrorHandling()
#28 /srv/mediawiki/php-master/api.php(90): ApiMain->execute()
#29 /srv/mediawiki/php-master/api.php(45): wfApiMain()
#30 /srv/mediawiki/w/api.php(3): require(string)
#31 {main}"
},
servedby: "deployment-mediawiki-07"
}

Details

SubjectRepoBranchLines +/-
Fix fatal when computing user_editcount for anonsmediawiki/extensions/AbuseFiltermaster+7 -4
Customize query in gerrit

Related Objects

Event Timeline

Addshore created this task.Mar 19 2021, 11:25 AM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptMar 19 2021, 11:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore mentioned this in T271215: Add termbox language code "ryu".Mar 19 2021, 11:26 AM

I tried this edit path on test.wikidata.org but couldn't reproduce it.
This could have something to do with either the change in T271215 OR just with beta in general...

Addshore added a comment.EditedMar 19 2021, 11:28 AM

I can reproduce on beta by just going to https://m.wikidata.beta.wmflabs.org/wiki/Special:NewItem and trying to make an item....

[YFSLAqwQBHcAACBxZnkAAAAA] /wiki/Special:NewItem InvalidArgumentException: MediaWiki\User\UserEditTracker::getUserEditCount requires a user ID

Backtrace:

from /srv/mediawiki/php-master/includes/user/UserEditTracker.php(65)
#0 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Variables/LazyVariableComputer.php(302): MediaWiki\User\UserEditTracker->getUserEditCount(User)
#1 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Variables/VariablesManager.php(88): MediaWiki\Extension\AbuseFilter\Variables\LazyVariableComputer->compute(MediaWiki\Extension\AbuseFilter\Variables\LazyLoadedVariable, MediaWiki\Extension\AbuseFilter\Variables\VariableHolder, Closure)
#2 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterParser.php(1204): MediaWiki\Extension\AbuseFilter\Variables\VariablesManager->getVar(MediaWiki\Extension\AbuseFilter\Variables\VariableHolder, string, integer, string)
#3 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(136): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterParser->getVarValue(string)
#4 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(260): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#5 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(267): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#6 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(110): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#7 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(67): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalTree(MediaWiki\Extension\AbuseFilter\Parser\AFPSyntaxTree)
#8 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterParser.php(399): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->intEval(string)
#9 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterParser.php(410): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterParser->parse(string)
#10 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/AbuseFilterParser.php(289): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterParser->parseDetailed(string)
#11 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(378): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterParser->checkConditions(string, string)
#12 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(344): MediaWiki\Extension\AbuseFilter\FilterRunner->checkFilter(MediaWiki\Extension\AbuseFilter\Filter\ExistingFilter, boolean)
#13 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(231): MediaWiki\Extension\AbuseFilter\FilterRunner->checkAllFiltersInternal()
#14 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/AbuseFilterHooks.php(102): MediaWiki\Extension\AbuseFilter\FilterRunner->run()
#15 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/AbuseFilterHooks.php(45): MediaWiki\Extension\AbuseFilter\AbuseFilterHooks::filterEdit(RequestContext, User, Wikibase\Repo\Content\ItemContent, string, string)
#16 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(330): MediaWiki\Extension\AbuseFilter\AbuseFilterHooks::onEditFilterMergedContent(RequestContext, Wikibase\Repo\Content\ItemContent, Status, string, User, boolean, string)
#17 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#18 /srv/mediawiki/php-master/includes/Hooks.php(137): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#19 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/EditEntity/MediawikiEditFilterHookRunner.php(115): Hooks::run(string, array)
#20 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/EditEntity/StatsdTimeRecordingEditFilterHookRunner.php(47): Wikibase\Repo\EditEntity\MediawikiEditFilterHookRunner->run(Wikibase\DataModel\Entity\Item, User, string)
#21 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/EditEntity/MediawikiEditEntity.php(718): Wikibase\Repo\EditEntity\StatsdTimeRecordingEditFilterHookRunner->run(Wikibase\DataModel\Entity\Item, User, string)
#22 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEditEntity.php(77): Wikibase\Repo\EditEntity\MediawikiEditEntity->attemptSave(Wikibase\DataModel\Entity\Item, string, integer, string, boolean, array)
#23 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Specials/SpecialWikibaseRepoPage.php(186): Wikibase\Repo\EditEntity\StatsdSaveTimeRecordingEditEntity->attemptSave(Wikibase\DataModel\Entity\Item, string, integer, string)
#24 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Specials/SpecialNewEntity.php(164): Wikibase\Repo\Specials\SpecialWikibaseRepoPage->saveEntity(Wikibase\DataModel\Entity\Item, Wikibase\Lib\Summary, string, integer)
#25 /srv/mediawiki/php-master/includes/htmlform/HTMLForm.php(714): Wikibase\Repo\Specials\SpecialNewEntity->Wikibase\Repo\Specials\{closure}(array, OOUIHTMLForm)
#26 /srv/mediawiki/php-master/includes/htmlform/HTMLForm.php(604): HTMLForm->trySubmit()
#27 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Specials/SpecialNewEntity.php(108): HTMLForm->tryAuthorizedSubmit()
#28 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(646): Wikibase\Repo\Specials\SpecialNewEntity->execute(NULL)
#29 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(1376): SpecialPage->run(NULL)
#30 /srv/mediawiki/php-master/includes/MediaWiki.php(309): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#31 /srv/mediawiki/php-master/includes/MediaWiki.php(925): MediaWiki->performRequest()
#32 /srv/mediawiki/php-master/includes/MediaWiki.php(547): MediaWiki->main()
#33 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#34 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#35 /srv/mediawiki/w/index.php(3): require(string)
#36 {main}
Addshore added a subscriber: Ladsgroup.Mar 19 2021, 11:30 AM
Addshore triaged this task as High priority.Mar 19 2021, 11:42 AM
Addshore added a comment.Mar 19 2021, 11:59 AM

Daily beta lexeme browser tests have also been broken for some time with this error
https://integration.wikimedia.org/ci/job/selenium-daily-beta-WikibaseLexeme/953/console

Addshore updated the task description. (Show Details)Mar 19 2021, 11:59 AM
Daimona claimed this task.Mar 19 2021, 12:01 PM
Addshore mentioned this in T277862: selenium-daily-beta-WikibaseLexeme broken since mid feb 2021.Mar 19 2021, 12:02 PM
Addshore moved this task from Inbox to Active on the [DEPRECATED] wdwb-tech board.
gerritbot added a comment.Mar 19 2021, 12:08 PM

Change 673469 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Fix fatal when computing user_editcount for anons

https://gerrit.wikimedia.org/r/673469

gerritbot added a project: Patch-For-Review.Mar 19 2021, 12:08 PM
gerritbot added a comment.Mar 19 2021, 1:11 PM

Change 673469 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Fix fatal when computing user_editcount for anons

https://gerrit.wikimedia.org/r/673469

WMDE-leszek subscribed.Mar 19 2021, 1:31 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 19 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 19 2021, 2:10 PM
Addshore closed this task as Resolved.Mar 19 2021, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits