Page MenuHomePhabricator

Rename blacklist/whitelist in PageTriage code
Closed, ResolvedPublic

Description

Targets
    Occurrences of '(white|black)[ \-]?list' in Directory /Users/reedy/PhpstormProjects/mediawiki/extensions/PageTriage
Found Occurrences  (28 usages found)
    extensions  (28 usages found)
        PageTriage  (28 usages found)
            modules  (2 usages found)
                ext.pageTriage.views.list  (2 usages found)
                    ext.pageTriage.listView.js  (2 usages found)
                        21 var blacklist = { msie: [ '<', 8 ] };
                        50 if ( $.client.test( blacklist, null, true ) ) {
            .rubocop_todo.yml  (2 usages found)
                10 # Configuration parameters: Blacklist.
                11 # Blacklist: END, (?-mix:EO[A-Z]{1})
            NewPagesFeed_Templates.xml  (24 usages found)
                1866 --      [[Module:Category handler/config]], and pages can be blacklisted      --
                1867 --      from categorisation by using [[Module:Category handler/blacklist]].   --
                1986 function CategoryHandler:shouldSkipBlacklistCheck()
                1988 -- should skip the blacklist check.
                1994 function CategoryHandler:matchesBlacklist()
                1996 return self._data.currentTitleMatchesBlacklist
                1999 return mShared.matchesBlacklist(
                2001 mw.loadData('Module:Category handler/blacklist')
                2008 -- matching the blacklist.
                2010 or not self:shouldSkipBlacklistCheck() and self:matchesBlacklist()
                2134 <title>Module:Category handler/blacklist</title>
                2146 comment>Protected Module:Category handler/blacklist: [[WP:High-risk templates|High-risk Lua module]] ([Edit=Allow only template editors and admins] (indefinite
                2149 <text xml:space="preserve" bytes="732">-- This module contains the blacklist used by [[Module:Category handler]].
                2190 --       For blacklist config, see [[Module:Category handler/blacklist]].     --
                2220 --                                          the blacklist check is skipped
                2226 --                                          the blacklist check is skipped
                2233 -- blacklist if set to the cfg.category2Yes value, and suppresses
                2262 -- cfg.category2 to cfg.category2Yes skips the blacklist, and if cfg.category2
                2323 -- page matches the title blacklist.
                2327 local blacklist = require('Module:Category handler/blacklist')
                2330 data.currentTitleMatchesBlacklist = mShared.matchesBlacklist(
                2332 blacklist
                2365 function p.matchesBlacklist(page, blacklist)
                2366 for i, pattern in ipairs(blacklist) do

Event Timeline

Most of the issues are in NewPagesFeed_Templates.xml... Is this still needed?

Hi, @Reedy, I'm trying to use T-shirt sizes to measure the effort required for each task to invite folks at the WMF to join and decide which ones they'd like to tackle by giving them information about the effort and any other info you consider relevant.

SizeTimeScore
XSAt Most 1 Hour0
SAt Most 1 Day1
MAt Most 3 Days3
LAt Most 5 Days5
XLNeeds Re-Eval9
?Unknown

For this specific task, T277952, What would you say the size is?

Novem_Linguae renamed this task from Address Voice and Tone issues in PageTriage to Rename blacklist/whitelist in code.Nov 10 2022, 3:11 AM

Change 894178 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Rename blacklist to warnlist

https://gerrit.wikimedia.org/r/894178

Change 894178 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Rename blacklist to warnlist

https://gerrit.wikimedia.org/r/894178

MPGuy2824 claimed this task.
MPGuy2824 moved this task from Code Review to Done on the PageTriage board.
MPGuy2824 subscribed.

With the merging of https://gerrit.wikimedia.org/r/894178, the only instances of 'blacklist' in the code are from resources/NewPagesFeed_Templates.xml. Since that is generated from the templates of enwiki (and those templates still have the word in them), i'm resolving this ticket.

Jdforrester-WMF renamed this task from Rename blacklist/whitelist in code to Rename blacklist/whitelist in PageTriage code.Mar 6 2023, 1:16 PM