Page MenuHomePhabricator

Rename dev folder to src
Closed, ResolvedPublic

Description

In recent years (after the portals were brought into Git in 2015), using a folder named ’src’ for all source files has become a popular convention in javascript projects and frameworks.

The source folder in the portals repo is currently named dev. It should be renamed to src to align with the more popular web-development conventions.

This change should make this repository easier to understand for new contributors. Also, it will free up the folder name dev for a different and more appropriate purpose: storing the compiled but un-minified build products (this is a separate patch however, as it includes substantial changes to the Gulp build pipeline).

Changing the folder name is not as simple as it sounds though, it does require replacing the name in the Gulp build process too. This task should wait until a separate config.js file has been created as part of T277405.

Event Timeline

@Saudshaikh99 You can always claim a microtask if you have started working on it already by clicking on Add Action... and then Assign / Claim.

This task should wait until a separate config.js file has been created as part of T277405.

@Saudshaikh99 You can always claim a microtask if you have started working on it already by clicking on Add Action... and then Assign / Claim.

Change 673783 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[wikimedia/portals@master] Renamed dev folder to src

https://gerrit.wikimedia.org/r/673783

can someone please explain to me the process of Review code review, I created pull requested and I got this message " Hi @saudshk99,

Thank you for contributing to Wikimedia! This Github repository is a read-only mirror.
The project uses Gerrit for code review.
Please submit your pull request to Gerrit, so your code changes can be reviewed."
and suddenly pull request closed

can someone please explain to me the process of Review code review, I created pull requested and I got this message " Hi @saudshk99,

Thank you for contributing to Wikimedia! This Github repository is a read-only mirror.
The project uses Gerrit for code review.
Please submit your pull request to Gerrit, so your code changes can be reviewed."
and suddenly pull request closed

You have to set up your gerrit account to start contributing for this project. github contains read-only mirror of this project .
for more information follow this link https://www.mediawiki.org/wiki/New_Developers#Welcome! .
And try to ask your doubt regarding this project at zulip https://wikimedia.zulipchat.com/#narrow/stream/274201-gsoc21-outreachy22/topic/portals
Thank you :)

@Saudshaikh99: Please ask general questions that are not about renaming the dev folder to src in support forums instead; please see https://www.mediawiki.org/wiki/New_Developers - thanks! :) Also, what is unclear with that message to use Gerrit instead of Github? Please explain how we can improve it.

Change 673783 merged by jenkins-bot:
[wikimedia/portals@master] Renamed dev folder to src

https://gerrit.wikimedia.org/r/673783