Page MenuHomePhabricator

The given PageIdentity does not represent a proper page
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.36.0-wmf.35

message
The given PageIdentity does not represent a proper page

Impact

Notes

Comes from unwatch actions done over the mediawiki API.

There is no details about the origin of the action.

Since March 29th at ~ 22:20 UTC

pageidentity.png (392×1 px, 63 KB)

Details

Request URL
https://en.wikipedia.org/w/api.php
Stack Trace
exception.trace
from /srv/mediawiki/php-1.36.0-wmf.35/includes/page/WikiPageFactory.php(59)
#0 /srv/mediawiki/php-1.36.0-wmf.35/includes/actions/WatchAction.php(333): MediaWiki\Page\WikiPageFactory->newFromTitle(Title)
#1 /srv/mediawiki/php-1.36.0-wmf.35/includes/api/ApiWatch.php(124): WatchAction::doUnwatch(Title, User)
#2 /srv/mediawiki/php-1.36.0-wmf.35/includes/api/ApiWatch.php(74): ApiWatch->watchTitle(Title, User, array)
#3 /srv/mediawiki/php-1.36.0-wmf.35/includes/api/ApiMain.php(1646): ApiWatch->execute()
#4 /srv/mediawiki/php-1.36.0-wmf.35/includes/api/ApiMain.php(616): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.36.0-wmf.35/includes/api/ApiMain.php(587): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.36.0-wmf.35/api.php(90): ApiMain->execute()
#7 /srv/mediawiki/php-1.36.0-wmf.35/api.php(45): wfApiMain()
#8 /srv/mediawiki/w/api.php(3): require(string)
#9 {main}

Event Timeline

hashar triaged this task as Medium priority.EditedMar 30 2021, 8:07 AM

They seem to be triggered by a single user on enwiki hammering enwiki with some unwatch requests. That is easily spotted on mwlog1002 by tailing api.log

Looks like:

2021-03-30 08:05:20 [44f893ce-ba87-4306-9ddd-5d5148061289] mw1379 enwiki 1.36.0-wmf.36 api
INFO: API POST <USERNAME> <IP> T=33ms action=watch format=json unwatch=true token=[redacted] generator=watchlistraw gwrnamespace=* gwrlimit=5

I have no idea what this user is sending, but I guess we should handle the error properly :]

I have filtered it out of the mediawiki-new-errors Kibana dashboard

Change 675911 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] Strickten Title::isWatchable

https://gerrit.wikimedia.org/r/675911

Change 675911 merged by jenkins-bot:

[mediawiki/core@master] Make Title::isWatchable more strict

https://gerrit.wikimedia.org/r/675911

Should we make a backport here? Seems like there are a lot of exceptions in 1.36.0-wmf.36 and I don't think this patch made the cuttoff for the branch cut for wmf.37.

Change 676355 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@wmf/1.36.0-wmf.37] Make Title::isWatchable more strict

https://gerrit.wikimedia.org/r/676355

Change 676355 abandoned by Ppchelko:

[mediawiki/core@wmf/1.36.0-wmf.37] Make Title::isWatchable more strict

Reason:

https://gerrit.wikimedia.org/r/676355