Page MenuHomePhabricator
Create Task
Maniphest T278937

Update IPInfo panel to use CollapsibleFieldsetLayout
Closed, ResolvedPublic
Actions

Description

Following T278935: Make CollapsibleFieldsetLayout more reusable, add the infobox in the hook handler InfoBoxHandler::onSpecialPageBeforeExecute. This allows us to use the CollapsibleFieldsetLayout.

The panel still needs JavaScript to query for the data, so if JavaScript is unavailable, the panel should not be added.

Details

SubjectRepoBranchLines +/-
Remove htmlform-ooui-wrapper class from PanelLayoutmediawiki/extensions/IPInfomaster+1 -2
Update IPInfo infobox to use CollapsibleFieldsetLayoutmediawiki/extensions/IPInfomaster+30 -35
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Mar 31 2021, 11:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2021, 11:03 AM
Tchanders added a subtask: T278935: Make CollapsibleFieldsetLayout more reusable.Mar 31 2021, 11:03 AM
Tchanders mentioned this in T269878: Investigate: Make a reusable collapsible component so that IPInfo infobox matches collapsible form [8h].
Tchanders moved this task from Untriaged to The Letter Song on the Anti-Harassment board.Apr 1 2021, 7:22 PM
Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
• wikitrent claimed this task.Apr 7 2021, 1:58 PM
• wikitrent moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Apr 7 2021, 3:33 PM
gerritbot added a comment.Apr 20 2021, 12:34 PM

Change 679916 had a related patch set uploaded (by Wikitrent; author: Wikitrent):

[mediawiki/extensions/IPInfo@master] WIP: Update IPInfo to match styling

https://gerrit.wikimedia.org/r/679916

gerritbot added a project: Patch-For-Review.Apr 20 2021, 12:34 PM
• wikitrent moved this task from In Progress 💪 to Blocked/Stalled 🚧 on the Anti-Harassment (The Letter Song) board.Apr 29 2021, 3:52 PM

Dependent on https://phabricator.wikimedia.org/T278935 being merged

• wikitrent moved this task from Blocked/Stalled 🚧 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.May 5 2021, 12:13 PM
gerritbot added a comment.May 5 2021, 12:38 PM

Change 679916 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Update IPInfo infobox to use CollapsibleFieldsetLayout

https://gerrit.wikimedia.org/r/679916

Tchanders mentioned this in rEIPI300d407d6c69: Update IPInfo infobox to use CollapsibleFieldsetLayout.May 5 2021, 12:39 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.5; 2021-05-11).May 5 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 5 2021, 1:10 PM
Tchanders moved this task from In Progress 💪 to Blocked/Stalled 🚧 on the Anti-Harassment (The Letter Song) board.May 7 2021, 11:52 AM
gerritbot added a comment.May 12 2021, 3:02 PM

Change 689929 had a related patch set uploaded (by Wikitrent; author: Wikitrent):

[mediawiki/extensions/IPInfo@master] Remove htmlform-ooui-wrapper class from PanelLayout

https://gerrit.wikimedia.org/r/689929

gerritbot added a project: Patch-For-Review.May 12 2021, 3:02 PM
• wikitrent moved this task from Blocked/Stalled 🚧 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.May 12 2021, 3:15 PM
gerritbot added a comment.May 26 2021, 6:52 PM

Change 689929 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Remove htmlform-ooui-wrapper class from PanelLayout

https://gerrit.wikimedia.org/r/689929

• wikitrent mentioned this in rEIPI95d303acc5b3: Remove htmlform-ooui-wrapper class from PanelLayout.May 26 2021, 6:55 PM
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.9; 2021-06-07); removed MW-1.37-notes (1.37.0-wmf.5; 2021-05-11).May 26 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 26 2021, 7:11 PM
• wikitrent moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.May 27 2021, 3:42 PM
• wikitrent moved this task from QA/Testing 🐞 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.May 27 2021, 4:51 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.Jun 14 2021, 12:10 PM
dom_walden subscribed.

Testing for this was done as part of T278935.

Niharika closed this task as Resolved.Jun 14 2021, 1:50 PM
Niharika closed subtask T278935: Make CollapsibleFieldsetLayout more reusable as Resolved.
Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits