Page MenuHomePhabricator
Create Task
Maniphest T279116

New Z12/MultiLingualString components should auto-create a blank item for the user's interface language(?) but not submit it into the data model on save if they don't fill it in
Closed, ResolvedPublic
Actions

Description

Messy.

Details

SubjectRepoBranchLines +/-
Initialize ZObject's label with the user's language on create.mediawiki/extensions/WikiLambdamaster+17 -1
Initialize ZMultilingualString with current user's default languagemediawiki/extensions/WikiLambdamaster+11 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF renamed this task from New Z12/MultiLinualString components should auto-create a blank item for the user's interface language(?) but not submit it into the data model on save if they don't fill it in to New Z12/MultiLingualString components should auto-create a blank item for the user's interface language(?) but not submit it into the data model on save if they don't fill it in.Apr 1 2021, 11:33 PM
Jdforrester-WMF created this task.
DVrandecic triaged this task as Lowest priority.Apr 7 2021, 4:59 AM
DVrandecic moved this task from To triage to Phase δ on the Abstract Wikipedia team board.
DVrandecic edited projects, added Abstract Wikipedia team (Phase δ); removed Abstract Wikipedia team.
DVrandecic added a subtask: T276819: Allow mechanism for choosing mode within a type.Apr 7 2021, 4:55 PM
gerritbot added a comment.Apr 26 2021, 9:44 PM

Change 682762 had a related patch set uploaded (by Lindsay Wardell; author: Lindsay Wardell):

[mediawiki/extensions/WikiLambda@master] Initialize ZMultilingualString with current user's default language

https://gerrit.wikimedia.org/r/682762

gerritbot added a project: Patch-For-Review.Apr 26 2021, 9:44 PM
Lindsaykwardell claimed this task.Apr 26 2021, 9:45 PM
DVrandecic closed subtask T276819: Allow mechanism for choosing mode within a type as Resolved.Apr 28 2021, 4:24 PM
DVrandecic raised the priority of this task from Lowest to High.Apr 28 2021, 4:41 PM
gerritbot added a comment.Apr 29 2021, 1:42 AM

Change 682762 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Initialize ZMultilingualString with current user's default language

https://gerrit.wikimedia.org/r/682762

Jdforrester-WMF added a comment.Apr 29 2021, 1:56 AM

Oh hmm, this does this for inner Z12s but not the initial one (Z2K3). Maybe this'd be fixed by T279676: Fetch all ZObject content from the API, rather than shipping some of it in the page payload?

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2021, 2:10 AM
gerritbot added a comment.May 3 2021, 2:47 PM

Change 684426 had a related patch set uploaded (by Lindsay Wardell; author: Lindsay Wardell):

[mediawiki/extensions/WikiLambda@master] Initialize ZObject's label with the user's language on create.

https://gerrit.wikimedia.org/r/684426

gerritbot added a project: Patch-For-Review.May 3 2021, 2:47 PM
Lindsaykwardell added a comment.May 3 2021, 2:48 PM

@Jdforrester-WMF I've pushed a second patch to address this, it will initialize a new multilingual string when the create page is being used.

gerritbot added a comment.May 3 2021, 6:51 PM

Change 684426 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Initialize ZObject's label with the user's language on create.

https://gerrit.wikimedia.org/r/684426

Maintenance_bot removed a project: Patch-For-Review.May 3 2021, 7:11 PM
DVrandecic closed this task as Resolved.May 5 2021, 4:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL