Enable coverage reports for taint-check
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Apr 6 2021, 10:24 AM

Description

Although it doesn't use @covers tags, it might be useful to spot areas which need more coverage. This is currently not doable for CI, as running taint-check (or even just phan) with xdebug enabled is prohibitively slow. Integration tests only might still run reasonably quick, but I guess this can be considered blocked on T234020.

Details

	Subject	Repo	Branch	Lines +/-
	Configure code coverage	mediawiki/tools/phan/SecurityCheckPlugin	master	+5 -0
	layout: [mediawiki/tools/phan/SecurityCheckPlugin] Publish PHP coverage	integration/config	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Daimona	T279423 Enable coverage reports for taint-check
Resolved	Daimona	T234020 Switch mediawiki code coverage from xdebug to pcov
Resolved	Daimona	T280170 Add pcov to composer images
Open	None	T243847 Add pcov PHP extension to wikimedia apt (and upgrade from 1.0.6-4+wmf1~buster1 to 1.0.11) so it can be used in Wikimedia CI

Event Timeline

Daimona created this task.Apr 6 2021, 10:24 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2021, 10:24 AM

Daimona added a parent task: T234020: Switch mediawiki code coverage from xdebug to pcov.Apr 6 2021, 10:24 AM

RhinosF1 subscribed.Apr 6 2021, 10:29 AM

Daimona updated the task description. (Show Details)Apr 6 2021, 10:36 AM

Integration tests only might still run reasonabley quick

Or maybe not. On my machine, 6m 49s with xdebug 2.9.1. Which gets a little better with xdebug 3.0.0 in "coverage" mode: 2m 13s. The clear winner is once again pcov, with just 16s. For comparison, running without coverage takes 9s.

Daimona removed a parent task: T234020: Switch mediawiki code coverage from xdebug to pcov.Apr 6 2021, 10:39 AM

Daimona added a subtask: T234020: Switch mediawiki code coverage from xdebug to pcov.

Jdforrester-WMF closed subtask T234020: Switch mediawiki code coverage from xdebug to pcov as Resolved.Apr 14 2021, 4:52 PM

Daimona reopened subtask T234020: Switch mediawiki code coverage from xdebug to pcov as Open.Apr 14 2021, 6:01 PM

Daimona closed subtask T234020: Switch mediawiki code coverage from xdebug to pcov as Resolved.Apr 14 2021, 6:16 PM

Daimona mentioned this in T280170: Add pcov to composer images.Apr 15 2021, 8:42 AM

Daimona closed subtask T280170: Add pcov to composer images as Resolved.Oct 4 2022, 12:14 PM

Daimona updated the task description. (Show Details)Oct 5 2022, 9:52 PM

Change 838917 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[integration/config@master] layout: [mediawiki/tools/phan/SecurityCheckPlugin] Generate coverage on postmerge

https://gerrit.wikimedia.org/r/838917

gerritbot added a project: Patch-For-Review.Oct 5 2022, 9:55 PM

Daimona claimed this task.Oct 5 2022, 9:55 PM

Change 838917 merged by jenkins-bot:

[integration/config@master] layout: [mediawiki/tools/phan/SecurityCheckPlugin] Publish PHP coverage

https://gerrit.wikimedia.org/r/838917

Mentioned in SAL (#wikimedia-releng) [2022-10-05T22:03:23Z] <James_F> layout: [mediawiki/tools/phan/SecurityCheckPlugin] Publish PHP coverage for T279423