Page MenuHomePhabricator
Create Task
Maniphest T280239

Use GET requests for segments and utterances
Closed, ResolvedPublic
Actions

Description

Currently POST is used to request both segments and utterances. GET can be used instead and would mean improvements through caching (T267918#6967384).

Details

SubjectRepoBranchLines +/-
Use GET requests for when calling API's from frontendmediawiki/extensions/Wikispeechmaster+36 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sebastian_Berlin-WMSE created this task.Apr 15 2021, 10:18 AM
Restricted Application added a project: Wikispeech-Jobrunner. · View Herald TranscriptApr 15 2021, 10:18 AM
Sebastian_Berlin-WMSE claimed this task.Apr 15 2021, 2:31 PM
Sebastian_Berlin-WMSE added a project: User-Sebastian_Berlin-WMSE.
Sebastian_Berlin-WMSE moved this task from Backlog to This Week on the User-Sebastian_Berlin-WMSE board.
Sebastian_Berlin-WMSE edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.
Sebastian_Berlin-WMSE moved this task from Backlog to In progress on the Wikispeech-Jobrunner (Sprint) board.
gerritbot added a comment.Apr 15 2021, 2:56 PM

Change 679821 had a related patch set uploaded (by Sebastian Berlin (WMSE); author: Sebastian Berlin (WMSE)):

[mediawiki/extensions/Wikispeech@master] Use GET requests for when calling API's from frontend

https://gerrit.wikimedia.org/r/679821

gerritbot added a project: Patch-For-Review.Apr 15 2021, 2:56 PM
gerritbot added a comment.Apr 16 2021, 10:00 AM

Change 679821 merged by jenkins-bot:

[mediawiki/extensions/Wikispeech@master] Use GET requests for when calling API's from frontend

https://gerrit.wikimedia.org/r/679821

Sebastian_Berlin-WMSE mentioned this in rEWISb7ca5bee51ed: Use GET requests for when calling API's from frontend.Apr 16 2021, 10:03 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 16 2021, 10:10 AM
Sebastian_Berlin-WMSE moved this task from This Week to Done on the User-Sebastian_Berlin-WMSE board.Apr 16 2021, 11:29 AM
Sebastian_Berlin-WMSE moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.Apr 16 2021, 11:52 AM
Jopparn closed this task as Resolved.Apr 19 2021, 2:13 PM
Stashbot mentioned this in T280258: Mock mw.Api instead of server.Sep 28 2022, 8:03 AM
Stashbot mentioned this in T281262: Treat Speechoid lexicon id (Pronlex id) as int rather than string.
Stashbot mentioned this in T277242: Ensure new lexicon edits are CC0.
Stashbot mentioned this in T277153: Allow user to decide on updating or adding new entry if entry with same spelling exists.
Stashbot mentioned this in T280244: Optionally mark utterance files with TTL in Swift.
Stashbot mentioned this in T279620: i18n for wikispeech-edit-lexicon user group.
Stashbot mentioned this in T133857: Link to Special:EditLexicon from player.

Mentioned in SAL (#wikimedia-cloud) [2022-09-28T08:03:03Z] <sebastian-wmse> Deploy latest from Git master: 2c16169, 84c80a6, 1dea391, 67d3618, 10e4ac5, 043335c (T279620), 1cbfbd8, 29f572a, b7ca5be (T280239, T280258), ac721c8, 8eb2f15 (T133857), d5182d6, 9ddab13 (T279652), 8eebc3d, 36c217f (T280244), dc93055 (T279652), 35abf5c (T277153), f922c2d (T277242), d91b7e8, 898e716 (T279632), 3cbb3b9 (T281262),

Stashbot mentioned this in T279652: Credit PTS in repo code.Sep 28 2022, 8:03 AM
Stashbot mentioned this in T279632: Implement local lexicon in new wiki namespace.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits