Description

For current master

Spills into footer on new Vector

Screen Shot 2021-04-15 at 7.45.27 AM.png (936×2 px, 197 KB)

Working fine on old Vector
:

Screen Shot 2021-04-15 at 7.46.02 AM.png (1×2 px, 297 KB)

QA steps

Visit Special:Book and confirm in old Vector there is no overlap with footer
Visit Special:Book and confirm in new Vector there is no overlap with footer

Details

	Subject	Repo	Branch	Lines +/-
	Fix special page layout	mediawiki/extensions/Collection	REL1_36	+11 -3
	Fix special page layout	mediawiki/extensions/Collection	master	+11 -3

Customize query in gerrit

Related Objects

Mentioned In: T279388: ResourceLoaderSkinModule: Improve the content-parser-output module

Event Timeline

Jdlrobson created this task.Apr 15 2021, 2:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2021, 2:46 PM

Jdlrobson mentioned this in T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.Apr 15 2021, 2:47 PM

Jdlrobson added a subscriber: TheDJ.

Trialpears subscribed.Apr 15 2021, 2:56 PM

Change 681220 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Collection@master] Fix special page layout

https://gerrit.wikimedia.org/r/681220

gerritbot added a project: Patch-For-Review.Apr 19 2021, 11:33 PM

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Apr 19 2021, 11:33 PM

Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 20 2021, 12:29 AM

ovasileva triaged this task as Low priority.Apr 20 2021, 5:08 PM

LGoto assigned this task to • nray.Apr 20 2021, 5:12 PM

ovasileva set the point value for this task to 2.Apr 20 2021, 5:47 PM

Jdlrobson removed • nray as the assignee of this task.Apr 20 2021, 9:43 PM

Jdlrobson added a project: MW-1.36-release.

Jdlrobson added a subscriber: • nray.

Jdlrobson assigned this task to Edtadros.Apr 20 2021, 10:51 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Sorry Edward for the accidentally assignment :)

I'll QA this one and resolve.
Basically need to check that https://en.wikipedia.beta.wmflabs.org/wiki/Special:Book unbreaks.

Change 681220 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Fix special page layout

https://gerrit.wikimedia.org/r/681220

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 1:10 AM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 21 2021, 2:00 AM

Change 681378 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Collection@REL1_36] Fix special page layout

https://gerrit.wikimedia.org/r/681378

gerritbot added a project: Patch-For-Review.Apr 21 2021, 3:54 AM

Jdlrobson closed this task as Resolved.Apr 21 2021, 3:54 AM

Change 681378 merged by jenkins-bot: