Page MenuHomePhabricator
Create Task
Maniphest T280608

Hard deprecate BaseTemplate:renderAfterPortlet method
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

BaseTemplate:renderAfterPortlet has only one known caller - Metrolook and was deprecated in 1.35. It will be removed in 1.37. Removing it will make our skin code easier to parse. BaseTemplate::getAfterPortlet duplicates functionality in Skin::getAfterPortlet so that should also be hard deprecated.

https://codesearch.wmcloud.org/skins/?q=renderAfterPortlet&i=nope&files=&excludeFiles=&repos=

TODO

Details

SubjectRepoBranchLines +/-
Replace deprecated BaseTemplate::renderAfterPortlet with Skin::getAfterPortletmediawiki/skins/Metrolookmaster+11 -1
Remove reference to BaseTemplateAfterPortletmediawiki/skins/Vectormaster+2 -1
Hard deprecations of portlet methods and hooksmediawiki/coremaster+9 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Apr 20 2021, 12:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2021, 12:19 AM
Jdlrobson assigned this task to ovasileva.May 5 2021, 7:13 PM
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson added a parent task: T282045: [GOAL] Deprecate and remove skin code in preparation for 1.37.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
ovasileva triaged this task as Medium priority.May 10 2021, 2:41 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.
Jdlrobson removed ovasileva as the assignee of this task.May 13 2021, 12:55 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson added a subscriber: ovasileva.
ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2020-21).May 24 2021, 4:40 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.
Jdlrobson updated the task description. (Show Details)Jun 2 2021, 4:47 PM
LGoto set the point value for this task to 2.Jun 2 2021, 4:48 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
bwang claimed this task.Jun 10 2021, 4:06 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 10 2021, 4:50 PM

Change 699249 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/core@master] Remove BaseTemplate::getAfterPortlet

https://gerrit.wikimedia.org/r/699249

gerritbot added a project: Patch-For-Review.Jun 10 2021, 4:50 PM
bwang removed bwang as the assignee of this task.Jun 10 2021, 4:51 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
bwang subscribed.
Jdlrobson assigned this task to bwang.Jun 10 2021, 5:27 PM
Jdlrobson moved this task from Code Review to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
bwang added a comment.Jun 10 2021, 5:28 PM

@Jdlrobson Should we also hard deprecate getAfterPortlet? The release notes deprecate both getAfterPortlet and renderAfterPortlet together in 1.35:

"BaseTemplate::getAfterPortlet and ::renderAfterPortlet have been deprecated in favor of the Skin::getAfterPortlet method"

This is the codesearch for "renderAfterPortlet"

Jdlrobson added a comment.Jun 10 2021, 6:21 PM

Ideally yes, but make sure to update Monobook and Timeless to use ->getSkin() first before doing that one since they are deployed and we don't want to send warning messages for production code! https://codesearch.wmcloud.org/deployed/?q=getAfterPortlet&i=nope&files=&excludeFiles=&repos=

Jdlrobson renamed this task from Remove BaseTemplate:renderAfterPortlet method to Hard deprecate BaseTemplate:renderAfterPortlet method.Jun 11 2021, 3:38 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Timeless, MonoBook.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Jun 11 2021, 9:01 PM
Jdlrobson removed a project: Patch-For-Review.
Jdlrobson updated the task description. (Show Details)
bwang removed bwang as the assignee of this task.Jun 14 2021, 2:27 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson claimed this task.Jun 14 2021, 5:04 PM
gerritbot added a comment.Jun 14 2021, 8:07 PM

Change 699249 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecations of portlet methods and hooks

https://gerrit.wikimedia.org/r/699249

bwang reassigned this task from Jdlrobson to Edtadros.Jun 14 2021, 8:09 PM
bwang moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson removed Edtadros as the assignee of this task.Jun 14 2021, 8:56 PM
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson added a subscriber: Edtadros.

This can skip QA as it has no impact on production code.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 14 2021, 9:00 PM
Jdlrobson claimed this task.Jun 21 2021, 5:13 PM
Jdlrobson reassigned this task from Jdlrobson to bwang.Jun 21 2021, 6:06 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Two of the Acceptance criteria have not been completed.

bwang removed bwang as the assignee of this task.Jun 21 2021, 7:08 PM
bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
bwang moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 22 2021, 3:02 PM

Change 700929 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove reference to BaseTemplateAfterPortlet

https://gerrit.wikimedia.org/r/700929

gerritbot added a project: Patch-For-Review.Jun 22 2021, 3:02 PM
gerritbot added a comment.Jun 22 2021, 3:18 PM

Change 700934 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Metrolook@master] Replace deprecated BaseTemplate::renderAfterPortlet with Skin::getAfterPortlet

https://gerrit.wikimedia.org/r/700934

bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 22 2021, 3:18 PM
Jdlrobson closed this task as Resolved.Jun 22 2021, 3:32 PM
Jdlrobson claimed this task.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 22 2021, 3:53 PM

Change 700929 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove reference to BaseTemplateAfterPortlet

https://gerrit.wikimedia.org/r/700929

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.12; 2021-06-28); removed MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 22 2021, 4:00 PM
bwang added a comment.EditedJun 23 2021, 5:20 PM

@Jdlrobson I think this task isnt done yet, as this patch hasnt been merged yet
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Metrolook/+/700934

gerritbot added a comment.Jul 22 2021, 5:30 PM

Change 700934 merged by jenkins-bot:

[mediawiki/skins/Metrolook@master] Replace deprecated BaseTemplate::renderAfterPortlet with Skin::getAfterPortlet

https://gerrit.wikimedia.org/r/700934

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL