Page MenuHomePhabricator

extensions/WikibaseMediaInfo - Use UserGroupManager instead of User group methods
Closed, ResolvedPublic

Description

Find all usages of:

  • public function getGroups()
  • public function getGroupMemberships()
  • public function getEffectiveGroups()
  • public function getAutomaticGroups()
  • public function getFormerGroups()
  • public function addGroup()
  • public function removeGroup()
  • public function addAutopromoteOnceGroups())

and need to be replaced with corresponding UserGroupManager methods. You can obtain UserGroupManager via MediaWikiServices::getInstance()->getUserGroupManager(), but it's preferred to inject it if possible.

Event Timeline

Vlad.shapik renamed this task from extensions/WikibaseMediaInfo - hard deprecate User group methods to extensions/WikibaseMediaInfo - Use UserGroupManager instead of User group methods.May 6 2021, 2:32 PM

Change 689942 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/WikibaseMediaInfo@master] Replace deprecated User group methods

https://gerrit.wikimedia.org/r/689942

Change 699429 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/WikibaseMediaInfo@master] Remove WikibaseMediaInfoHooks::userCanEdit

https://gerrit.wikimedia.org/r/699429

Change 699429 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Remove WikibaseMediaInfoHooks::userCanEdit

https://gerrit.wikimedia.org/r/699429

Change 689942 abandoned by Vlad.shapik:

[mediawiki/extensions/WikibaseMediaInfo@master] Replace deprecated User group methods

Reason:

This issue was fixed in the following patch - I2caefc0bb68d4043f3d7eb72c301ff742eeac1ae

https://gerrit.wikimedia.org/r/689942

@Vlad.shapik can this be resolved now?

Sure. The necessary patch was merged.