Page MenuHomePhabricator

improve new mailing list admin notifications
Open, MediumPublic

Description

I just received an email from root at wikimedia dot org, that a moderation request was waiting. My suggestion would be the following:

  • Change the sender information to something human readable (e.g. "Wikimedia Lists Admin Notifications")
  • Include a link to the admin page (especially now that we're going to a new system, it's always a hassle to remember where it is) ideally in plaintext.

Thanks!

Event Timeline

Change the sender information to something human readable (e.g. "Wikimedia Lists Admin Notifications")

Hmm, it shouldn't be coming from root@. I'll look into that.

Include a link to the admin page (especially now that we're going to a new system, it's always a hassle to remember where it is) ideally in plaintext.

What language was your email notification in?

The email was in English. Happy to forward if that is of help.

The email was in English. Happy to forward if that is of help.

Uhh, yes please. legoktm@wikimedia.org

Thanks, this is https://gitlab.com/mailman/mailman/-/blob/master/src/mailman/commands/cli_notify.py#L134 which is not customizable via the template system (there's a TODO for it), so it'll need an upstream fix. We can probably patch it in manually in the meantime.

Ladsgroup triaged this task as Medium priority.May 5 2021, 8:56 PM

Here's the patch I've hacked in for now:

From: Kunal Mehta <legoktm@debian.org>
Date: Thu, 6 May 2021 14:25:41 -0700
Subject: Hack in a link to Postorius for admin notifications

---
 src/mailman/commands/cli_notify.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/mailman/commands/cli_notify.py b/src/mailman/commands/cli_notify.py
index 3a24e66..cd9c6a3 100644
--- a/src/mailman/commands/cli_notify.py
+++ b/src/mailman/commands/cli_notify.py
@@ -135,6 +135,8 @@ def _send_notice(mlist, count, detail):
 {}
 Please attend to this at your earliest convenience.
 """).format(mlist.fqdn_listname, count, detail)
+    # Wikimedia HACK (T281987)
+    text += "\n https://lists.wikimedia.org/postorius/lists/{}/\n".format(mlist.list_id)
     msg = OwnerNotification(mlist, subject, text, mlist.administrators)
     msg.send(mlist)

And because of rOPUP9b8147775d1e: mailman3: Change owner email from root@ to listadmins-owner the emails will now come from listadmins-owner@lists.wikimedia.org, which should be a bit better. I'll file an upstream task for allowing us to put a name on the sender and maybe have them come from noreply@