Special:AutoblockList shows regular blocks after block edited/reblocking
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	May 10 2021, 2:56 PM

Description

What is the problem?

After editing a block (i.e. reblocking), it appears in Special:AutoblockList.

I think this is because when you reblock ipb_parent_block_id gets changed from NULL to 0 and SpecialAutoblockList.php queries for ipb_parent_block_id IS NOT NULL.

Special:AutoblockList should only show autoblocks.

Steps to reproduce problem

Block $user via Special:Block
Reblock $user via Special:Block/$user (it doesn't matter which parameters you change)
Go to Special:AutoblockList

Expected behavior: You should only see autoblocks (i.e. entries of the form Autoblock #nnn)
Observed behavior: You see block against $user

Environment

Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.37.0-alpha (3fad861) 02:08, 7 May 2021

Details

	Subject	Repo	Branch	Lines +/-
	Fix Special:AutoblockList showing normal blocks after reblocks	mediawiki/core	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned Here: T282890: Value inserted into ipb_parent_block_id is 0 if a block with autoblock enabled is updated
rMW3fad8612abd9: Merge "LinksUpdate: don't throw if page does not exist"

Event Timeline

dom_walden created this task.May 10 2021, 2:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2021, 2:56 PM

• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.May 12 2021, 1:24 PM

Count_Count subscribed.Jun 16 2021, 5:11 PM

phuedx moved this task from Triage/To be Estimated to Untriaged on the Anti-Harassment board.Oct 18 2021, 2:02 PM

phuedx moved this task from Untriaged to MediaWiki-Blocks on the Anti-Harassment board.Oct 18 2021, 2:06 PM

The root cause for this is T282890, but the query can be fixed to avoid that as well

Change 833079 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Fix Special:AutoblockList showing normal blocks after reblocks

https://gerrit.wikimedia.org/r/833079

gerritbot added a project: Patch-For-Review.Sep 19 2022, 6:42 PM

Change 833079 merged by jenkins-bot: