Page MenuHomePhabricator

User page shows up as article tab in MonoBook, Timeless skins
Closed, ResolvedPublic

Description

Event Timeline

Legoktm triaged this task as Unbreak Now! priority.May 12 2021, 5:35 AM
Legoktm created this task.

Change 689065 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@master] Revert "Create buildPersonalPage method for SkinTemplate class, add menu item to personal menu.."

https://gerrit.wikimedia.org/r/689065

Change 689065 merged by jenkins-bot:

[mediawiki/core@master] Revert "Create buildPersonalPage method for SkinTemplate class, add menu item to personal menu.."

https://gerrit.wikimedia.org/r/689065

Change 689532 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@wmf/1.37.0-wmf.5] Revert "Create buildPersonalPage method for SkinTemplate class, add menu item to personal menu.."

https://gerrit.wikimedia.org/r/689532

Change 689938 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Modern keys must be unset

https://gerrit.wikimedia.org/r/689938

Change 689889 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@wmf/1.37.0-wmf.5] Modern keys must be unset

https://gerrit.wikimedia.org/r/689889

Change 689532 abandoned by Jdlrobson:

[mediawiki/core@wmf/1.37.0-wmf.5] Revert "Create buildPersonalPage method for SkinTemplate class, add menu item to personal menu.."

Reason:

I will be backporting https://gerrit.wikimedia.org/r/c/mediawiki/core/ /689889 instead

https://gerrit.wikimedia.org/r/689532

Change 689889 merged by Urbanecm:

[mediawiki/core@wmf/1.37.0-wmf.5] Modern keys must be unset

https://gerrit.wikimedia.org/r/689889

Mentioned in SAL (#wikimedia-operations) [2021-05-12T18:11:00Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.5/includes/skins/SkinTemplate.php: 7f1491337d1eef2629fea8031f066c490ea86987: Modern keys must be unset (T282646) (duration: 01m 08s)

Jdlrobson lowered the priority of this task from Unbreak Now! to Needs Triage.May 12 2021, 6:47 PM

Change 689938 merged by jenkins-bot:

[mediawiki/core@master] Modern keys must be unset

https://gerrit.wikimedia.org/r/689938

@Legoktm - I'm curious why this was tagged as Unbreak Now? It was a visual regression on a non-default skin that did not remove any existing functionality.

@Legoktm - I'm curious why this was tagged as Unbreak Now? It was a visual regression on a non-default skin that did not remove any existing functionality.

See https://www.mediawiki.org/wiki/Phabricator/Project_management#Priority_levels "Something is broken and needs to be fixed immediately, setting anything else aside". I dropped everything to identify the problematic change, test a revert locally, merge it in Gerrit and ping the relevant Phabricator tasks. As I wrote in my commit message, it was an unannounced breaking change in violation of the stable interface policy and therefore shouldn't have been merged in the first place.

The wheel warring that happened earlier was incredibly inappropriate, I don't really have anything else to say at the moment.