User page shows up as article tab in MonoBook, Timeless skins
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	May 12 2021, 5:35 AM

Description

Screenshot_2021-05-11 Watchlist wishlist - MediaWiki(1).png (798×2 px, 82 KB)

Details

Subject	Repo	Branch	Lines +/-
Modern keys must be unset	mediawiki/core	master	+7 -1
Modern keys must be unset	mediawiki/core	wmf/1.37.0-wmf.5	+7 -1
Revert "Create buildPersonalPage method for SkinTemplate class, add menu item to personal menu.."	mediawiki/core	wmf/1.37.0-wmf.5	+8 -18
Revert "Create buildPersonalPage method for SkinTemplate class, add menu item to personal menu.."	mediawiki/core	master	+8 -18

Customize query in gerrit

Related Objects

Mentioned In: T300169: Should UI regressions (e.g. no fatals) with the non-default skins ever block the train?
T276561: User links: Logged-in user links menu treatment without icons (for anonymous users no change)
Mentioned Here: rMW7f1491337d1e: Modern keys must be unset

Event Timeline

Legoktm triaged this task as Unbreak Now! priority.May 12 2021, 5:35 AM

Legoktm created this task.

Legoktm added a parent task: T281146: 1.37.0-wmf.5 deployment blockers.

Legoktm updated the task description. (Show Details)May 12 2021, 5:40 AM

Change 689065 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@master] Revert "Create buildPersonalPage method for SkinTemplate class, add menu item to personal menu.."

https://gerrit.wikimedia.org/r/689065

gerritbot added a project: Patch-For-Review.May 12 2021, 5:44 AM

Legoktm mentioned this in T276561: User links: Logged-in user links menu treatment without icons (for anonymous users no change).May 12 2021, 5:47 AM

Change 689065 merged by jenkins-bot:

[mediawiki/core@master] Revert "Create buildPersonalPage method for SkinTemplate class, add menu item to personal menu.."

https://gerrit.wikimedia.org/r/689065

Change 689532 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@wmf/1.37.0-wmf.5] Revert "Create buildPersonalPage method for SkinTemplate class, add menu item to personal menu.."

https://gerrit.wikimedia.org/r/689532

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 12 2021, 7:00 AM

Change 689938 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Modern keys must be unset

https://gerrit.wikimedia.org/r/689938

Change 689889 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@wmf/1.37.0-wmf.5] Modern keys must be unset

https://gerrit.wikimedia.org/r/689889

backport scheduled for 11am PST

Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.May 12 2021, 3:45 PM

Change 689532 abandoned by Jdlrobson:

[mediawiki/core@wmf/1.37.0-wmf.5] Revert "Create buildPersonalPage method for SkinTemplate class, add menu item to personal menu.."

Reason:

I will be backporting https://gerrit.wikimedia.org/r/c/mediawiki/core/ /689889 instead

https://gerrit.wikimedia.org/r/689532

Change 689889 merged by Urbanecm:

[mediawiki/core@wmf/1.37.0-wmf.5] Modern keys must be unset

https://gerrit.wikimedia.org/r/689889

Mentioned in SAL (#wikimedia-operations) [2021-05-12T18:11:00Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.5/includes/skins/SkinTemplate.php: rMW7f1491337d1e: Modern keys must be unset (T282646) (duration: 01m 08s)

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.May 12 2021, 6:12 PM

Jdlrobson lowered the priority of this task from Unbreak Now! to Needs Triage.May 12 2021, 6:47 PM

Jdlrobson removed a parent task: T281146: 1.37.0-wmf.5 deployment blockers.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.5; 2021-05-11); removed MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 12 2021, 7:00 PM

Change 689938 merged by jenkins-bot:

[mediawiki/core@master] Modern keys must be unset

https://gerrit.wikimedia.org/r/689938

Jdlrobson assigned this task to ovasileva.May 12 2021, 11:49 PM

Maintenance_bot removed a project: Patch-For-Review.May 13 2021, 12:10 AM

@Legoktm - I'm curious why this was tagged as Unbreak Now? It was a visual regression on a non-default skin that did not remove any existing functionality.

Looks good now:

In T282646#7084499, @ovasileva wrote:

@Legoktm - I'm curious why this was tagged as Unbreak Now? It was a visual regression on a non-default skin that did not remove any existing functionality.

See https://www.mediawiki.org/wiki/Phabricator/Project_management#Priority_levels "Something is broken and needs to be fixed immediately, setting anything else aside". I dropped everything to identify the problematic change, test a revert locally, merge it in Gerrit and ping the relevant Phabricator tasks. As I wrote in my commit message, it was an unannounced breaking change in violation of the stable interface policy and therefore shouldn't have been merged in the first place.

The wheel warring that happened earlier was incredibly inappropriate, I don't really have anything else to say at the moment.

Jdlrobson mentioned this in T300169: Should UI regressions (e.g. no fatals) with the non-default skins ever block the train?.Jan 26 2022, 5:03 PM

	F34452565: Screen Shot 2021-05-13 at 10.04.55 AM.png
	May 13 2021, 8:05 AM

	F34451219: Screenshot_2021-05-11 Watchlist wishlist - MediaWiki(1).png
	May 12 2021, 5:40 AM

	F34451210: Screenshot_2021-05-11 Watchlist wishlist - MediaWiki.png
	May 12 2021, 5:35 AM

User page shows up as article tab in MonoBook, Timeless skinsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

User page shows up as article tab in MonoBook, Timeless skins
Closed, ResolvedPublic
Actions