Page MenuHomePhabricator

ArticleViewTest::testViewOfOldRevision is flaky
Open, HighPublic

Description

https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php72-docker/46526/console
https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php73-docker/8809/console

05:49:41 There was 1 failure:
05:49:41 
05:49:41 1) ArticleViewTest::testViewOfOldRevision
05:49:41 Failed asserting that two strings are identical.
05:49:41 --- Expected
05:49:41 +++ Actual
05:49:41 @@ @@
05:49:41 -'20210512054754'
05:49:41 +'20210512054755'

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/689067/4/tests/phpunit/includes/page/ArticleViewTest.php

Event Timeline

Legoktm triaged this task as High priority.May 12 2021, 6:02 AM
Legoktm created this task.

Change 689484 had a related patch set uploaded (by DannyS712; author: Tim Starling):

[mediawiki/core@master] Revert flaky timestamp assertion in ArticleViewTest

https://gerrit.wikimedia.org/r/689484

Change 689484 merged by Tim Starling:

[mediawiki/core@master] Revert flaky timestamp assertion in ArticleViewTest

https://gerrit.wikimedia.org/r/689484

Change 689852 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/core@master] Article: Use correct timestamp for OutputPage::setRevisionTimestamp

https://gerrit.wikimedia.org/r/689852

Change 689855 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/core@master] ArticleViewTest: Make timestamp tests deterministic

https://gerrit.wikimedia.org/r/689855

Change 689852 merged by jenkins-bot:

[mediawiki/core@master] Article: Use correct timestamp for OutputPage::setRevisionTimestamp

https://gerrit.wikimedia.org/r/689852

Change 689855 merged by jenkins-bot:

[mediawiki/core@master] ArticleViewTest: Make timestamp tests deterministic

https://gerrit.wikimedia.org/r/689855