Maniphest T282648

ArticleViewTest::testViewOfOldRevision is flaky
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	May 12 2021, 6:02 AM

Tags

Referenced Files

None

Subscribers

Description

https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php72-docker/46526/console
https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php73-docker/8809/console

05:49:41 There was 1 failure:
05:49:41 
05:49:41 1) ArticleViewTest::testViewOfOldRevision
05:49:41 Failed asserting that two strings are identical.
05:49:41 --- Expected
05:49:41 +++ Actual
05:49:41 @@ @@
05:49:41 -'20210512054754'
05:49:41 +'20210512054755'

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/689067/4/tests/phpunit/includes/page/ArticleViewTest.php

Details

	Subject	Repo	Branch	Lines +/-
	ArticleViewTest: Make timestamp tests deterministic	mediawiki/core	master	+7 -0
	Article: Use correct timestamp for OutputPage::setRevisionTimestamp	mediawiki/core	master	+3 -1
	Revert flaky timestamp assertion in ArticleViewTest	mediawiki/core	master	+0 -2

Customize query in gerrit

Event Timeline

Legoktm triaged this task as High priority.May 12 2021, 6:02 AM

Legoktm created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2021, 6:02 AM

Change 689484 had a related patch set uploaded (by DannyS712; author: Tim Starling):

[mediawiki/core@master] Revert flaky timestamp assertion in ArticleViewTest

https://gerrit.wikimedia.org/r/689484

gerritbot added a project: Patch-For-Review.May 12 2021, 9:10 AM

DannyS712 subscribed.May 12 2021, 9:11 AM

Change 689484 merged by Tim Starling:

[mediawiki/core@master] Revert flaky timestamp assertion in ArticleViewTest

https://gerrit.wikimedia.org/r/689484

Maintenance_bot removed a project: Patch-For-Review.May 12 2021, 10:10 AM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 12 2021, 11:00 AM

Change 689852 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/core@master] Article: Use correct timestamp for OutputPage::setRevisionTimestamp

https://gerrit.wikimedia.org/r/689852

gerritbot added a project: Patch-For-Review.May 12 2021, 1:21 PM

Change 689855 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/core@master] ArticleViewTest: Make timestamp tests deterministic

https://gerrit.wikimedia.org/r/689855

hoo claimed this task.May 12 2021, 1:36 PM

Change 689852 merged by jenkins-bot:

[mediawiki/core@master] Article: Use correct timestamp for OutputPage::setRevisionTimestamp

https://gerrit.wikimedia.org/r/689852

Change 689855 merged by jenkins-bot:

[mediawiki/core@master] ArticleViewTest: Make timestamp tests deterministic

https://gerrit.wikimedia.org/r/689855

Maintenance_bot removed a project: Patch-For-Review.May 14 2021, 2:10 AM

Daimona closed this task as Resolved.Aug 19 2023, 5:49 PM