Page MenuHomePhabricator
Create Task
Maniphest T282897

Remove/Replace use of deprecated hook SkinTemplateOutputPageBeforeExec
Open, Needs TriagePublic
Actions

Description

Some extension still using SkinTemplateOutputPageBeforeExec hook which trigger a deprecation notice and selenium are failing, which makes the whole extension broken.

Search: https://codesearch.wmcloud.org/search/?q=%5B%22%27%5DSkinTemplateOutputPageBeforeExec&i=nope&files=&excludeFiles=&repos=

  • ExtraLanguageLink
  • HitCounters
  • Interlanguage (being archived)
  • LanguageSelector
  • PictureGame
  • Polyglot
  • StickToThatLanguage

Details

SubjectRepoBranchLines +/-
Version 0.3.4mediawiki/extensions/HitCountersREL1_35+520 -81
Version 0.3.4mediawiki/extensions/HitCountersmaster+389 -70
Version 0.3.4mediawiki/extensions/HitCountersREL1_36+389 -72
Crude but apparently functional hack to work around the deprecation of the SkinTemplateOutputPageBeforeExec hook in MW 1.35mediawiki/extensions/PictureGamemaster+5 -17
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.May 14 2021, 8:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2021, 8:26 PM
Maintenance_bot added a project: Social-Tools.May 14 2021, 8:45 PM
gerritbot added a comment.May 15 2021, 12:58 PM

Change 691616 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/PictureGame@master] Crude but apparently functional hack to work around the deprecation of the SkinTemplateOutputPageBeforeExec hook in MW 1.35

https://gerrit.wikimedia.org/r/691616

gerritbot added a project: Patch-For-Review.May 15 2021, 12:58 PM
ashley moved this task from Backlog to PictureGame on the Social-Tools board.May 15 2021, 2:53 PM
gerritbot added a comment.May 18 2021, 4:24 PM

Change 691616 merged by jenkins-bot:

[mediawiki/extensions/PictureGame@master] Crude but apparently functional hack to work around the deprecation of the SkinTemplateOutputPageBeforeExec hook in MW 1.35

https://gerrit.wikimedia.org/r/691616

ashley mentioned this in rEPGAafb8eba73ea3: Crude but apparently functional hack to work around the deprecation of the….May 18 2021, 4:40 PM
Maintenance_bot removed a project: Patch-For-Review.May 18 2021, 5:10 PM
Aklapper updated the task description. (Show Details)Jun 6 2021, 4:56 AM
gerritbot added a comment.Jun 9 2021, 11:58 PM

Change 698896 had a related patch set uploaded (by MarkAHershberger; author: WikiMANNia):

[mediawiki/extensions/HitCounters@master] Version 0.3.2.3

https://gerrit.wikimedia.org/r/698896

gerritbot added a project: Patch-For-Review.Jun 9 2021, 11:59 PM
gerritbot added a comment.Jun 13 2021, 9:44 PM

Change 698896 merged by jenkins-bot:

[mediawiki/extensions/HitCounters@master] Version 0.3.4

https://gerrit.wikimedia.org/r/698896

Jdlrobson updated the task description. (Show Details)Jun 14 2021, 6:12 PM
gerritbot added a comment.Jun 16 2021, 1:11 PM

Change 700028 had a related patch set uploaded (by MarkAHershberger; author: WikiMANNia):

[mediawiki/extensions/HitCounters@REL1_36] Version 0.3.4

https://gerrit.wikimedia.org/r/700028

gerritbot added a comment.Jun 16 2021, 1:32 PM

Change 700028 merged by jenkins-bot:

[mediawiki/extensions/HitCounters@REL1_36] Version 0.3.4

https://gerrit.wikimedia.org/r/700028

gerritbot added a comment.Jul 5 2021, 5:07 PM

Change 703229 had a related patch set uploaded (by MarkAHershberger; author: WikiMANNia):

[mediawiki/extensions/HitCounters@REL1_35] Version 0.3.4

https://gerrit.wikimedia.org/r/703229

Umherirrender unsubscribed.Nov 25 2021, 6:32 PM
Lziobro added subscribers: MarkAHershberger, Lziobro.Mar 8 2022, 4:26 PM
In T282897#7198086, @gerritbot wrote:

Change 703229 had a related patch set uploaded (by MarkAHershberger; author: WikiMANNia):

[mediawiki/extensions/HitCounters@REL1_35] Version 0.3.4

https://gerrit.wikimedia.org/r/703229

@MarkAHershberger any possibility to to keep the REL1_35 fix moving along for HitCounters? Looks like it's been stuck in review for a while. I would appreciate if we could do that. Thank you.

ashley removed projects: Social-Tools, PictureGame.Mar 10 2022, 6:50 PM
ashley subscribed.

Removing PictureGame and Social-Tools tags because the PictureGame patch was merged a while ago.

In T282897#7760640, @Lziobro wrote:
In T282897#7198086, @gerritbot wrote:

Change 703229 had a related patch set uploaded (by MarkAHershberger; author: WikiMANNia):

[mediawiki/extensions/HitCounters@REL1_35] Version 0.3.4

https://gerrit.wikimedia.org/r/703229

@MarkAHershberger any possibility to to keep the REL1_35 fix moving along for HitCounters? Looks like it's been stuck in review for a while. I would appreciate if we could do that. Thank you.

I took the liberty of addressing the one and only issue pointed out in code review, especially since the reviewer had also provided not just a description of the issue at hand that they found but also how to fix it. That said, I'm not familiar with the extension (though I know it's a former MW core feature split out of core at some point...circa MW 1.25? or something like that) so while I have the technical ability to +2 the patch, I'd certainly prefer someone else more familiar with the codebase to do that, but if that's not doable, please feel free to ping me in a few weeks or so.

gerritbot added a comment.Mar 11 2022, 12:57 AM

Change 703229 merged by jenkins-bot:

[mediawiki/extensions/HitCounters@REL1_35] Version 0.3.4

https://gerrit.wikimedia.org/r/703229

Kizule removed projects: Patch-For-Review, MediaWiki-extensions-News.Feb 27 2023, 9:44 PM
Kizule updated the task description. (Show Details)
Pppery subscribed.Sep 22 2023, 11:49 PM
Pppery removed a project: MediaWiki-extensions-Interlanguage.May 30 2024, 4:22 AM
Pppery updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits