Maniphest T282956

ULS settings window can’t be opened with the preferences link on new Vector
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to reproduce

Go to your preferences with legacy Vector, e.g. on enwiki.
Under Internationalization, click More language settings.
Notice that the Universal Language Selector settings dialog opens.
Go to your preferences, this time with modern Vector, e.g. on enwiki.
Under Internationalization, click More language settings.

Actual results

Nothing happens. (Not even a warning or error message on the browser console.)

Expected results

The ULS dialog opens, just like with legacy Vector.

Outcome

"More language settings" link is working again on the preferences page.

Details

	Subject	Repo	Branch	Lines +/-
	Fix regressions in ULS entry point setup	mediawiki/extensions/UniversalLanguageSelector	master	+125 -107

Customize query in gerrit

Related Objects

Mentioned Here: T286459: Turn off A/B test for language switching on pilot wikis

Event Timeline

Tacsipacsi created this task.May 16 2021, 12:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2021, 12:13 AM

> Under Internationalization, click More language settings.

Where is this in the UI? I can't see it.

@Nikerabbit is this related to the changes we made to wiring up elements? Do we need to add a class somewhere?

The code in question is: https://gerrit.wikimedia.org/g/mediawiki/extensions/UniversalLanguageSelector/+/7c6a6b528b5fdbf1df11bcfe3c0a2802be195618/resources/js/ext.uls.interface.js#386

The issue is that $trigger is empty collection, because all entry points have been removed from Special:Preferences.

One solution would be to refactor the code so that it constructs the ULS when clicking that entry point, instead of just trying to pass the click forward to the now non-existing entry point.

Right. Makes sense. Could we not add the '.uls-trigger' or 'uls-settings-trigger' class to this element?

There is event logging that sets a different origin for the preferences click. Perhaps that is not needed anymore.

@Nikerabbit who do we need to ask to work out if it's needed?

I asked around and it seems to be okay to simplify the code and do like you suggested.

• Nikerabbit removed a project: Language-Team.Jun 21 2021, 10:45 AM

Change 701496 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/UniversalLanguageSelector@master] Fix regressions in ULS entry point setup

https://gerrit.wikimedia.org/r/701496

gerritbot added a project: Patch-For-Review.Jun 25 2021, 9:51 AM

• Nikerabbit added a project: Language-Team (Language-2021-April-June).Jun 25 2021, 9:54 AM

• Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-April-June) board.

• Nikerabbit claimed this task.Jun 28 2021, 7:12 AM

• Nikerabbit triaged this task as High priority.Jun 28 2021, 9:59 AM

• Nikerabbit added a project: Regression.

ovasileva subscribed.Jun 28 2021, 4:37 PM

Waiting for A/B test to finish.

Pginer-WMF edited projects, added Language-Team (Language-2021-July-September); removed Language-Team (Language-2021-April-June).Jul 12 2021, 8:06 AM

Pginer-WMF moved this task from Quarter Backlog to Blocked on the Language-Team (Language-2021-July-September) board.

In T282956#7186029, @Nikerabbit wrote:

Waiting for A/B test to finish.

@Nikerabbit - Tracking turning off the A/B test here T286459: Turn off A/B test for language switching on pilot wikis. Initial deadline was today, but we'll be doing some extra QA and will most likely turn it off later in the week.