Page MenuHomePhabricator

ULS settings window can’t be opened with the preferences link on new Vector
Closed, ResolvedPublicBUG REPORT


Steps to reproduce

  1. Go to your preferences with legacy Vector, e.g. on enwiki.
  2. Under Internationalization, click More language settings.
  3. Notice that the Universal Language Selector settings dialog opens.
  4. Go to your preferences, this time with modern Vector, e.g. on enwiki.
  5. Under Internationalization, click More language settings.

Actual results

  1. Nothing happens. (Not even a warning or error message on the browser console.)

Expected results

  1. The ULS dialog opens, just like with legacy Vector.


"More language settings" link is working again on the preferences page.

Event Timeline

Jdlrobson added subscribers: Nikerabbit, Jdlrobson.

> Under Internationalization, click More language settings.

Where is this in the UI? I can't see it.

@Nikerabbit is this related to the changes we made to wiring up elements? Do we need to add a class somewhere?

The code in question is:

The issue is that $trigger is empty collection, because all entry points have been removed from Special:Preferences.

One solution would be to refactor the code so that it constructs the ULS when clicking that entry point, instead of just trying to pass the click forward to the now non-existing entry point.

Right. Makes sense. Could we not add the '.uls-trigger' or 'uls-settings-trigger' class to this element?

There is event logging that sets a different origin for the preferences click. Perhaps that is not needed anymore.

I asked around and it seems to be okay to simplify the code and do like you suggested.

Change 701496 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/UniversalLanguageSelector@master] Fix regressions in ULS entry point setup

Nikerabbit added a project: Regression.

Waiting for A/B test to finish.

@Nikerabbit - Tracking turning off the A/B test here T286459: Turn off A/B test for language switching on pilot wikis. Initial deadline was today, but we'll be doing some extra QA and will most likely turn it off later in the week.

Change 701496 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Fix regressions in ULS entry point setup

Nikerabbit updated the task description. (Show Details)