Maniphest T283354

Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's PurgeEntityDataJob
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Michael
	May 21 2021, 1:30 PM

Tags

Referenced Files

None

Subscribers

Description

The usage of PurgeEntityDataJob seems to be mostly standard:

$this->lbFactory->waitForReplication( [
	'domain' => $this->lbFactory->getLocalDomainID(),
] );
$dbr = $this->lbFactory->getMainLB()->getConnection( ILoadBalancer::DB_REPLICA );

Details

	Subject	Repo	Branch	Lines +/-
	Create database service abstraction	mediawiki/extensions/Wikibase	master	+355 -14

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T281453 Abstract database connections between Client and Repository
		Resolved		Addshore	T283246 Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used
		Resolved		Jakob_WMDE	T283354 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's PurgeEntityDataJob

Event Timeline

Michael created this task.May 21 2021, 1:30 PM

Change 693442 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Create database connection service abstraction

https://gerrit.wikimedia.org/r/693442

gerritbot added a project: Patch-For-Review.May 21 2021, 3:06 PM

Michael removed a project: [DEPRECATED] wdwb-tech.May 21 2021, 3:34 PM

Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 25 2021, 9:52 AM

Jakob_WMDE claimed this task.May 26 2021, 9:36 AM

Michael mentioned this in T283246: Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used.May 31 2021, 9:14 AM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 2 2021, 12:40 PM

Change 693442 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Create database service abstraction

https://gerrit.wikimedia.org/r/693442

Maintenance_bot removed a project: Patch-For-Review.Jun 2 2021, 3:10 PM

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 2 2021, 10:07 PM

Jakob_WMDE closed this task as Resolved.Jun 3 2021, 3:08 PM

Jakob_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.