Page MenuHomePhabricator

link_suggestion_interaction schema: `close` action token is different from token in preceding action `editsummary_save`
Closed, ResolvedPublic

Description

As noted by @nettrom_WMF

based on the description of homepage_pageview_token in the schema, I’d expect it to stay consistent so that it can correctly be joined with HomepageVisit/HomepageModule. In the events logged from Elena’s testing, the token set when active_interface=editsummary_dialog, action=close is different from the preceding action=editsummary_save

Confirmed by @Tgr

We reset the token at some point so that when the user clicks on the post-edit task suggestion, that's logged with a separate token. Due to the way we are setting up the postedit dialog, it's happening right before the save dialog is closed.

Event Timeline

Etonkovidova renamed this task from link_suggestion_interaction schema: the `close` action token is different from preceding action `editsummary_save` to link_suggestion_interaction schema: `close` action token is different from token in preceding action `editsummary_save`.May 26 2021, 9:23 PM
kostajh triaged this task as High priority.May 27 2021, 8:57 AM
kostajh moved this task from Backlog to May 24 – May 28 on the Add-Link board.

Change 696583 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Link: Avoid homepage PV token changing during save dialog close

https://gerrit.wikimedia.org/r/696583

Change 696587 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Add Link: Log the newcomer task token in getCard

https://gerrit.wikimedia.org/r/696587

Change 696587 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] Add Link: Log the newcomer task token in getCard

Reason:

squashed into parent

https://gerrit.wikimedia.org/r/696587

Change 696527 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Add Link: Fix homepage PV token and newcomer task token logging

https://gerrit.wikimedia.org/r/696527

Change 696530 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Add Link: Fix homepage PV token and newcomer task token logging

https://gerrit.wikimedia.org/r/696530

Change 696583 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Link: Fix homepage PV token and newcomer task token logging

https://gerrit.wikimedia.org/r/696583

Change 696527 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Add Link: Fix homepage PV token and newcomer task token logging

https://gerrit.wikimedia.org/r/696527

Mentioned in SAL (#wikimedia-operations) [2021-05-27T18:49:04Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.7/extensions/GrowthExperiments: Backport: [[gerrit:695834|Help panel: SwitchEditorPanel fixes (T282800)]] [[gerrit:695842|Avoid session loading when loading task types in help panel RL data (T282800)]] [[gerrit:696527|Add Link: Fix homepage PV token and newcomer task token logging (T283765)]] (duration: 01m 06s)

Change 696530 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Add Link: Fix homepage PV token and newcomer task token logging

https://gerrit.wikimedia.org/r/696530

Mentioned in SAL (#wikimedia-operations) [2021-05-27T19:03:22Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.6/extensions/GrowthExperiments: Backport: [[gerrit:695833|Help panel: SwitchEditorPanel fixes (T282800)]] [[gerrit:695841|Avoid session loading when loading task types in help panel RL data (T282800)]] [[gerrit:696530|Add Link: Fix homepage PV token and newcomer task token logging (T283765)]] (duration: 01m 05s)

Etonkovidova claimed this task.

Checked for the following actions:

  • user clicks on 'Publish changes' - two events are recorded:
{action: "editsummary_save", action_data: "", is_mobile: false, active_interface: "editsummary_dialog", newcomer_task_token: "b8498cacbf39a27b6387", …}
 {action: "close", action_data: "", is_mobile: false, active_interface: "editsummary_dialog", newcomer_task_token: "b8498cacbf39a27b6387", …}
  • checked if the newcomer_task_token is the same for other user action during interactions with add link interface.

newcomer_task_token has the same value through all interactions with the add link UI.