Upgrade WVUI node.js version
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	egardner
	Jun 3 2021, 8:27 PM

Description

WVUI currently specifies a node.js version of 10.15.2 in its .nvmrc file, and that version is also used in CI for tests and builds.

This LTS version is either already at end-of-life or will be very shortly: https://nodejs.org/en/about/releases/

We should consider moving to a more recent LTS version of Node – v14 or v16 is what I'd suggest, to maximize the time until we have to switch again.

Remaining on Node v10 will block some of the work being explored in T272879 and will probably prevent us from using other tools in the future.

Would this upgrade require a security review?
No, not from past upgrades aligning downstream version with CI upgraded ones.

Acceptance criteria

Upgrade to Node v12 for now to unblock using Vite

Further upgrading will happen in successor library and be dependent on T267888

Details

	Subject	Repo	Branch	Lines +/-
	Update WVUI to v0.3.0	mediawiki/core	master	+69 -40
	build: Switch base image to node12 / bullseye now it's available	wvui	master	+4 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdforrester-WMF	T284253 Upgrade WVUI node.js version
		Resolved		Jdforrester-WMF	T284346 Provide a node 12 production image (based on bullseye?)

Event Timeline

egardner created this task.Jun 3 2021, 8:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2021, 8:27 PM

@Jdforrester-WMF tells me this is blocked on upgrading the version of Node used in our CI images, which is in turn blocked on SRE approving a newer version of Node (at least for pipeline jobs like the one used for WVUI, which uses a production image)

Catrope added a subtask: T267888: Create WMF CI image for Node.js 14.Jun 4 2021, 6:16 PM

I've created T284343: Create WMF CI image for Node.js 12 for WMF CI, but you'd need T284346: Provide a node 12 production image (based on bullseye?) for the pipeline.

egardner moved this task from To Do to Blocked on the Deprecated-Design-Systems-team-board board.Jun 4 2021, 7:03 PM

Hmm, would Node.js v12 make any difference for our immediate needs, @egardner?

• LZaman moved this task from Blocked to Untriaged Backlog on the Deprecated-Design-Systems-team-board board.Jul 22 2021, 6:30 PM

In T284253#7145091, @Volker_E wrote:

Hmm, would Node.js v12 make any difference for our immediate needs, @egardner?

Yes, it would. Vite requires Node.js v12 or higher.

Changed to depend on the Node 12 task instead of the Node 14 task. We may want to switch away from the pipeline to a "regular" CI job if that allows us to use Node 12 faster.

Catrope mentioned this in T286950: Determine how the shared component library will be built and distributed.Jul 29 2021, 12:46 AM

Unfortunately, because WVUI uses the pipeline, this isn't blocked by T286950 (which is done), it's blocked by T284346 (which is not, and is not in my gift).

You could switch to the non-pipeline legacy CI system, but that wouldn't give you an automatic build step.

Jdforrester-WMF edited subtasks, added: T284346: Provide a node 12 production image (based on bullseye?); removed: T284345: Upgrade all CI jobs for WMF-deployed projects from Node 10 to Node 12.Jul 29 2021, 8:54 AM

Jdforrester-WMF mentioned this in T267888: Create WMF CI image for Node.js 14.Jul 29 2021, 10:20 AM

In T284253#7245653, @Jdforrester-WMF wrote:

You could switch to the non-pipeline legacy CI system, but that wouldn't give you an automatic build step.

Could you elaborate on (or link to documentation about) what the features are that the pipeline system gives us that the legacy system doesn't?

Legoktm closed subtask T284346: Provide a node 12 production image (based on bullseye?) as Resolved.Aug 18 2021, 6:20 PM

Change 713712 had a related patch set uploaded (by Jforrester; author: Jforrester):

[wvui@master] build: Switch base image to node12 / bullseyee now it's available

https://gerrit.wikimedia.org/r/713712

gerritbot added a project: Patch-For-Review.Aug 18 2021, 10:37 PM

In T284253#7252487, @Catrope wrote:

In T284253#7245653, @Jdforrester-WMF wrote:

You could switch to the non-pipeline legacy CI system, but that wouldn't give you an automatic build step.

Could you elaborate on (or link to documentation about) what the features are that the pipeline system gives us that the legacy system doesn't?

Ha, sorry!

The legacy system doesn't let you pick which packages are available, or stay on node10 when the central control chooses to upgrade everyone to node12. The new GitLab CI system will look a lot more like the pipeline than the legacy system. The legacy system has whatever features I or Antoine or Kunal made for it, whereas in the pipeline you can do almost anything (as long as you're based on WMF prod images).

Change 713712 merged by jenkins-bot:

[wvui@master] build: Switch base image to node12 / bullseye now it's available

https://gerrit.wikimedia.org/r/713712

Catrope mentioned this in rWVUIafed305fcadc: build: Switch base image to node12 / bullseye now it's available.Aug 18 2021, 11:11 PM

Jdforrester-WMF closed this task as Resolved.Aug 18 2021, 11:26 PM

Jdforrester-WMF claimed this task.

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2021, 12:10 AM

Volker_E updated the task description. (Show Details)Aug 23 2021, 7:07 PM

Change 715153 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update WVUI to v0.3.0

https://gerrit.wikimedia.org/r/715153

gerritbot added a project: Patch-For-Review.Aug 27 2021, 2:29 AM