Page MenuHomePhabricator

Extract new parameter (placeholder) "show all" implementation
Closed, ResolvedPublic0 Estimated Story Points

Description

There is wiring and state spanning multiple levels of container, to support the "show all parameters" feature. The current behavior is,

  • Initially show the "add parameter" dropdown area with a limited number of c. 5 parameters.
  • Final item is a "show all parameters" button. When clicked, show *all* of the template parameters.
  • Once show all has been activated, there is no way to collapse the list again.
  • Once show all has been activated, remember the choice and keep expanded if the user a) completes the action by choosing a named parameter or adding an unknown one, or b) deletes the placeholder item.
  • Do not change behavior.
  • Push "show all" feature down into the placeholder page.
  • Remember state by persisting the entire placeholder page. This isolates container classes from state implementation and action wiring.

Event Timeline

awight set the point value for this task to 0.
awight moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-05-26 board.

Change 698547 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Extract "show all" to placeholder class

https://gerrit.wikimedia.org/r/698547

Change 698547 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Extract "show all" to placeholder class

https://gerrit.wikimedia.org/r/698547

awight claimed this task.
awight moved this task from Review to Done on the WMDE-TechWish-Sprint-2021-06-09 board.

Change 701423 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Revert "Extract "show all" to placeholder class"

https://gerrit.wikimedia.org/r/701423

Change 701690 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Hotfix for broken "Extract show all to placeholder class"

https://gerrit.wikimedia.org/r/701690

Change 701644 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@wmf/1.37.0-wmf.11] Hotfix for broken "Extract show all to placeholder class"

https://gerrit.wikimedia.org/r/701644

Change 701690 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Hotfix for broken "Extract show all to placeholder class"

https://gerrit.wikimedia.org/r/701690

Change 701644 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.37.0-wmf.11] Hotfix for broken "Extract show all to placeholder class"

https://gerrit.wikimedia.org/r/701644

Mentioned in SAL (#wikimedia-operations) [2021-06-28T18:24:51Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.11/extensions/VisualEditor/: 794a46c861dbf5ac05ec824d7591e507c1eefd16: Hotfix for broken "Extract show all to placeholder class" (T284636; T285571) (duration: 00m 57s)

Change 701423 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Revert "Extract "show all" to placeholder class"

https://gerrit.wikimedia.org/r/701423