Wikimedia OCR: Weird tooltip for language selector
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jun 9 2021, 2:29 PM

Description

What is the problem?

The tooltip for the language selector produces weird output.

For example, selecting the "af" language and hovering over with mouse produces:

af
                            –
    Afrikaans

This appears to be related to the title attribute of the <li> element.

Steps to reproduce problem

https://ocr-test.wmcloud.org/?langs[]=af
Hover over the af - Afrikaans element

Expected behavior: Tooltip is af - Afrikaans
Observed behavior: Tooltip is as described above, with weird spacing

Environment

Wikimedia OCR: https://ocr-test.wmcloud.org Version 0.5.0-3-g1bf762c

Related Objects

Mentioned In: T284749: Update Herald (H260) to include upcoming CommTech sprint subprojects (5334, 5369, 5383)
T282760: Add language-mapping data

Event Timeline

dom_walden created this task.Jun 9 2021, 2:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2021, 2:29 PM

dom_walden mentioned this in T282760: Add language-mapping data.Jun 9 2021, 2:36 PM

https://github.com/wikimedia/wikimedia-ocr/pull/39

It took me quite a while to figure this out, since my browser wasn't displaying the whole whitespace thing when inspecting the vanilla selector in no-js mode, and I needed an actual "view source" to realize what's going on.

Merged. Thanks for fixing this so quickly, @Daimona! I'm moving this to the QA column on the sprint board.

Restricted Application edited projects, added Community-Tech; removed Community-Tech (CommTech-Sprint-2). · View Herald TranscriptJun 10 2021, 12:59 AM

MusikAnimal edited projects, added Community-Tech (CommTech-Sprint-2); removed Community-Tech.Jun 10 2021, 1:00 AM

MusikAnimal moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-2) board.

This looks good to me. The tooltip and the title attribute no longer have extraneous white-space.

As this is a small change, I will move straight into Done.

Test environment: https://ocr-test.wmcloud.org Version 0.5.0-6-g7729aec.

Daimona set Final Story Points to 2.Jun 10 2021, 9:40 AM

ldelench_wmf mentioned this in T284749: Update Herald (H260) to include upcoming CommTech sprint subprojects (5334, 5369, 5383).Jun 10 2021, 2:49 PM

ldelench_wmf closed this task as Resolved.Jun 10 2021, 8:38 PM

ldelench_wmf set the point value for this task to 2.Jun 10 2021, 8:40 PM

Wikimedia OCR: Weird tooltip for language selectorClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions