PHP Notice: Undefined index: query (in FileImporter/ApiDetailRetriever.php)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	Jun 12 2021, 4:38 PM

Description

Error

mwversion: 1.37.0-wmf.5
reqId: d9a98e46-9105-4f48-8ff6-204791a97488
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined index: query

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.5/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php(136)
#0 /srv/mediawiki/php-1.37.0-wmf.5/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php(136): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.5/extensions/FileImporter/src/Services/SourceSite.php(81): FileImporter\Remote\MediaWiki\ApiDetailRetriever->getImportDetails(FileImporter\Data\SourceUrl)
#2 /srv/mediawiki/php-1.37.0-wmf.5/extensions/FileImporter/src/SpecialImportFile.php(310): FileImporter\Services\SourceSite->retrieveImportDetails(FileImporter\Data\SourceUrl)
#3 /srv/mediawiki/php-1.37.0-wmf.5/extensions/FileImporter/src/SpecialImportFile.php(228): FileImporter\SpecialImportFile->makeImportPlan(WebRequest)
#4 /srv/mediawiki/php-1.37.0-wmf.5/includes/specialpage/SpecialPage.php(646): FileImporter\SpecialImportFile->execute(NULL)
#5 /srv/mediawiki/php-1.37.0-wmf.5/includes/specialpage/SpecialPageFactory.php(1396): SpecialPage->run(NULL)
#6 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(313): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#7 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(916): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(550): MediaWiki->main()
#9 /srv/mediawiki/php-1.37.0-wmf.5/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-1.37.0-wmf.5/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}

Impact

Notes

Details

Request URL: https://commons.wikimedia.org/wiki/Special:ImportFile?clientUrl=*&importSource=FileExporter

	Subject	Repo	Branch	Lines +/-
	Fix index error in ApiDetailRetriever	mediawiki/extensions/FileImporter	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T285306 More helpful error message when importing files from private wikis
		Resolved	PRODUCTION ERROR	thiemowmde	T284862 PHP Notice: Undefined index: query (in FileImporter/ApiDetailRetriever.php)

Event Timeline

Krinkle created this task.Jun 12 2021, 4:38 PM

Krinkle added a project: WMDE-TechWish.

There are about a dozen hits for this over the past two weeks. Somewhat spread out (not the same browsing session I think). It involves different files and differnet source wikis.

One thing that might be relevant is that the various errors all related to imports from a private wiki. Some of them involved files on otrs-wiki, and some of them involved fils on officewiki.

Krinkle moved this task from Untriaged to June 2021 on the Wikimedia-production-error board.Jun 12 2021, 4:40 PM

Thanks for the ticket and the ping!

WMDE-Fisch claimed this task.Jun 17 2021, 9:54 AM

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-06-09 board.

Change 700177 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Fix index error in ApiDetailRetriever

https://gerrit.wikimedia.org/r/700177

gerritbot added a project: Patch-For-Review.Jun 17 2021, 9:59 AM

Change 700177 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Fix index error in ApiDetailRetriever

https://gerrit.wikimedia.org/r/700177

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 17 2021, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 17 2021, 12:10 PM

WMDE-Fisch moved this task from Doing to Demo on the WMDE-TechWish-Sprint-2021-06-09 board.Jun 18 2021, 8:36 AM

WMDE-Fisch added a project: Unplanned-Sprint-Work.Jun 21 2021, 8:30 AM

awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-06-09 board.Jun 22 2021, 7:49 AM

thiemowmde closed this task as Resolved.Jun 22 2021, 9:03 AM

thiemowmde claimed this task.

thiemowmde mentioned this in T285306: More helpful error message when importing files from private wikis.

thiemowmde added a parent task: T285306: More helpful error message when importing files from private wikis.

thiemowmde moved this task from Backlog to Tickets in sprint on the Move-Files-To-Commons board.

PHP Notice: Undefined index: query (in FileImporter/ApiDetailRetriever.php)Closed, ResolvedPublicPRODUCTION ERRORActions