Page MenuHomePhabricator

PHP Notice: Undefined index: query (in FileImporter/ApiDetailRetriever.php)
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined index: query
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.5/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php(136)
#0 /srv/mediawiki/php-1.37.0-wmf.5/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php(136): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.5/extensions/FileImporter/src/Services/SourceSite.php(81): FileImporter\Remote\MediaWiki\ApiDetailRetriever->getImportDetails(FileImporter\Data\SourceUrl)
#2 /srv/mediawiki/php-1.37.0-wmf.5/extensions/FileImporter/src/SpecialImportFile.php(310): FileImporter\Services\SourceSite->retrieveImportDetails(FileImporter\Data\SourceUrl)
#3 /srv/mediawiki/php-1.37.0-wmf.5/extensions/FileImporter/src/SpecialImportFile.php(228): FileImporter\SpecialImportFile->makeImportPlan(WebRequest)
#4 /srv/mediawiki/php-1.37.0-wmf.5/includes/specialpage/SpecialPage.php(646): FileImporter\SpecialImportFile->execute(NULL)
#5 /srv/mediawiki/php-1.37.0-wmf.5/includes/specialpage/SpecialPageFactory.php(1396): SpecialPage->run(NULL)
#6 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(313): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#7 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(916): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(550): MediaWiki->main()
#9 /srv/mediawiki/php-1.37.0-wmf.5/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-1.37.0-wmf.5/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
Impact
Notes

Details

Request URL
https://commons.wikimedia.org/wiki/Special:ImportFile?clientUrl=*&importSource=FileExporter

Event Timeline

There are about a dozen hits for this over the past two weeks. Somewhat spread out (not the same browsing session I think). It involves different files and differnet source wikis.

One thing that might be relevant is that the various errors all related to imports from a private wiki. Some of them involved files on otrs-wiki, and some of them involved fils on officewiki.

WMDE-Fisch added a subscriber: WMDE-Fisch.

Thanks for the ticket and the ping!

Change 700177 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Fix index error in ApiDetailRetriever

https://gerrit.wikimedia.org/r/700177

Change 700177 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Fix index error in ApiDetailRetriever

https://gerrit.wikimedia.org/r/700177