Page MenuHomePhabricator

Loading-state label is missing
Closed, ResolvedPublic1 Estimated Story Points


When the page header and footer are hidden, the label inside the loading-state widget is also hidden.

hidden-ocr-label.png (209×1 px, 69 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 699831 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/ProofreadPage@master] Give textarea labels their own CSS class

It's not just the hiding/showing of the label, it's also small and grey when it is shown. The above patch fixes that too.

Change 699831 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Give textarea labels their own CSS class

Label is appearing now on beta:

label.png (563×1 px, 414 KB)

It displays as ⧼wikisource-ocr-extract-progress⧽, but I think that is cause by T285118. Other translations are also displaying similarly on beta.

Leaving this here until we can confirm this (or until T285118 is fixed).

Samwilson set the point value for this task to 1.
dom_walden moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Sprint-3) board.

This change is now in production, so I guess it doesn't matter if T285118 is fixed.

Screenshot from enwikisource:

loading_state.png (1×1 px, 773 KB)

Trivial change, so moving straight to Done.