Loading-state label is missing
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Samwilson
	Jun 15 2021, 3:45 AM

Description

When the page header and footer are hidden, the label inside the loading-state widget is also hidden.

	Subject	Repo	Branch	Lines +/-
	Give textarea labels their own CSS class	mediawiki/extensions/ProofreadPage	master	+19 -19

Mentioned In: T285345: Python3 scap breaks mediawiki
T282050: Wikisource OCR: add loading state improvements
Mentioned Here: T285118: beta: Error: Unsupported operand types

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 699831 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/ProofreadPage@master] Give textarea labels their own CSS class

It's not just the hiding/showing of the label, it's also small and grey when it is shown. The above patch fixes that too.

Merged

Change 699831 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Give textarea labels their own CSS class

Label is appearing now on beta:

It displays as ⧼wikisource-ocr-extract-progress⧽, but I think that is cause by T285118. Other translations are also displaying similarly on beta.

Leaving this here until we can confirm this (or until T285118 is fixed).

Samwilson set the point value for this task to 1.

This change is now in production, so I guess it doesn't matter if T285118 is fixed.

Screenshot from enwikisource:

Trivial change, so moving straight to Done.

	F34531566: loading_state.png
	Jun 29 2021, 11:48 AM

	F34511696: label.png
	Jun 18 2021, 12:13 PM