Page MenuHomePhabricator
Create Task
Maniphest T285449

Master tests failing for CentralNotice, "RuntimeException: Config accessed before it is set"
Closed, ResolvedPublic
Actions

Description

See example empty patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/701244
Caused by T277728: Deprecate non-injected accesss to ResourceLoaderModule::getConfig

Details

SubjectRepoBranchLines +/-
Revert "Remove non-injected accesss to ResourceLoaderModule::getConfig"mediawiki/extensions/CentralNoticemaster+3 -5
Update CNChoiceDataResourceLoaderModuleTestmediawiki/extensions/CentralNoticemaster+7 -16
Remove non-injected accesss to ResourceLoaderModule::getConfigmediawiki/extensions/CentralNoticemaster+5 -3
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Jun 24 2021, 5:18 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 24 2021, 5:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Jun 24 2021, 5:18 AM
DannyS712 mentioned this in T281152: 1.37.0-wmf.11 deployment blockers.
AndyRussG added a project: Fundraising-Backlog.Jun 24 2021, 3:49 PM
gerritbot added a comment.Jun 24 2021, 3:59 PM

Change 701404 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/CentralNotice@master] Remove non-injected accesss to ResourceLoaderModule::getConfig

https://gerrit.wikimedia.org/r/701404

gerritbot added a project: Patch-For-Review.Jun 24 2021, 3:59 PM
gerritbot added a comment.Jun 24 2021, 5:10 PM

Change 701404 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Remove non-injected accesss to ResourceLoaderModule::getConfig

https://gerrit.wikimedia.org/r/701404

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 24 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 24 2021, 6:10 PM
gerritbot added a comment.Jun 27 2021, 4:32 AM

Change 701673 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/CentralNotice@master] Update CNChoiceDataResourceLoaderModuleTest

https://gerrit.wikimedia.org/r/701673

gerritbot added a project: Patch-For-Review.Jun 27 2021, 4:32 AM
gerritbot added a comment.Jun 27 2021, 4:27 PM

Change 701419 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/CentralNotice@master] Revert "Remove non-injected accesss to ResourceLoaderModule::getConfig"

https://gerrit.wikimedia.org/r/701419

gerritbot added a comment.Jun 28 2021, 8:33 PM

Change 701673 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Update CNChoiceDataResourceLoaderModuleTest

https://gerrit.wikimedia.org/r/701673

gerritbot added a comment.Jun 28 2021, 8:37 PM

Change 701419 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Revert "Remove non-injected accesss to ResourceLoaderModule::getConfig"

https://gerrit.wikimedia.org/r/701419

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2021, 9:10 PM
• DStrine moved this task from Triage to Unscheduled on the Fundraising-Backlog board.Jul 1 2021, 3:35 PM
Krinkle closed this task as Resolved.Jul 1 2021, 6:16 PM
Krinkle assigned this task to AndyRussG.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits