Page MenuHomePhabricator
Create Task
Maniphest T281152

1.37.0-wmf.11 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Backup Train Conductor
jeena
Release Version
1.37.0-wmf.11
Release Date
Jun 21 2021, 12:00 AM

2021 week 25 1.37-wmf.11 Changes wmf/1.37.0-wmf.11

This MediaWiki Train Deployment is scheduled for the week of Monday, June 21st:

Monday June 21stTuesday, June 22ndWednesday, June 23rdThursday, June 24thFriday
Backports only.Branch wmf.11 and deploy to Group 0 Wikis.Deploy wmf.11 to Group 1 Wikis.Deploy wmf.11 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.11 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.37.0-wmf.10
Next: 1.37.0-wmf.12

Related Objects
Search...

Event Timeline

thcipriani created this task.Apr 26 2021, 3:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2021, 3:14 PM
thcipriani assigned this task to • dduvall.Jun 6 2021, 8:34 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jeena.
thcipriani added a project: Release-Engineering-Team (Doing).
Ladsgroup subscribed.Jun 9 2021, 2:20 AM

Risky Patch! 🚂🔥

jeena added a subtask: T284777: PHP Deprecated: Passing extra fields (quality) to LocalFile::loadFromRow was deprecated in MediaWiki 1.37. Property assignment will be removed in a later version. [Called from OldLocalFile::loadFromRow].Jun 10 2021, 7:19 PM
DannyS712 added subscribers: DannyS712, • Pchelolo.Jun 10 2021, 11:15 PM

Risky Patch! 🚂🔥

Reedy mentioned this in T271011: Update CategoryTree to use the new HookContainer/HookRunner system.Jun 11 2021, 2:00 AM
Reedy added a subtask: T271011: Update CategoryTree to use the new HookContainer/HookRunner system.Jun 11 2021, 2:02 AM
Krinkle subscribed.EditedJun 14 2021, 1:47 AM
Risky Patch! 🚂🔥

Our team intended to monitor this in Beta, however Logstash has been down for over two months, thus forcing us to take these risks directly in production T233134: logstash-beta.wmflabs.org does not receive any mediawiki events.

DannyS712 mentioned this in T247143: Remove the Revision class [1.37].Jun 15 2021, 10:25 AM
Krinkle added a subtask: T285118: beta: Error: Unsupported operand types.Jun 18 2021, 1:01 AM
AlexisJazz subscribed.Jun 18 2021, 6:57 AM

T285125

I don't know what version is running on beta cluster, but this may be a blocker.

Ladsgroup added a subtask: T285125: image sizes not displayed on beta.Jun 18 2021, 6:58 AM
AlexisJazz added a subtask: T285127: Unable to delete files on betacommons.Jun 18 2021, 7:28 AM
Zabe subscribed.Jun 18 2021, 8:26 AM
Ladsgroup mentioned this in T285125: image sizes not displayed on beta.Jun 18 2021, 3:13 PM
Zabe closed subtask T285127: Unable to delete files on betacommons as Resolved.Jun 18 2021, 3:58 PM
Zabe removed a subtask: T285125: image sizes not displayed on beta.Jun 18 2021, 4:12 PM
RhinosF1 subscribed.Jun 18 2021, 4:25 PM
In T281152#7162083, @AlexisJazz wrote:

T285125

I don't know what version is running on beta cluster, but this may be a blocker.

Beta cluster is latest master branch.

Michael subscribed.Jun 21 2021, 8:34 AM
Manuel subscribed.Jun 21 2021, 8:48 AM
• karapayneWMDE subscribed.Jun 21 2021, 8:54 AM
Ladsgroup closed subtask T284777: PHP Deprecated: Passing extra fields (quality) to LocalFile::loadFromRow was deprecated in MediaWiki 1.37. Property assignment will be removed in a later version. [Called from OldLocalFile::loadFromRow] as Resolved.Jun 21 2021, 9:59 AM
Stashbot added a comment.Jun 22 2021, 5:04 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-22T17:04:32Z] <dduvall> 1.37.0-wmf.11 was branched at rMWc161d3bd063b for T281152

• dduvall removed a subtask: T285118: beta: Error: Unsupported operand types.Jun 22 2021, 6:30 PM
Krinkle mentioned this in T285345: Python3 scap breaks mediawiki.Jun 22 2021, 7:01 PM
• dduvall removed a subtask: T271011: Update CategoryTree to use the new HookContainer/HookRunner system.Jun 22 2021, 7:01 PM
Stashbot added a comment.Jun 22 2021, 7:06 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-22T19:06:23Z] <dduvall> preparing to promote wmf.11 group0 (T281152) cc'ing risking patch contacts Amir1, Krinkle, DannyS712

ItamarWMDE subscribed.Jun 23 2021, 7:54 AM
Stashbot added a comment.Jun 23 2021, 7:20 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-23T19:20:25Z] <dduvall> preparing to promote wmf.11 group1 (T281152) cc'ing risky patch contacts Amir1, Krinkle, DannyS712

Stashbot added a comment.Jun 23 2021, 7:39 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-23T19:39:06Z] <dduvall> rolling back wmf.11 from group1 due to increase in logspam possibly related to noted risky patch https://gerrit.wikimedia.org/r/c/mediawiki/core/+/693298 (cc T281152 and patch contact Amir1)

• dduvall mentioned this in T285431: PHP Notice: Undefined index: frameCount.Jun 23 2021, 7:58 PM
• dduvall added a subtask: T285431: PHP Notice: Undefined index: frameCount.Jun 23 2021, 8:01 PM
Stashbot added a comment.Jun 23 2021, 11:10 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-23T23:10:43Z] <dduvall> re-rolling group1 to 1.37.0-wmf.11 (T281152) following deployment of blocker fixes

Stashbot added a comment.Jun 23 2021, 11:19 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-23T23:19:21Z] <dduvall> rolling back 1.37.0-wmf.11 from group1 (T281152) due to reoccurrence of "PHP Notice: Undefined index: frameCount" now at PNGHandler.php:156 (T285431)

DannyS712 added a comment.EditedJun 24 2021, 5:20 AM
In T281152#7154103, @Krinkle wrote:
Risky Patch! 🚂🔥

...

I just filed T285449: Master tests failing for CentralNotice, "RuntimeException: Config accessed before it is set" which is for CentralNotice tests failing due to the removal of the fallback - not sure if its just affecting the tests or would also affect usage of the extension

Stashbot added a comment.Jun 24 2021, 5:08 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-24T17:08:01Z] <dduvall> re-rolling group1 to 1.37.0-wmf.11 (T281152) following deployment of blocker fixes (cc risky patch contacts Amir1 Krinkle DannyS712)

• dduvall mentioned this in T285490: InvalidArgumentException: Media handler BmpHandler returned NULL for metadata, should be array.Jun 24 2021, 5:49 PM
Stashbot added a comment.Jun 24 2021, 7:04 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-24T19:04:16Z] <dduvall> preparing to roll group2 to 1.37.0-wmf.11 (T281152) (cc risky patch contacts Amir1 Krinkle DannyS712)

• dduvall closed this task as Resolved.Jun 24 2021, 8:40 PM
• dduvall closed subtask T285431: PHP Notice: Undefined index: frameCount as Resolved.
Joe reopened this task as Open.Jun 29 2021, 8:36 AM
Joe added a subtask: T285634: June 2021: appservers accumulating active php-fpm workers, requiring rolling restarts to avoid user-visible latency impact.
Joe subscribed.

Boldly reopening since we have a UBN! task that seems clearly related to this train release.

Joe closed subtask T285634: June 2021: appservers accumulating active php-fpm workers, requiring rolling restarts to avoid user-visible latency impact as Resolved.Jun 29 2021, 1:18 PM
Jdforrester-WMF closed this task as Resolved.Jun 29 2021, 1:47 PM
Jdforrester-WMF subscribed.

Re-closing; blocker appears fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL