Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Umherirrender | T335536 Hard deprecate class Hooks with all deprecated functions (and remove in 1.42) | |||
Open | None | T254670 [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system | |||
Open | None | T263353 Update all Wikimedia production extensions to use the new HookContainer/HookRunner system | |||
Open | None | T263364 Update all tarballed extensions to use the new HookContainer/HookRunner system | |||
Resolved | None | T271011 Update CategoryTree to use the new HookContainer/HookRunner system |
Event Timeline
Change 695238 had a related patch set uploaded (by Lens0021; author: Lens0021):
[mediawiki/extensions/CategoryTree@master] Convert most core hook handling to use a HookHandler
Change 695238 abandoned by Lens0021:
[mediawiki/extensions/CategoryTree@master] Convert most core hook handling to use a HookHandler
Reason:
A duplicate of Ie52c393af378a980a2dac4ae7076fd6c016a8e0e
Change 693563 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):
[mediawiki/extensions/CategoryTree@master] Convert to new hook system (Workshop)
Change 693563 merged by jenkins-bot:
[mediawiki/extensions/CategoryTree@master] Convert to new hook system (Workshop)
Fatal error: Uncaught Error: Call to a member function getVal() on null in /srv/mediawiki-staging/php-master/extensions/CategoryTree/includes/Hooks.php:124
seen at https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/51021/
Looks like $wgRequest may not be setup correctly by the time MediaWikiServicesHook runs? But was possibly fine when the same function was used as the extensionfunctions subscriber.
Mentioned in SAL (#wikimedia-releng) [2021-06-11T02:03:44Z] <Reedy> beta-update-databases-eqiad seemingly broken by CategoryTree fix for T271011. Comment left on gerrit patch and task, not reverting patch in master at this stage
Change 699388 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):
[mediawiki/extensions/CategoryTree@master] Re-apply: Convert to new hook system (Workshop)
Change 699388 merged by jenkins-bot:
[mediawiki/extensions/CategoryTree@master] Re-apply: Convert to new hook system (Workshop)
Mentioned in SAL (#wikimedia-operations) [2021-06-22T17:42:59Z] <dduvall> testwikis to 1.37.0-wmf.11 (cc open blockers T285125 T285118 T271011)
Upping priority since we're getting close to group0 deployment and this is still an open blocker.
It was reverted, then reapplied and that has been merged. It shouldn’t be a blocker anymore…