Page MenuHomePhabricator
Create Task
Maniphest T271011

Update CategoryTree to use the new HookContainer/HookRunner system
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Re-apply: Convert to new hook system (Workshop)mediawiki/extensions/CategoryTreemaster+106 -52
Convert to new hook system (Workshop)mediawiki/extensions/CategoryTreemaster+94 -38
Convert most core hook handling to use a HookHandlermediawiki/extensions/CategoryTreemaster+85 -52
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy renamed this task from Convert CategoryTree to use the new HookContainer/HookRunner system to Update CategoryTree to use the new HookContainer/HookRunner system.Jan 1 2021, 11:20 PM
Reedy created this task.
Reedy added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system.Jan 1 2021, 11:37 PM
gerritbot added a comment.May 26 2021, 11:10 AM

Change 695238 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/extensions/CategoryTree@master] Convert most core hook handling to use a HookHandler

https://gerrit.wikimedia.org/r/695238

gerritbot added a project: Patch-For-Review.May 26 2021, 11:10 AM
gerritbot added a comment.May 26 2021, 11:39 AM

Change 695238 abandoned by Lens0021:

[mediawiki/extensions/CategoryTree@master] Convert most core hook handling to use a HookHandler

Reason:

A duplicate of Ie52c393af378a980a2dac4ae7076fd6c016a8e0e

https://gerrit.wikimedia.org/r/695238

Maintenance_bot removed a project: Patch-For-Review.May 26 2021, 12:10 PM
gerritbot added a comment.Jun 2 2021, 2:23 PM

Change 693563 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/extensions/CategoryTree@master] Convert to new hook system (Workshop)

https://gerrit.wikimedia.org/r/693563

gerritbot added a project: Patch-For-Review.Jun 2 2021, 2:23 PM
gerritbot added a comment.Jun 11 2021, 12:58 AM

Change 693563 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Convert to new hook system (Workshop)

https://gerrit.wikimedia.org/r/693563

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 11 2021, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 11 2021, 1:10 AM
Reedy added a comment.EditedJun 11 2021, 1:58 AM
Fatal error: Uncaught Error: Call to a member function getVal() on null in /srv/mediawiki-staging/php-master/extensions/CategoryTree/includes/Hooks.php:124

seen at https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/51021/

Looks like $wgRequest may not be setup correctly by the time MediaWikiServicesHook runs? But was possibly fine when the same function was used as the extensionfunctions subscriber.

Reedy added a comment.Jun 11 2021, 2:00 AM

Ping T281152 as a potential train blocker

Reedy added a parent task: T281152: 1.37.0-wmf.11 deployment blockers.Jun 11 2021, 2:02 AM
Stashbot added a comment.Jun 11 2021, 2:03 AM

Mentioned in SAL (#wikimedia-releng) [2021-06-11T02:03:44Z] <Reedy> beta-update-databases-eqiad seemingly broken by CategoryTree fix for T271011. Comment left on gerrit patch and task, not reverting patch in master at this stage

gerritbot added a comment.Jun 11 2021, 9:24 AM

Change 699388 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/extensions/CategoryTree@master] Re-apply: Convert to new hook system (Workshop)

https://gerrit.wikimedia.org/r/699388

gerritbot added a project: Patch-For-Review.Jun 11 2021, 9:24 AM
daniel mentioned this in T137812: Add preferences ability to view categorytree with "all" mode..Jun 11 2021, 9:31 AM
gerritbot added a comment.Jun 15 2021, 1:50 AM

Change 699388 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Re-apply: Convert to new hook system (Workshop)

https://gerrit.wikimedia.org/r/699388

Stashbot added a comment.Jun 22 2021, 5:43 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-22T17:42:59Z] <dduvall> testwikis to 1.37.0-wmf.11 (cc open blockers T285125 T285118 T271011)

Stashbot mentioned this in T285125: image sizes not displayed on beta.Jun 22 2021, 5:43 PM
Stashbot mentioned this in T285118: beta: Error: Unsupported operand types.
• dduvall triaged this task as Unbreak Now! priority.Jun 22 2021, 6:01 PM
• dduvall subscribed.

Upping priority since we're getting close to group0 deployment and this is still an open blocker.

Reedy added a comment.Jun 22 2021, 6:31 PM

It was reverted, then reapplied and that has been merged. It shouldn’t be a blocker anymore…

• dduvall lowered the priority of this task from Unbreak Now! to Medium.Jun 22 2021, 7:01 PM
In T271011#7170483, @Reedy wrote:

It was reverted, then reapplied and that has been merged. It shouldn’t be a blocker anymore…

Got it. Thank you!

• dduvall removed a parent task: T281152: 1.37.0-wmf.11 deployment blockers.Jun 22 2021, 7:01 PM
Umherirrender closed this task as Resolved.Jan 12 2023, 11:48 PM
Umherirrender removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL