[EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	DannyS712
	Jun 6 2020, 9:16 PM

Description

Only available for extensions that already require MW 1.35+
See subtasks for individual extensions

Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md for documentation.

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Open	None	T254670 [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system
Resolved	• nnikkhoui	T254381 Update Example and BoilerPlate extensions for new hooks system
Open	None	T263353 Update all Wikimedia production extensions to use the new HookContainer/HookRunner system
Open	None	T263364 Update all tarballed extensions to use the new HookContainer/HookRunner system
Duplicate	None	T271042 Make HookRunnerTest accessible for extensions
Resolved	Daimona	T271620 Make HookRunnerTest usable in extension tests
Declined	None	T283474 Update StructuredDiscussions to use the new HookContainer/HookRunner system
Resolved	Umherirrender	T271018 Update LocalisationUpdate to use the new HookContainer/HookRunner system
Resolved	Yaron_Koren	T338453 Update AdminLinks to use the new HookContainer/HookRunner system
		· · ·

Event Timeline

DannyS712 created this task.Jun 6 2020, 9:16 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 6 2020, 9:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Jun 6 2020, 9:16 PM

DannyS712 added a project: Epic.

DannyS712 added subtasks: T254558: Update Nuke hook running to use HookContainer, T254313: Update FlaggedRevs hook running to use HookContainer, T254306: Update AbuseFilter hook running to use HookContainer.

https://lists.wikimedia.org/pipermail/wikitech-l/2020-May/093450.html

Using the new system in extensions
----------------------------------

Extensions should create their own HookRunner classes and use them to
call hooks. HookContainer::run() should be used instead of Hooks::run().

As for handling hooks, I think it's too early for a mass migration of
extensions to the new registration system as described in the RFC.[3]
Extension authors who are keen to pilot the new system can give it a
go. Make sure you add Nikki and me as reviewers.

More information about the new system can be found in docs/Hooks.md
[4]. The patch to add it should soon be merged.

In T254670#6199589, @Umherirrender wrote:

https://lists.wikimedia.org/pipermail/wikitech-l/2020-May/093450.html

Using the new system in extensions
----------------------------------

Extensions should create their own HookRunner classes and use them to
call hooks. HookContainer::run() should be used instead of Hooks::run().

As for handling hooks, I think it's too early for a mass migration of
extensions to the new registration system as described in the RFC.[3]
Extension authors who are keen to pilot the new system can give it a
go. Make sure you add Nikki and me as reviewers.

More information about the new system can be found in docs/Hooks.md
[4]. The patch to add it should soon be merged.

I understood that to be referring to the registration of extension's hook handlers, not the method by which extensions themselves call hooks

• Pchelolo moved this task from Inbox to Volunteer Needed Tasks on the Platform Engineering board.Jun 8 2020, 1:29 PM

• nnikkhoui added a subtask: T254381: Update Example and BoilerPlate extensions for new hooks system.Jun 10 2020, 3:30 PM

DannyS712 closed subtask T254313: Update FlaggedRevs hook running to use HookContainer as Resolved.Jun 24 2020, 10:17 PM

DannyS712 closed subtask T254558: Update Nuke hook running to use HookContainer as Resolved.Jul 3 2020, 3:20 AM

Daimona closed subtask T254306: Update AbuseFilter hook running to use HookContainer as Resolved.Sep 17 2020, 11:01 AM

• nnikkhoui closed subtask T254381: Update Example and BoilerPlate extensions for new hooks system as Resolved.Sep 18 2020, 2:46 PM

Jdforrester-WMF removed a subtask: T254558: Update Nuke hook running to use HookContainer.Sep 20 2020, 1:00 PM

Jdforrester-WMF removed a subtask: T254313: Update FlaggedRevs hook running to use HookContainer.

Jdforrester-WMF removed a subtask: T254306: Update AbuseFilter hook running to use HookContainer.

Mainframe98 mentioned this in T271042: Make HookRunnerTest accessible for extensions.Jan 2 2021, 10:28 AM

Umherirrender unsubscribed.Jan 2 2021, 11:12 AM