Page MenuHomePhabricator

Convert GetLinkColours hook to HookHandler system
Closed, ResolvedPublic

Description

This is an introductory task to get you familiar with contributing to Wikimedia projects. (More experienced developers, please leave this for new people!)

The task is to update the ProofreadPage extension to use the new HookHandlers system that was introduced in MediaWiki 1.35. Generally, this involves changing the hook's configuration in extension.json and the hook handler implementation in the \ProofreadPage\ProofreadPage or \ProofreadPage\ProofreadPageInit class. It may require services to be injected to the class, and other (minor) refactoring. If you have any questions, please ask below!

To complete this task:

  1. Go through everything on the "How to become a MediaWiki hacker" page.
  2. Get the source code (linked from the extension's page on mediawiki.org) from Gerrit/Git: https://www.mediawiki.org/wiki/Download_from_Git
  3. Assign this task to yourself.
  4. Create a patch and reference this task in the commit message: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines
  5. Upload the patch to Gerrit.
  6. Ensure that all continuous-integration tests pass successfully.

Your code will be reviewed and hopefully merged, and this task will be resolved.

Event Timeline

Change 850622 had a related patch set uploaded (by Parthiv; author: Parthiv):

[mediawiki/extensions/ProofreadPage@master] Change GetLinkColours to HookHandler system

https://gerrit.wikimedia.org/r/850622

Change 850624 had a related patch set uploaded (by Parthiv; author: Parthiv):

[mediawiki/extensions/ProofreadPage@master] Add GetLinkColours inherit in ProofreadPage

https://gerrit.wikimedia.org/r/850624

Change 850622 abandoned by Parthiv:

[mediawiki/extensions/ProofreadPage@master] Change GetLinkColours to HookHandler system

Reason:

Duplicate commit

https://gerrit.wikimedia.org/r/850622

Change 851112 had a related patch set uploaded (by Parthiv; author: Parthiv):

[mediawiki/extensions/ProofreadPage@master] Change GetLinkColours to HookHandler system

https://gerrit.wikimedia.org/r/851112

Change 851112 abandoned by Parthiv:

[mediawiki/extensions/ProofreadPage@master] Change GetLinkColours to HookHandler system

Reason:

Duplicate Commit

https://gerrit.wikimedia.org/r/851112

Change 850622 restored by Parthiv:

[mediawiki/extensions/ProofreadPage@master] Change GetLinkColours to HookHandler system

https://gerrit.wikimedia.org/r/850622

Change 850624 abandoned by Parthiv:

[mediawiki/extensions/ProofreadPage@master] Change GetLinkColours to HookHandler system

Reason:

Duplicate Commit

https://gerrit.wikimedia.org/r/850624

Change 850622 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Change GetLinkColours to HookHandler system

https://gerrit.wikimedia.org/r/850622