Page MenuHomePhabricator
Create Task
Maniphest T335536

Hard deprecate class Hooks with all deprecated functions (and remove in 1.42)
Closed, ResolvedPublic
Actions

Description

All functions of the class Hooks are deprecated or internal and should be hard-deprecated and removed.

Searches for the class:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace deprecated Hooks::runmediawiki/extensions/RegexBlockREL1_39+5 -3
Remove Hooks class, all contents deprecated in 1.35 or 1.41mediawiki/coremaster+10 -528
Replace deprecated Hooks::runmediawiki/extensions/BetaFeaturesREL1_40+7 -7
Replace deprecated Hooks::runmediawiki/extensions/MathREL1_40+12 -5
Replace deprecated Hooks::registermediawiki/extensions/InterwikiREL1_40+1 -2
Replace deprecated Hooks::runmediawiki/extensions/WSOAuthREL1_40+31 -10
Replace deprecated Hooks::runmediawiki/extensions/WSOAuthREL1_39+31 -10
Replace deprecated Hooks::runWithoutAbortmediawiki/extensions/CentralNoticewmf/1.41.0-wmf.10+5 -2
Hard-deprecate Hooks::isRegistered/getHandlers/run/runWithoutAbortmediawiki/coremaster+25 -5
Replace deprecated Hooks::runmediawiki/extensions/Favoritesmaster+4 -2
Replace deprecated Hooks::runmediawiki/extensions/RegexBlockmaster+5 -3
Replace deprecated Hooks::runmediawiki/extensions/TinyMCEmaster+2 -2
Remove comment out code about deprecated Hooks::runmediawiki/extensions/WikEdDiffmaster+2 -29
Replace deprecated Hooks::runmediawiki/extensions/SemanticPageSeriesmaster+3 -2
Replace deprecated Hooks::runmediawiki/extensions/OAuthAuthenticationmaster+3 -3
Replace deprecated Hooks::runmediawiki/extensions/OpenIDmaster+3 -3
Replace deprecated Hooks::runmediawiki/extensions/NetworkAuthmaster+2 -2
Replace internal Hooks::runnermediawiki/coremaster+321 -192
Replace deprecated Hooks::runmediawiki/extensions/NSFileRepomaster+5 -4
Replace deprecated Hooks::runmediawiki/extensions/NSFileRepoREL1_39+5 -4
Replace deprecated Hooks::runmediawiki/extensions/Echomaster+2 -3
Replace deprecated Hooks::runmediawiki/extensions/Mathmaster+12 -5
Replace deprecated Hooks::registermediawiki/extensions/Interwikimaster+1 -2
Replace deprecated Hooks::runmediawiki/extensions/Quizmaster+3 -3
Replace deprecated Hooks::runmediawiki/extensions/TemplateStylesmaster+3 -3
Replace deprecated Hooks::runmediawiki/extensions/GlobalUserPagemaster+1 -2
Replace deprecated Hooks::runmediawiki/extensions/Translatemaster+2 -2
Replace deprecated Hooks::runmediawiki/extensions/Scribuntomaster+5 -3
Replace deprecated Hooks::runmediawiki/extensions/BetaFeaturesmaster+7 -7
Replace deprecated Hooks::runmediawiki/extensions/PhpTagsmaster+2 -2
Removed unused Hooks class importmediawiki/extensions/WikimediaEventsmaster+0 -1
Replace deprecated Hooks::runmediawiki/skins/MinervaNeuemaster+1 -2
tests/mocks: Replace deprecated Hooks::getHandlersmediawiki/coremaster+6 -2
Use HookContainer in WebRequestmediawiki/coremaster+8 -5
Replace deprecated Hooks::runmediawiki/extensions/Echomaster+25 -20
Replace deprecated Hooks::runmediawiki/extensions/ORESmaster+5 -5
Replace deprecated Hooks::runmediawiki/extensions/Flowmaster+4 -6
Replace deprecated Hooks::runWithoutAbortmediawiki/extensions/CentralNoticemaster+5 -2
Replace deprecated Hooks::runmediawiki/extensions/EmailAuthmaster+4 -4
Replace deprecated Hooks::register and Hooks::runmediawiki/extensions/PageFormsmaster+37 -29
Replace deprecated Hooks::runmediawiki/extensions/FeaturedFeedsmaster+1 -2
Replace deprecated Hooks::runmediawiki/extensions/MathSearchmaster+2 -2
Replace deprecated Hooks::registermediawiki/extensions/BlueSpicePageVersionmaster+8 -4
Replace deprecated Hooks::runmediawiki/extensions/NewUserNotifmaster+4 -2
Replace deprecated Hooks::runmediawiki/extensions/SemanticInternalObjectsmaster+3 -2
Replace deprecated Hooks::register and Hooks::runmediawiki/extensions/Auth_remoteusermaster+15 -14
Remove dead code with deprecated Hooks::runmediawiki/skins/HasSomeColoursmaster+0 -22
Replace deprecated Hooks::runmediawiki/extensions/SocialProfilemaster+15 -15
Replace deprecated Hooks::run and internal Hooks::runnermediawiki/extensions/PagePropertiesmaster+7 -7
Replace deprecated Hooks::runmediawiki/extensions/PhpTagsStoragemaster+1 -1
Replace deprecated Hooks::runmediawiki/extensions/PhpTagsFunctionsmaster+2 -2
Replace deprecated Hooks::runmediawiki/extensions/PhpTagsWidgetsmaster+3 -3
Replace deprecated Hooks::runmediawiki/extensions/Formmaster+2 -2
Replace deprecated Hooks::runmediawiki/extensions/GoogleSiteSearchmaster+4 -2
Replace deprecated Hooks::runmediawiki/extensions/ImageComparemaster+4 -2
Replace deprecated Hooks::runmediawiki/extensions/Farmermaster+5 -4
Replace deprecated Hooks::runmediawiki/extensions/OpenGraphMetamaster+2 -2
Replace deprecated Hooks::runmediawiki/extensions/PageSchemasmaster+4 -2
Replace deprecated Hooks::runmediawiki/extensions/RandomGameUnitmaster+2 -2
Replace deprecated Hooks::runmediawiki/extensions/SocialLoginmaster+5 -5
Replace deprecated Hooks::runmediawiki/extensions/SphinxSearchmaster+4 -3
Replace deprecated Hooks::runmediawiki/extensions/ContentTransfermaster+5 -5
Replace deprecated Hooks::runmediawiki/extensions/MarkAsHelpfulmaster+7 -3
Replace deprecated Hooks::runmediawiki/extensions/SiteSettingsmaster+36 -27
Replace deprecated Hooks::runmediawiki/extensions/WSOAuthmaster+31 -10
Replace deprecated Hooks::runmediawiki/skins/DeskMessMirroredmaster+3 -1
Replace deprecated Hooks::runmediawiki/skins/Bouquetmaster+1 -1
Replace deprecated Hooks::runmediawiki/skins/apexmaster+1 -1
Replace deprecated Hooks::runmediawiki/skins/Duskmaster+4 -2
Replace deprecated Hooks::runmediawiki/skins/DuskToDawnmaster+1 -1
Replace deprecated Hooks::runmediawiki/skins/eruditemaster+3 -1
Replace deprecated Hooks::runmediawiki/skins/Gamepressmaster+3 -1
Replace deprecated Hooks::runmediawiki/skins/Foregroundmaster+3 -1
Replace deprecated Hooks::runmediawiki/skins/Metrolookmaster+6 -4
Replace deprecated Hooks::runmediawiki/skins/Nimbusmaster+1 -1
Replace deprecated Hooks::runmediawiki/skins/p2wikimaster+3 -1
Replace deprecated Hooks::runmediawiki/skins/Pivotmaster+3 -1
Replace deprecated Hooks::runmediawiki/skins/Truglassmaster+4 -2
Replace deprecated Hooks::runmediawiki/skins/Refreshedmaster+2 -2
Remove comment out code about deprecated Hooks::runmediawiki/skins/webplatformmaster+0 -3
Replace deprecated Hooks::run in READMEmediawiki/extensions/EmailDiffmaster+2 -2
Remove comment out code about deprecated Hooks::runmediawiki/extensions/FanBoxesmaster+0 -1
Replace deprecated Hooks::runmediawiki/extensions/UserMergemaster+6 -4
Replace deprecated Hooks::runmediawiki/extensions/PhpTagsWikimaster+1 -1
Replace deprecated Hooks::runmediawiki/extensions/AdminLinksmaster+1 -1
Replace deprecated Hooks::runmediawiki/extensions/BatchUserRightsmaster+3 -2
Replace deprecated Hooks::runmediawiki/extensions/ConfirmAccountmaster+1 -1
Replace deprecated Hooks::runmediawiki/extensions/ApprovedRevsmaster+12 -6
Replace deprecated Hooks::runmediawiki/extensions/Mpdfmaster+3 -1
Replace deprecated Hooks::runmediawiki/extensions/MultiLanguageManagermaster+4 -6
Replace deprecated Hooks::runmediawiki/extensions/Formsmaster+2 -1
Replace deprecated Hooks::runmediawiki/extensions/PhpTagsmaster+4 -2
Replace deprecated Hooks::runmediawiki/extensions/SearchParserFunctionmaster+5 -3
Replace deprecated Hooks::runmediawiki/extensions/SharedHelpPagesmaster+1 -1
Replace deprecated Hooks::runmediawiki/extensions/StaffPowersmaster+1 -1
Replace deprecated Hooks::runmediawiki/extensions/UserGroupsmaster+4 -2
Replace deprecated Hooks::runmediawiki/extensions/TwnMainPagemaster+1 -1
Replace deprecated Hooks::runmediawiki/extensions/WatchAnalyticsmaster+2 -2
Replace deprecated Hooks::runmediawiki/extensions/VEForAllmaster+2 -2
Replace deprecated Hooks::runmediawiki/extensions/WikiForummaster+1 -1
Replace deprecated Hooks::runmediawiki/extensions/Commentsmaster+4 -3
Replace deprecated Hooks::runmediawiki/extensions/GlobalContribsmaster+4 -4
Replace deprecated Hooks::runmediawiki/extensions/Pushmaster+8 -4
Replace deprecated Hooks::runmediawiki/extensions/Cargomaster+7 -5
Replace deprecated Hooks::runmediawiki/extensions/LiveChatmaster+6 -6
Replace deprecated Hooks::runmediawiki/extensions/BibManagermaster+13 -9
Replace deprecated Hooks::runmediawiki/extensions/Translatemaster+19 -17
Replace deprecated Hooks::runmediawiki/extensions/TorBlockmaster+13 -3
Replace deprecated Hooks::runmediawiki/extensions/XAnalyticsmaster+2 -2
Replace deprecated Hooks::runmediawiki/extensions/LoginNotifymaster+4 -3
Replace deprecated Hooks::runmediawiki/extensions/LiquidThreadsmaster+61 -48
Replace deprecated Hooks::runmediawiki/extensions/Mathmaster+3 -4
Replace deprecated Hooks::runmediawiki/extensions/ContactPagemaster+5 -5
Replace deprecated Hooks::runmediawiki/extensions/WikimediaEventsmaster+1 -1
Replace deprecated Hooks::runmediawiki/extensions/FileImportermaster+7 -6
Replace deprecated Hooks::runmediawiki/extensions/CodeEditormaster+13 -5
Replace deprecated Hooks::runmediawiki/extensions/GrowthExperimentsmaster+1 -2
Use HookContainer in MediawikiEditFilterHookRunnermediawiki/extensions/Wikibasemaster+19 -6
Replace deprecated Hooks::runmediawiki/extensions/Wikibasemaster+109 -31
Replace deprecated Hooks::runmediawiki/extensions/WikibaseMediaInfomaster+5 -4
tests: No hook clean up needed on tearDown in WatchActionTestmediawiki/coremaster+0 -11
Replace deprecated Hooks::runmediawiki/extensions/LdapAuthenticationmaster+10 -7
tests: Replace deprecated Hooks::runmediawiki/extensions/BetaFeaturesmaster+6 -6
tests: Replace deprecated Hooks::runmediawiki/extensions/IPInfomaster+1 -2
SendBulkEmails: Replace deprecated Hooks::registermediawiki/extensions/WikimediaMaintenancemaster+1 -1
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.May 6 2023, 8:53 PM

Change 916799 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/skins/MinervaNeue@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916799

gerritbot added a comment.May 6 2023, 8:58 PM

Change 916800 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BetaFeatures@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916800

gerritbot added a comment.May 6 2023, 9:03 PM

Change 916801 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalUserPage@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916801

gerritbot added a comment.May 6 2023, 9:05 PM

Change 916802 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Interwiki@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916802

gerritbot added a comment.May 6 2023, 9:05 PM

Change 916803 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PhpTags@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916803

gerritbot added a comment.May 6 2023, 9:06 PM

Change 916804 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Scribunto@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916804

gerritbot added a comment.May 6 2023, 9:07 PM

Change 916805 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TemplateStyles@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916805

gerritbot added a comment.May 6 2023, 9:08 PM

Change 916806 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Quiz@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916806

gerritbot added a comment.May 6 2023, 9:10 PM

Change 916807 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916807

gerritbot added a comment.May 6 2023, 9:11 PM

Change 916808 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Math@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916808

gerritbot added a comment.May 6 2023, 9:16 PM

Change 916799 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916799

gerritbot added a comment.May 6 2023, 9:21 PM

Change 916809 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikimediaEvents@master] Removed unused Hooks class import

https://gerrit.wikimedia.org/r/916809

gerritbot added a comment.May 6 2023, 9:23 PM

Change 916810 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate Hooks::isRegistered/getHandlers/run/runner

https://gerrit.wikimedia.org/r/916810

Umherirrender updated the task description. (Show Details)May 6 2023, 9:30 PM
Umherirrender added a comment.May 6 2023, 10:10 PM

https://github.com/SemanticMediaWiki/SemanticApprovedRevs/issues/32
https://github.com/SemanticMediaWiki/SemanticBreadcrumbLinks/issues/76
https://github.com/SemanticMediaWiki/SemanticCite/issues/114
https://github.com/SemanticMediaWiki/SemanticExternalQueryLookup/issues/39
https://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/issues/214
https://github.com/SemanticMediaWiki/SemanticGlossary/issues/72
https://github.com/SemanticMediaWiki/SemanticInterlanguageLinks/issues/99
https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/5481
https://github.com/SemanticMediaWiki/SemanticMetaTags/issues/75
https://github.com/SemanticMediaWiki/SemanticNotifications/issues/33
https://github.com/SemanticMediaWiki/SemanticScribunto/issues/91
https://github.com/SemanticMediaWiki/SemanticWatchlist/issues/101
https://github.com/SemanticMediaWiki/SummaryCards/issues/18
https://github.com/SemanticMediaWiki/WhatsNearby/issues/25

gerritbot added a comment.May 7 2023, 12:13 AM

Change 916800 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916800

gerritbot added a comment.May 7 2023, 12:13 AM

Change 916809 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Removed unused Hooks class import

https://gerrit.wikimedia.org/r/916809

gerritbot added a comment.May 7 2023, 12:16 AM

Change 916807 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916807

gerritbot added a comment.May 7 2023, 12:16 AM

Change 916804 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916804

gerritbot added a comment.May 7 2023, 12:16 AM

Change 916805 merged by jenkins-bot:

[mediawiki/extensions/TemplateStyles@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916805

gerritbot added a comment.May 7 2023, 12:16 AM

Change 916803 merged by jenkins-bot:

[mediawiki/extensions/PhpTags@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916803

gerritbot added a comment.May 7 2023, 12:16 AM

Change 916801 merged by jenkins-bot:

[mediawiki/extensions/GlobalUserPage@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916801

gerritbot added a comment.May 7 2023, 12:37 AM

Change 916806 merged by jenkins-bot:

[mediawiki/extensions/Quiz@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916806

gerritbot added a comment.May 7 2023, 12:53 AM

Change 916802 merged by jenkins-bot:

[mediawiki/extensions/Interwiki@master] Replace deprecated Hooks::register

https://gerrit.wikimedia.org/r/916802

gerritbot added a comment.May 7 2023, 12:53 AM

Change 916808 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916808

gerritbot added a comment.May 7 2023, 1:01 AM

Change 916822 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Echo@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916822

gerritbot added a comment.May 7 2023, 8:31 AM

Change 916822 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916822

gerritbot added a comment.May 9 2023, 6:38 AM

Change 916747 merged by Robert Vogel:

[mediawiki/extensions/NSFileRepo@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916747

gerritbot added a comment.May 9 2023, 6:40 AM

Change 917726 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/NSFileRepo@REL1_39] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/917726

gerritbot added a comment.May 9 2023, 6:40 AM

Change 917726 merged by Robert Vogel:

[mediawiki/extensions/NSFileRepo@REL1_39] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/917726

gerritbot added a comment.May 11 2023, 6:34 AM

Change 916796 merged by jenkins-bot:

[mediawiki/core@master] Replace internal Hooks::runner

https://gerrit.wikimedia.org/r/916796

gerritbot added a comment.May 13 2023, 6:53 AM

Change 916745 merged by Umherirrender:

[mediawiki/extensions/NetworkAuth@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916745

gerritbot added a comment.May 13 2023, 6:53 AM

Change 916750 merged by Umherirrender:

[mediawiki/extensions/OpenID@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916750

gerritbot added a comment.May 13 2023, 6:53 AM

Change 916751 merged by Umherirrender:

[mediawiki/extensions/OAuthAuthentication@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916751

gerritbot added a comment.May 13 2023, 6:53 AM

Change 916760 merged by Umherirrender:

[mediawiki/extensions/SemanticPageSeries@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916760

gerritbot added a comment.May 13 2023, 6:53 AM

Change 916772 merged by Umherirrender:

[mediawiki/extensions/WikEdDiff@master] Remove comment out code about deprecated Hooks::run

https://gerrit.wikimedia.org/r/916772

gerritbot added a comment.May 13 2023, 6:54 AM

Change 916765 merged by Umherirrender:

[mediawiki/extensions/TinyMCE@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916765

gerritbot added a comment.May 13 2023, 6:55 AM

Change 916756 merged by Umherirrender:

[mediawiki/extensions/RegexBlock@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916756

gerritbot added a comment.May 13 2023, 8:02 AM

Change 916776 merged by Umherirrender:

[mediawiki/extensions/Favorites@master] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/916776

Umherirrender mentioned this in rENAU4e28aaba5330: Replace deprecated Hooks::run.May 13 2023, 9:02 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 12:02 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.10; 2023-05-23); removed MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 3:01 AM
Umherirrender mentioned this in T336967: Replace deprecated Hooks::runWithoutAbort in CentralNotice wmf production code.May 18 2023, 7:22 PM
Umherirrender added a subtask: T336967: Replace deprecated Hooks::runWithoutAbort in CentralNotice wmf production code.
gerritbot added a comment.May 19 2023, 3:14 PM

Change 916810 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate Hooks::isRegistered/getHandlers/run/runWithoutAbort

https://gerrit.wikimedia.org/r/916810

Umherirrender renamed this task from Hard deprecate class Hooks with all deprecated functions (and remove class a release later) to Hard deprecate class Hooks with all deprecated functions (and remove in 1.42).May 19 2023, 3:16 PM
Umherirrender changed the task status from Open to Stalled.
Umherirrender removed a project: Patch-For-Review.
Umherirrender closed subtask T336967: Replace deprecated Hooks::runWithoutAbort in CentralNotice wmf production code as Resolved.May 25 2023, 7:12 PM
gerritbot added a comment.May 25 2023, 9:56 PM

Change 923283 had a related patch set uploaded (by Zabe; author: Umherirrender):

[mediawiki/extensions/CentralNotice@wmf/1.41.0-wmf.10] Replace deprecated Hooks::runWithoutAbort

https://gerrit.wikimedia.org/r/923283

gerritbot added a project: Patch-For-Review.May 25 2023, 9:56 PM
gerritbot added a comment.May 25 2023, 10:04 PM

Change 923283 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf/1.41.0-wmf.10] Replace deprecated Hooks::runWithoutAbort

https://gerrit.wikimedia.org/r/923283

Stashbot mentioned this in T337427: LanguageConverter: Call to member function replace() on null.May 25 2023, 10:05 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-25T22:05:28Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:923283|Replace deprecated Hooks::runWithoutAbort (T335536)]], [[gerrit:923276|BannerRenderer: Make sure the language variant is valid (T337427)]]

Stashbot added a comment.May 25 2023, 10:07 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-25T22:06:59Z] <zabe@deploy1002> zabe and ladsgroup: Backport for [[gerrit:923283|Replace deprecated Hooks::runWithoutAbort (T335536)]], [[gerrit:923276|BannerRenderer: Make sure the language variant is valid (T337427)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Stashbot added a comment.May 25 2023, 10:14 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-25T22:14:42Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:923283|Replace deprecated Hooks::runWithoutAbort (T335536)]], [[gerrit:923276|BannerRenderer: Make sure the language variant is valid (T337427)]] (duration: 09m 14s)

gerritbot added a comment.Jun 4 2023, 2:58 PM

Change 926788 had a related patch set uploaded (by Cicalese; author: Umherirrender):

[mediawiki/extensions/WSOAuth@REL1_39] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/926788

gerritbot added a comment.Jun 4 2023, 3:01 PM

Change 926788 merged by Cicalese:

[mediawiki/extensions/WSOAuth@REL1_39] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/926788

• CCicalese_WMF mentioned this in rEWAU21f6497361bf: Replace deprecated Hooks::run.Jun 4 2023, 3:01 PM
gerritbot added a comment.Jun 4 2023, 3:13 PM

Change 926794 had a related patch set uploaded (by Cicalese; author: Umherirrender):

[mediawiki/extensions/WSOAuth@REL1_40] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/926794

gerritbot added a comment.Jun 4 2023, 3:15 PM

Change 926794 merged by Cicalese:

[mediawiki/extensions/WSOAuth@REL1_40] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/926794

• CCicalese_WMF mentioned this in rEWAU842be67f1d64: Replace deprecated Hooks::run.Jun 4 2023, 3:15 PM
Aklapper merged a task: T218313: Develop deprecation and migration plan for hook interfaces.Aug 14 2023, 11:30 AM
Aklapper added a project: Core Platform Team Initiatives (New Hook System).
Aklapper added a subtask: T254670: [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system.
Aklapper added a subscriber: • CCicalese_WMF.
gerritbot added a comment.Aug 14 2023, 4:13 PM

Change 948587 had a related patch set uploaded (by Paladox; author: Umherirrender):

[mediawiki/extensions/Interwiki@REL1_40] Replace deprecated Hooks::register

https://gerrit.wikimedia.org/r/948587

gerritbot added a comment.Aug 14 2023, 5:25 PM

Change 948587 merged by jenkins-bot:

[mediawiki/extensions/Interwiki@REL1_40] Replace deprecated Hooks::register

https://gerrit.wikimedia.org/r/948587

Ladsgroup added a project: MW-1.41-release.Aug 19 2023, 9:05 AM
Ladsgroup subscribed.

Let's make it a blocker so we can remove it soon

Tacsipacsi added a comment.Aug 20 2023, 10:05 AM

The title says “remove in 1.42”, why did you add MW-1.41-release rather than MW-1.42-release?

Ladsgroup added a comment.EditedAug 21 2023, 12:15 PM

It needs to be hard-deprecated before the 1.41 release and then we can start removing anything in 1.42

Tacsipacsi added a comment.Aug 21 2023, 12:17 PM

I see. Maybe it could be mentioned in the task description that it should be hard-deprecated in 1.41?

Umherirrender removed a project: Patch-For-Review.Aug 21 2023, 6:40 PM

All (static) functions of the class are hard-deprecated, this task is stalled until release of 1.42 to remove the class.

Ladsgroup added a comment.Aug 22 2023, 3:22 AM

wow thanks. Last I checked it wasn't done. Thanks!

gerritbot added a comment.Aug 25 2023, 10:06 PM

Change 952439 had a related patch set uploaded (by Paladox; author: Umherirrender):

[mediawiki/extensions/Math@REL1_40] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/952439

gerritbot added a project: Patch-For-Review.Aug 25 2023, 10:06 PM
Reedy moved this task from Blocker to To deprecate or remove on the MW-1.41-release board.Aug 26 2023, 6:32 PM
Krinkle edited projects, added MediaWiki-General; removed Core Platform Team Initiatives (New Hook System), MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), MediaWiki-Core-Hooks.Aug 28 2023, 3:00 PM
gerritbot added a comment.Sep 5 2023, 9:33 PM

Change 952439 merged by Umherirrender:

[mediawiki/extensions/Math@REL1_40] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/952439

Jdforrester-WMF edited projects, added MW-1.42-release; removed MW-1.41-release.Sep 21 2023, 6:47 PM
Jdforrester-WMF moved this task from Blocker to Deprecate or remove on the MW-1.42-release board.
gerritbot added a comment.Oct 12 2023, 7:57 PM

Change 965587 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Remove Hooks class

https://gerrit.wikimedia.org/r/965587

Umherirrender changed the task status from Stalled to Open.Oct 12 2023, 7:58 PM
Umherirrender claimed this task.
gerritbot added a comment.Oct 22 2023, 11:18 AM

Change 967492 had a related patch set uploaded (by Paladox; author: Umherirrender):

[mediawiki/extensions/BetaFeatures@REL1_40] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/967492

gerritbot added a comment.Oct 22 2023, 1:43 PM

Change 967492 abandoned by Paladox:

[mediawiki/extensions/BetaFeatures@REL1_40] Replace deprecated Hooks::run

Reason:

https://gerrit.wikimedia.org/r/967492

gerritbot added a comment.Nov 30 2023, 10:33 PM

Change 965587 merged by jenkins-bot:

[mediawiki/core@master] Remove Hooks class, all contents deprecated in 1.35 or 1.41

https://gerrit.wikimedia.org/r/965587

Umherirrender closed this task as Resolved.Nov 30 2023, 10:34 PM
Umherirrender removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Nov 30 2023, 11:00 PM
karapayneWMDE mentioned this in T381172: [EPIC] Update all WMDE Wikibase topics to use the new HookContainer/HookRunner system.Dec 2 2024, 11:11 AM
gerritbot added a comment.Jun 18 2025, 6:25 PM

Change #1160974 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/extensions/RegexBlock@REL1_39] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/1160974

gerritbot added a project: Patch-For-Review.Jun 18 2025, 6:25 PM
gerritbot added a comment.Jun 18 2025, 9:40 PM

Change #1160974 merged by Umherirrender:

[mediawiki/extensions/RegexBlock@REL1_39] Replace deprecated Hooks::run

https://gerrit.wikimedia.org/r/1160974

Izno removed a subtask: T254670: [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system.Oct 25 2025, 4:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits