Page MenuHomePhabricator
Create Task
Maniphest T321882

Reduce number of files directly under includes/
Open, Needs TriagePublic
Actions

Description

Currently there is around 90 files directly under includes/ and range from TemplateParser to DummyLinker to BadFileLookup. This doesn't make a great developer experience and can be overwhelming to people who are new to mediawiki.

See the parent ticket for the suggested moves.

  • includes/ActorMigration.php
  • includes/ActorMigrationBase.php
  • includes/AutoLoader.php Core wiring
  • includes/BadFileLookup.php
  • includes/BootstrapHelperFunctions.php Core wiring
  • includes/CategoriesRdf.php
  • includes/Category.php
  • includes/CategoryViewer.php
  • includes/CommentStore.php
  • includes/CommentStoreComment.php
  • includes/ConfiguredReadOnlyMode.php
  • includes/ContentSecurityPolicy.php
  • includes/DefaultSettings.php Core wiring
  • includes/Defines.php Core wiring
  • includes/DeprecatedGlobal.php
  • includes/DerivativeRequest.php
  • includes/DevelopmentSettings.php Core wiring
  • includes/DummyLinker.php
  • includes/EditPage.php
  • includes/Emptiable.php
  • includes/EventRelayerGroup.php
  • includes/ExtensionInfo.php
  • includes/FauxRequest.php
  • includes/FauxRequestUpload.php
  • includes/FauxResponse.php
  • includes/FileDeleteForm.php
  • includes/ForeignResourceManager.php
  • includes/FormOptions.php
  • includes/GitInfo.php
  • includes/GlobalFunctions.php Core wiring
  • includes/HeaderCallback.php
  • includes/Hooks.php
  • includes/Html.php
  • includes/HtmlHelper.php
  • includes/LinkFilter.php
  • includes/Linker.php
  • includes/ListToggle.php
  • includes/MWTimestamp.php
  • includes/MagicWord.php
  • includes/MagicWordArray.php
  • includes/MagicWordFactory.php
  • includes/MainConfigNames.php Core wiring
  • includes/MainConfigSchema.php Core wiring
  • includes/MediaWiki.php Core wiring
  • includes/MediaWikiServices.php Core wiring
  • includes/MediaWikiVersionFetcher.php
  • includes/MergeHistory.php
  • includes/MovePage.php
  • includes/NoLocalSettings.php
  • includes/OutputHandler.php
  • includes/OutputPage.php
  • includes/PHPVersionCheck.php Core wiring
  • includes/PageProps.php
  • includes/PathRouter.php
  • includes/Pingback.php
  • includes/PlatformSettings.php Core wiring
  • includes/ProtectionForm.php
  • includes/ProxyLookup.php
  • includes/RawMessage.php
  • includes/ReadOnlyMode.php
  • includes/ServiceWiring.php Core wiring
  • includes/Setup.php Core wiring
  • includes/SetupDynamicConfig.php
  • includes/SiteConfiguration.php
  • includes/SiteStats.php
  • includes/SiteStatsInit.php
  • includes/Status.php
  • includes/StreamFile.php
  • includes/StubGlobalUser.php
  • includes/StubObject.php
  • includes/StubUserLang.php
  • includes/TemplateParser.php
  • includes/TemplatesOnThisPageFormatter.php
  • includes/Title.php
  • includes/TitleArray.php
  • includes/TitleArrayFromResult.php
  • includes/TitleFactory.php
  • includes/TrackingCategories.php
  • includes/WebRequest.php
  • includes/WebRequestUpload.php
  • includes/WebResponse.php
  • includes/WebStart.php Core wiring
  • includes/WikiMap.php
  • includes/WikiReference.php
  • includes/config-merge-strategies.php
  • includes/config-schema.php Core wiring
  • includes/config-vars.php

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+20 -2Reorg: Move LinkFilter to ExternalLinks
mediawiki/coremaster+34 -11Reorg: Move WebResponse and FauxResponse to Request/
mediawiki/coremaster+90 -15Reorg: Migrate WikiMap to WikiMap/ out of includes
mediawiki/coremaster+117 -37Reorg: Move five page-related classes to page/ out of includes/
mediawiki/coremaster+331 -74Reorg: Move HTML-related classes out of includes/ to Html/
mediawiki/coremaster+31 -7Reorg: Move CSP class to Request/
mediawiki/coremaster+89 -25Reorg: Move EditPage.php to MediaWiki\EditPage
mediawiki/coremaster+79 -11Reorg: Move category-related classes from includes/ to Category/
mediawiki/coremaster+26 -10Reorg: Move TemplateParser to parser/
mediawiki/coremaster+72 -38Reorg: Move ActorMigration and ActorMigrationBase to user/
mediawiki/coremaster+57 -10Reorg: Move RawMessage to under language/
mediawiki/coremaster+61 -15Reorg: Move MagicWord related files to under parser/
mediawiki/coremaster+15 -3Reorg: Move PageProps to page/ and namespace it to MediaWiki\Page\
mediawiki/coremaster+121 -13Reorg: Move DummyLinker and Linker to linker/
mediawiki/coremaster+87 -30Reorg: Move Title-related classes to title/
mediawiki/coremaster+2 -1title: Move Title.php to includes/title/ where related classes are
mediawiki/coremaster+18 -6Reorg: Move ForeignResourceManager to ResourceLoader directory
mediawiki/coremaster+13 -10Reorg: Move HeaderCallback to Request directory
mediawiki/coremaster+252 -123Reorg: Move some of request related classes to MediaWiki/Request
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

• Ladsgroup created this task.Oct 28 2022, 10:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2022, 10:14 AM
• Ladsgroup mentioned this in T166010: The Great Namespaceization and Reorg.Oct 28 2022, 10:14 AM
gerritbot added a comment.Oct 28 2022, 10:15 AM

Change 850424 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move some of request related classes to MediaWiki/Request

https://gerrit.wikimedia.org/r/850424

gerritbot added a project: Patch-For-Review.Oct 28 2022, 10:15 AM
gerritbot added a comment.Oct 31 2022, 11:10 PM

Change 850424 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move some of request related classes to MediaWiki/Request

https://gerrit.wikimedia.org/r/850424

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2022, 11:30 PM
gerritbot added a comment.Nov 2 2022, 5:23 PM

Change 852249 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move HeaderCallback to Request directory

https://gerrit.wikimedia.org/r/852249

gerritbot added a project: Patch-For-Review.Nov 2 2022, 5:23 PM
gerritbot added a comment.Nov 2 2022, 5:29 PM

Change 852250 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move ForeignResourceManager to ResourceLoader directory

https://gerrit.wikimedia.org/r/852250

gerritbot added a comment.Nov 8 2022, 10:55 AM

Change 852249 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move HeaderCallback to Request directory

https://gerrit.wikimedia.org/r/852249

gerritbot added a comment.Nov 8 2022, 10:57 AM

Change 852250 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move ForeignResourceManager to ResourceLoader directory

https://gerrit.wikimedia.org/r/852250

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 8 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 8 2022, 11:30 AM
gerritbot added a comment.Nov 8 2022, 11:44 PM

Change 842538 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] title: Move Title.php to includes/title/ where related classes are

https://gerrit.wikimedia.org/r/842538

gerritbot added a project: Patch-For-Review.Nov 8 2022, 11:44 PM
gerritbot added a comment.Nov 9 2022, 2:24 AM

Change 842538 merged by jenkins-bot:

[mediawiki/core@master] title: Move Title.php to includes/title/ where related classes are

https://gerrit.wikimedia.org/r/842538

Maintenance_bot removed a project: Patch-For-Review.Nov 9 2022, 2:30 AM
gerritbot added a comment.Nov 10 2022, 6:40 PM

Change 855681 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move Title-related classes to Title/

https://gerrit.wikimedia.org/r/855681

gerritbot added a project: Patch-For-Review.Nov 10 2022, 6:40 PM
gerritbot added a comment.Nov 10 2022, 6:47 PM

Change 855685 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move DummyLinker to linker/

https://gerrit.wikimedia.org/r/855685

gerritbot added a comment.Nov 26 2022, 9:47 AM

Change 855681 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move Title-related classes to title/

https://gerrit.wikimedia.org/r/855681

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.12; 2022-11-28); removed MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 26 2022, 10:01 AM
gerritbot added a comment.Dec 8 2022, 6:10 PM

Change 855685 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move DummyLinker and Linker to linker/

https://gerrit.wikimedia.org/r/855685

Maintenance_bot removed a project: Patch-For-Review.Dec 8 2022, 6:29 PM
gerritbot added a comment.Dec 9 2022, 12:19 PM

Change 866578 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move PageProps to page/ and namespace it to MediaWiki\Page\

https://gerrit.wikimedia.org/r/866578

gerritbot added a project: Patch-For-Review.Dec 9 2022, 12:19 PM
gerritbot added a comment.Dec 9 2022, 12:29 PM

Change 866580 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move MagicWord related files to under parser/

https://gerrit.wikimedia.org/r/866580

gerritbot added a comment.Dec 11 2022, 3:50 PM

Change 866578 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move PageProps to page/ and namespace it to MediaWiki\Page\

https://gerrit.wikimedia.org/r/866578

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.14; 2022-12-12); removed MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Dec 11 2022, 4:01 PM
gerritbot added a comment.Dec 11 2022, 6:15 PM

Change 866580 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move MagicWord related files to under parser/

https://gerrit.wikimedia.org/r/866580

gerritbot added a comment.Dec 12 2022, 2:12 AM

Change 866826 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move RawMessage to under language/

https://gerrit.wikimedia.org/r/866826

gerritbot added a comment.Dec 16 2022, 10:47 AM

Change 866826 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move RawMessage to under language/

https://gerrit.wikimedia.org/r/866826

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.17; 2023-01-02); removed MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 16 2022, 11:01 AM
gerritbot added a comment.Dec 16 2022, 11:43 AM

Change 868644 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move ActorMigration and ActorMigrationBase to user/

https://gerrit.wikimedia.org/r/868644

gerritbot added a comment.Dec 16 2022, 6:25 PM

Change 868644 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move ActorMigration and ActorMigrationBase to user/

https://gerrit.wikimedia.org/r/868644

gerritbot added a comment.Dec 20 2022, 8:08 AM

Change 869581 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move TemplateParser to parser/

https://gerrit.wikimedia.org/r/869581

gerritbot added a comment.Dec 21 2022, 11:49 AM

Change 869581 abandoned by Ladsgroup:

[mediawiki/core@master] Reorg: Move TemplateParser to parser/

Reason:

See the discussion in the patch

https://gerrit.wikimedia.org/r/869581

• Ladsgroup edited projects, added MW-1.40-release; removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Feb 8 2023, 2:59 PM

I'm marking this a blocker for 1.40 because we haven't added the moved classes to release notes. Mostly a way to force myself to finish the work.

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2023, 3:31 PM
gerritbot added a comment.Feb 9 2023, 7:00 PM

Change 888073 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move category-related classes from includes/ to Category/

https://gerrit.wikimedia.org/r/888073

gerritbot added a project: Patch-For-Review.Feb 9 2023, 7:00 PM
gerritbot added a comment.Feb 9 2023, 11:20 PM

Change 888073 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move category-related classes from includes/ to Category/

https://gerrit.wikimedia.org/r/888073

Maintenance_bot removed a project: Patch-For-Review.Feb 9 2023, 11:31 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 10 2023, 12:00 AM
gerritbot added a comment.Feb 13 2023, 7:59 PM

Change 888789 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move EditPage.php to MediaWiki\EditPage

https://gerrit.wikimedia.org/r/888789

gerritbot added a project: Patch-For-Review.Feb 13 2023, 7:59 PM
gerritbot added a comment.Feb 16 2023, 9:31 AM

Change 888789 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move EditPage.php to MediaWiki\EditPage

https://gerrit.wikimedia.org/r/888789

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.24; 2023-02-20); removed MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 16 2023, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 16 2023, 10:11 AM
gerritbot added a comment.Feb 16 2023, 12:37 PM

Change 889797 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move CSP class to Request/

https://gerrit.wikimedia.org/r/889797

gerritbot added a project: Patch-For-Review.Feb 16 2023, 12:37 PM
gerritbot added a comment.Feb 16 2023, 5:11 PM

Change 889797 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move CSP class to Request/

https://gerrit.wikimedia.org/r/889797

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2023, 5:30 PM
gerritbot added a comment.Feb 16 2023, 7:27 PM

Change 889847 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move HTML-related classes out of includes/ to Html/

https://gerrit.wikimedia.org/r/889847

gerritbot added a project: Patch-For-Review.Feb 16 2023, 7:27 PM
gerritbot added a comment.Feb 21 2023, 3:37 PM

Change 889847 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move HTML-related classes out of includes/ to Html/

https://gerrit.wikimedia.org/r/889847

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2023, 4:10 PM
gerritbot added a comment.Feb 22 2023, 5:56 PM

Change 891347 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move five page-related classes to page/ out of includes/

https://gerrit.wikimedia.org/r/891347

gerritbot added a project: Patch-For-Review.Feb 22 2023, 5:56 PM
gerritbot added a comment.Thu, Feb 23, 4:43 PM

Change 891347 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move five page-related classes to page/ out of includes/

https://gerrit.wikimedia.org/r/891347

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.25; 2023-02-27); removed MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Thu, Feb 23, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Thu, Feb 23, 5:10 PM
gerritbot added a comment.Thu, Feb 23, 8:45 PM

Change 891623 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Migrate WikiMap to WikiMap/ out of includes

https://gerrit.wikimedia.org/r/891623

gerritbot added a project: Patch-For-Review.Thu, Feb 23, 8:45 PM
gerritbot added a comment.Mon, Feb 27, 3:32 PM

Change 891623 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Migrate WikiMap to WikiMap/ out of includes

https://gerrit.wikimedia.org/r/891623

Maintenance_bot removed a project: Patch-For-Review.Mon, Feb 27, 4:10 PM
gerritbot added a comment.Wed, Mar 1, 5:03 PM

Change 893512 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move WebResponse and FauxResponse to Request/

https://gerrit.wikimedia.org/r/893512

gerritbot added a project: Patch-For-Review.Wed, Mar 1, 5:03 PM
gerritbot added a comment.Wed, Mar 1, 6:53 PM

Change 893512 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move WebResponse and FauxResponse to Request/

https://gerrit.wikimedia.org/r/893512

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.26; 2023-03-06); removed MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Wed, Mar 1, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Wed, Mar 1, 7:10 PM
gerritbot added a comment.Wed, Mar 1, 9:08 PM

Change 893537 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Reorg: Move LinkFilter to ExternalLinks

https://gerrit.wikimedia.org/r/893537

gerritbot added a project: Patch-For-Review.Wed, Mar 1, 9:08 PM
Jdforrester-WMF moved this task from Blocker to Not a blocker on the MW-1.40-release board.Thu, Mar 2, 1:52 PM
Jdforrester-WMF updated the task description. (Show Details)Fri, Mar 3, 7:13 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)Fri, Mar 3, 7:17 PM
gerritbot added a comment.Fri, Mar 3, 7:18 PM

Change 893537 merged by jenkins-bot:

[mediawiki/core@master] Reorg: Move LinkFilter to ExternalLinks

https://gerrit.wikimedia.org/r/893537

Maintenance_bot removed a project: Patch-For-Review.Fri, Mar 3, 7:31 PM
• Ladsgroup added a comment.Wed, Mar 8, 4:16 PM

For MediaWikiVersionFetcher it's better to simply add it to the bluepsice repo and hard-deprecate it in core. It'd be great to do it before the branch cut. I'll try ASAP.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL