Page MenuHomePhabricator

Update the affiliate and age questions wording and options
Closed, ResolvedPublic1 Estimated Story Points

Description

Acceptance criteria
  • Given a user is registering and has been presented with Participant questions
    • Then they should see the text for the affiliate question as described in T321822
  • Given the participant select yes,
    • Then we should show a text field for them to define which affiliate they are connected with
  • Given a user is registering and has been presented with Participant questions
    • Then they should see the text for the age question as described in T321822

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptJul 20 2023, 12:37 PM
MHorsey-WMF set the point value for this task to 1.
MHorsey-WMF moved this task from Backlog to Estimated/Ready for work on the Campaign-Tools board.

Change 940981 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Update the affiliate question wording and options

https://gerrit.wikimedia.org/r/940981

Daimona renamed this task from Update the affiliate question wording and options to Update the affiliate and age questions wording and options.Jul 24 2023, 10:26 PM
Daimona updated the task description. (Show Details)

While reviewing the patch above I read the AC in T321822 again, and the affiliate question reads:

Do you belong to any Wikimedia affiliates (affiliates, chapters, user groups, thematic organizations)?

The repetition of "affiliates" (back-to-back, even) sounds suspicious, so I'd like to ask: is it intentional? @ifried

Update: I discussed this with @Iflorez, and she will be looking into the data (when she has a chance) to confirm if any affiliates under 'affiliate' type are listed as 'affiliate.' Once we have a final word on this, we can make the final call on this particular language question.

Question from Ilana today: Are there any affiliates that are listed as having 'affiliate' type in the database?

'''
FROM GDI.affiliate_data_input_metrics
SELECT *
WHERE affiliate_type =='affiliate'
'''

Results = 0

FROM GDI.affiliate_data_input_metrics
SELECT COUNT(affiliate_type), affiliate_type
GROUP BY affiliate_type

Results:

count(affiliate_type)affiliate_type
76Chapter
273User group
4Thematic Org

Conclusion:
This table has 353 entries with non-null affiliate_name and affiliate_type.
Of those, the affiliate_type only has three options: ['User Group', 'Chapter', 'Thematic Org'].
There are no entries listed as 'affiliate' for affiliate_type

Thank you, @Iflorez!

This means we can update the language to be: Do you belong to any Wikimedia affiliates (chapters, user groups, thematic organizations)?

Apologies for yet another change! Should I write a new ticket, or just update the current one, @Daimona and @cmelo?

Apologies for yet another change! Should I write a new ticket, or just update the current one, @Daimona and @cmelo?

I think we should update this ticket, because the change is still in review.

Apologies for yet another change! Should I write a new ticket, or just update the current one, @Daimona and @cmelo?

I think we should update this ticket, because the change is still in review.

Errrr, actually, the AC should be updated in T321822, but no need for a new task.

Change 940981 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Update the affiliate question wording and options

https://gerrit.wikimedia.org/r/940981

vaughnwalters subscribed.

@cmelo the first option listed here should be Yes and the second should be No per T321822. Right now No is the first answer. They just need flipped.

Screenshot 2023-07-28 at 12.53.52 PM.png (390ร—954 px, 38 KB)

Change 951561 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Fix the order of the affiliate question options

https://gerrit.wikimedia.org/r/951561

@cmelo the first option listed here should be Yes and the second should be No per T321822. Right now No is the first answer. They just need flipped.

Screenshot 2023-07-28 at 12.53.52 PM.png (390ร—954 px, 38 KB)

Thanks @vaughnwalters, I created a new patch, it is in review.

Change 951561 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix the order of the affiliate question options

https://gerrit.wikimedia.org/r/951561

Given the participant select yes,
โœ… Then we should show a text field for them to define which affiliate they are connected with

Special:RegisterForEventEvent Details dialog
Screenshot 2023-08-31 at 7.12.23 PM.png (242ร—1 px, 35 KB)
Screenshot 2023-08-31 at 7.13.21 PM.png (276ร—1 px, 35 KB)

Given a user is registering and has been presented with Participant questions
โœ… Then they should see the text for the age question as described in T321822

Special:RegisterForEventEvent Details dialog
Screenshot 2023-08-31 at 7.17.13 PM.png (732ร—1 px, 62 KB)
Screenshot 2023-08-31 at 7.17.25 PM.png (722ร—820 px, 53 KB)

Given a user is registering and has been presented with Participant questions
๐Ÿ”ด Then they should see the text for the affiliate question as described in T321822
@cmelo As written in T321822, agender and non-binary should not be capitalized

Spec from T321822Event details dialog
Screenshot 2023-09-01 at 1.00.36 AM.png (340ร—1 px, 42 KB)
Screenshot 2023-09-01 at 1.01.00 AM.png (422ร—606 px, 44 KB)

Also, the participant question What is your age? is listed before What is your gender identity? in T321822 but in the design spec, What is your gender identity? is listed first. Should we default to the question order that is on T321822 or keep with the order on the design file @gonyeahialam? @ifried

Also, the participant question`What is your age? is listed before What is your gender identity? in T321822 but in the [[ https://www.figma.com/file/lJUO73TtMpoyn30zm1qFq7/Campaigns-registration-V2?type=design&node-id=632-31380&mode=design&t=E3psCQJHnJab4gOV-0 | design spec ]], What is your gender identity?` is listed first. Should we default to the question order that is on T321822 or keep with the order on the design file @gonyeahialam? @ifried

Follow the question order in the task.

Also, the participant question`What is your age? is listed before What is your gender identity? in T321822 but in the [[ https://www.figma.com/file/lJUO73TtMpoyn30zm1qFq7/Campaigns-registration-V2?type=design&node-id=632-31380&mode=design&t=E3psCQJHnJab4gOV-0 | design spec ]], What is your gender identity?` is listed first. Should we default to the question order that is on T321822 or keep with the order on the design file @gonyeahialam? @ifried

Follow the question order in the task.

Okay thx, moving this back to Code Review/Tech Input to make that change. Also confirming in T321822#9136977 that agender and non-binary should not be capitalized.

Okay thx, moving this back to Code Review/Tech Input to make that change. Also confirming in T321822#9136977 that agender and non-binary should not be capitalized.

Agender and Non-binary should remain capitalized, so this is correct in the current build.

(Noting that the "age" and "gender" questions have been swapped in the AC)

(Noting that the "age" and "gender" questions have been swapped in the AC)

With this change made, I am moving to design sign off.