Change 928175 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Expand/Create HookRunner classes and create hook handler interfaces

https://gerrit.wikimedia.org/r/928175

This should probably be a Wikibase ADR, though I’m not sure which team at WMDE is responsible for it (probably Wikibase Product Platform Team WPP?).

Change 928175 abandoned by Umherirrender:

[mediawiki/extensions/Wikibase@master] Expand/Create HookRunner classes and create hook handler interfaces

Reason:

Seems to need some architectural approval for this group of extension. Maybe better done in small patch sets once approved.

https://gerrit.wikimedia.org/r/928175

Change 962195 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] client: Move GetDoubleUnderscoreIDs hook to HookHandlers

https://gerrit.wikimedia.org/r/962195

Change 962196 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] client: Move LoginFormValidErrorMessagesHandler to HookHandlers

https://gerrit.wikimedia.org/r/962196

Change 962197 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] client: Move MaintenanceShellStart hook to TrivialHookHandler

https://gerrit.wikimedia.org/r/962197

Change 962197 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: Move MaintenanceShellStart hook to TrivialHookHandler

https://gerrit.wikimedia.org/r/962197

Change 962195 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: Move GetDoubleUnderscoreIDs hook to HookHandlers

https://gerrit.wikimedia.org/r/962195

Change 962196 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: Move LoginFormValidErrorMessagesHandler to HookHandlers

https://gerrit.wikimedia.org/r/962196

Just going to quote these two comments again…

In T338452#8913695, @Lucas_Werkmeister_WMDE wrote:

This should probably be a Wikibase ADR, though I’m not sure which team at WMDE is responsible for it (probably Wikibase Product Platform Team WPP?).

In T338452#9010056, @gerritbot wrote:

Change 928175 abandoned by Umherirrender:

[mediawiki/extensions/Wikibase@master] Expand/Create HookRunner classes and create hook handler interfaces

Reason:

Seems to need some architectural approval for this group of extension. Maybe better done in small patch sets once approved.

https://gerrit.wikimedia.org/r/928175

I still think this task should have a decision by Wikibase developers. What the task doesn’t need is untested and broken patches (T347818) that are uploaded on a Sunday evening and merged less than two hours later, thus ensuring that no WMDE developer can possibly review them in time. (The brokenness of the MaintenanceShellStart patch would’ve been quite easily testable by a developer who knew what the hook does – just pop open a maintenance shell.)

In T338452#8913695, @Lucas_Werkmeister_WMDE wrote:

This should probably be a Wikibase ADR, though I’m not sure which team at WMDE is responsible for it (probably Wikibase Product Platform Team WPP?).

Does this apply to Wikibase only? Or also for other deployed extensions from the eco system?
Extensions like:

• ArticlePlaceholder (T346514)
• WikibaseCirrusSearch (T346518)
• WikibaseLexeme (T346516)
• WikibaseLexemeCirrusSearch (T346517)
• WikibaseMediaInfo (T338456)
• WikibaseQualityConstraints (T346519)
• WikimediaBadges (T346505)

In T338452#9214371, @Lucas_Werkmeister_WMDE wrote:

I still think this task should have a decision by Wikibase developers. What the task doesn’t need is untested and broken patches (T347818) that are uploaded on a Sunday evening and merged less than two hours later, thus ensuring that no WMDE developer can possibly review them in time. (The brokenness of the MaintenanceShellStart patch would’ve been quite easily testable by a developer who knew what the hook does – just pop open a maintenance shell.)

Wikibase already uses HookHandlers, I was not aware that converting already-existing handlers to use this function is also covered by that.

In T338452#9216910, @Umherirrender wrote:

In T338452#8913695, @Lucas_Werkmeister_WMDE wrote:

This should probably be a Wikibase ADR, though I’m not sure which team at WMDE is responsible for it (probably Wikibase Product Platform Team WPP?).

Does this apply to Wikibase only? Or also for other deployed extensions from the eco system?
Extensions like:

• ArticlePlaceholder (T346514)
• WikibaseCirrusSearch (T346518)
• WikibaseLexeme (T346516)
• WikibaseLexemeCirrusSearch (T346517)
• WikibaseMediaInfo (T338456)
• WikibaseQualityConstraints (T346519)
• WikimediaBadges (T346505)

I would probably include the extensions WMDE is primarily responsible for – such as ArticlePlaceholder, WikibaseLexeme, WikibaseQualityConstraints, WikimediaBadges. Wikibase(Lexeme)CirrusSearch and WikibaseMediaInfo are primarily maintained by the WMF as far as I’m aware, though it’s still not uncommon for us to merge changes there.