Update GrowthExperiments to use the new HookContainer/HookRunner system
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Umherirrender
	Jun 8 2023, 12:41 PM

Description

Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md for documentation.

Create HookRunner class ~~and the hook handler interfaces (no own hooks)~~
Use hook handlers
- Handler for core hooks
  - GrowthExperiments\ConfirmEmailHooks
- Handler for extensions hooks (depending on creation of hook interfaces in the extensions)
  - Echo (T315938)
  - CirrusSearch (36760c0a)
  - MinervaNeue (T315823)
  - WikimediaEvents (T338443)

Details

	Subject	Repo	Branch	Lines +/-
	Convert ConfirmEmailHooks to HookHandlers	mediawiki/extensions/GrowthExperiments	master	+11 -8
	Create HookRunner class	mediawiki/extensions/GrowthExperiments	master	+51 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Umherirrender	T335536 Hard deprecate class Hooks with all deprecated functions (and remove in 1.42)
Open	None	T254670 [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system
Open	None	T263353 Update all Wikimedia production extensions to use the new HookContainer/HookRunner system
Open	None	T338454 Update GrowthExperiments to use the new HookContainer/HookRunner system

Event Timeline

Umherirrender created this task.Jun 8 2023, 12:41 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 8 2023, 12:41 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system.Jun 8 2023, 12:41 PM

Change 926824 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Create HookRunner class

https://gerrit.wikimedia.org/r/926824

gerritbot added a project: Patch-For-Review.Jun 8 2023, 12:41 PM

Umherirrender renamed this task from GrowthExperiments to Update GrowthExperiments to use the new HookContainer/HookRunner system.Jun 8 2023, 12:47 PM

Umherirrender updated the task description. (Show Details)

Tgr moved this task from Inbox to Current Maintenance Focus on the Growth-Team board.Jun 8 2023, 9:20 PM

Umherirrender added a project: Platform Team Initiatives (New Hook System).Jun 9 2023, 8:39 PM

Change 926824 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Create HookRunner class

https://gerrit.wikimedia.org/r/926824

Umherirrender removed a project: Patch-For-Review.Jun 24 2023, 8:59 PM

Umherirrender updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 24 2023, 9:01 PM

Change 962157 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Convert ConfirmEmailHooks to HookHandlers

https://gerrit.wikimedia.org/r/962157