Page MenuHomePhabricator

Update GrowthExperiments to use the new HookContainer/HookRunner system
Open, MediumPublic

Description

Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md for documentation.

  • Create HookRunner class and the hook handler interfaces (no own hooks)
  • Use hook handlers
    • Handler for core hooks
      • GrowthExperiments\ConfirmEmailHooks
    • Handler for extensions hooks (depending on creation of hook interfaces in the extensions)

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

Change 926824 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Create HookRunner class

https://gerrit.wikimedia.org/r/926824

Umherirrender renamed this task from GrowthExperiments to Update GrowthExperiments to use the new HookContainer/HookRunner system.Jun 8 2023, 12:47 PM
Umherirrender updated the task description. (Show Details)

Change 926824 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Create HookRunner class

https://gerrit.wikimedia.org/r/926824

Change 962157 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Convert ConfirmEmailHooks to HookHandlers

https://gerrit.wikimedia.org/r/962157

Change 962157 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Convert ConfirmEmailHooks to HookHandlers

https://gerrit.wikimedia.org/r/962157

Sgs triaged this task as Medium priority.Nov 20 2023, 4:17 PM

@Sgs I think moving this to Triaged or marking it as closed for now would be okay since the ConfirmEmailHooks adhere to the new hook system and we're not maintaining CirrusSearch which is listed.