Page MenuHomePhabricator
Create Task
Maniphest T285660

CodeMirror: Disable line numbers for mobile devices
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

There's an issue when using line numbers and editing on mobile devices, see T285204: Can't remove lines with syntax highlight on Android. It's upstream in the CodeMirror library and will probably only be fixed with the new major release 6.x. Until then we should disable the feature for these devices, to avoid any inconveniences for affected editors.

Acceptance criteria:

  • Line numbers are disabled for mobile devices on all namespaces ( independent of skin & desktop/mobile mode )

Notes:

  • CodeMirror includes a detection for mobile devices that could be used, if using the detection in core is not convenient

Details

SubjectRepoBranchLines +/-
Disable line numbering in all Android browser versionsmediawiki/extensions/CodeMirrormaster+16 -16
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Jun 28 2021, 10:11 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptJun 28 2021, 10:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
WMDE-Fisch updated the task description. (Show Details)Jun 28 2021, 10:27 AM
WMDE-Fisch mentioned this in T285204: Can't remove lines with syntax highlight on Android.Jul 6 2021, 11:11 AM
Lena_WMDE moved this task from Backlog to Ready for story time on the WMDE-Templates-FocusArea board.Jul 7 2021, 6:49 AM
MusikAnimal removed a project: Community-Tech.Jul 27 2021, 11:35 PM
ECohen_WMDE set the point value for this task to 3.Aug 11 2021, 2:16 PM
ECohen_WMDE moved this task from Ready for story time to Ready for pickup on the WMDE-Templates-FocusArea board.
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2021-09-01.Sep 1 2021, 8:20 AM
Lena_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Sep 1 2021, 8:22 AM
thiemowmde claimed this task.Sep 3 2021, 8:42 AM
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-09-01 board.
thiemowmde added a project: Browser-Support-Android-Google-Chrome.
thiemowmde subscribed.

I had a look at some code we might want to use:

  • Since 2016, core does feature detection instead of user-agent sniffing, see resources/src/startup/startup.js. This means it mostly doesn't care about the exact browser, but about it's capabilities.
  • The only bit of information we get from there is <html class="client-js"> vs. <html class="client-nojs">. This is of no use for us. CodeMirror won't even be activated in the later case.
  • Another bit of feature detection is in resources/src/startup/mediawiki.loader.js. This can be used by setting "requiresES6": true on a MediaWiki-ResourceLoader module in extension.json. Hard to tell if this will help us. Having the capability to run ES6 code is not really related to the bug we are dealing with, I believe.
  • MobileFrontend does have a $wgMFAutodetectMobileView setting. This enables something called a DeviceDetectorService which tries to detect "mobile" as well as "tablet" devices based on a wide variety of signals. The code for this was introduced in 2016 via https://gerrit.wikimedia.org/r/313381 (T143891). I believe it's of no use for us. Mostly because it doesn't return anything specific, only two boolean flags.
  • CodeMirror 5 does rather trivial user-agent sniffing. Unfortunately there is no way to access this information.
  • CodeMirror 6 continues to do pretty much the same (a little more specific, now containing a \b delimiter and not being case-insensitive any more).

The best solution I can see so far is to copy what CodeMirror 6 does.

What I would love to know is if the relevant bug was fixed, and in which version of the Android browser. CodeMirror mentions version 56. The original ticket T285204 was about versions 90 and 91. The most recent version according to https://chromereleases.googleblog.com is 95. Which means it was most probably never fixed.

gerritbot added a comment.Sep 3 2021, 8:56 AM

Change 717160 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/CodeMirror@master] Disable line numbering in all Android browser versions

https://gerrit.wikimedia.org/r/717160

gerritbot added a project: Patch-For-Review.Sep 3 2021, 8:56 AM
thiemowmde moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-09-01 board.Sep 3 2021, 8:56 AM
thiemowmde moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.
thiemowmde moved this task from Backlog to Bugs on the MediaWiki-extensions-CodeMirror board.
WMDE-Fisch added a comment.Sep 3 2021, 10:31 AM

What I would love to know is if the relevant bug was fixed, and in which version of the Android browser. CodeMirror mentions version 56. The original ticket T285204 was about versions 90 and 91. The most recent version according to https://chromereleases.googleblog.com is 95. Which means it was most probably never fixed.

I just verified the bug on my Android 10 with FF 91.

I also tested iOS 14 with Safari/Chrome/FF and it's not an issue there. So it could be sufficient to disable it for Android devices only. Might be good to have a Windows phone checked as well, but I'm not sure if that's available.

I tried SauceLabs to cover a few more combinations. The emulation in there gives different results than my phone so I guess it cant be trusted completely.

gerritbot added a comment.Sep 3 2021, 12:55 PM

Change 717160 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Disable line numbering in all Android browser versions

https://gerrit.wikimedia.org/r/717160

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 3 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2021, 1:10 PM
thiemowmde moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-09-01 board.Sep 7 2021, 4:05 PM
thiemowmde closed this task as Resolved.Sep 14 2021, 9:22 AM
thiemowmde moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-09-01 board.

Confirmed on two different devices (two I never tested this with before). A phone running Android 11 and a tablet running Android 9.

20210914_111717_resized_.jpg (576×1 px, 76 KB)

Izno moved this task from Bugs to Done on the MediaWiki-extensions-CodeMirror board.Oct 11 2021, 10:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL