See an actual example at T281769#7174204. If a popup has hideWhenOutOfView: true (or empty, since true is the default) you're on a RTL page, and you scroll so that the widget goes out of view, when it gets back into view, the popup will be broken as the first image at T281769#7174204. I think this might be a bug in FloatableElement.computePosition.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | matmarex | T285912 hideWhenOutOfView = true breaks popup that go out of view in RTL pages | ||
| Resolved | matmarex | T180173 PopupWidget is not correctly clipped with left/right edge (other ClippableElements work fine) |
Event Timeline
Comment Actions
will this be mitigated when we introduce the ocr button in the toolbar instead of as an element on top of the page? https://phabricator.wikimedia.org/T285712
Comment Actions
It depends on how we're going to implement it, but that would be just for the wikisource side. The OOUI bug that this task is about needs to be fixed in OOUI itself.
Comment Actions
This seems to be working correctly after the fix for the subtask. I proposed a patch to remove the workaround in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikisource/+/862353.