Page MenuHomePhabricator

Thai tone marks in section headers (h2) are clipped.
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
Top tone marks are clipped.

thai_title_vector.png (276×934 px, 66 KB)

What should have happened instead?:
Top tone marks show up (screenshot is from mobile site).

thai_title_minerva.png (208×480 px, 29 KB)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Same issue occurs on Safari, Chrome and Firefox on macOS Big Sur.

Event Timeline

ovasileva triaged this task as Medium priority.Jul 13 2021, 10:44 AM
ovasileva added a project: Readers-Web-Backlog.

Change 705410 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.skinning: Increase `h2` `line-height` for Thai language

https://gerrit.wikimedia.org/r/705410

Best way out seems to be to add a line for Thai headers in 'i18n-headings.less'.

By setting to line-height: 1.6:

image.png (86×426 px, 7 KB)

Change 705410 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.skinning: Increase `h2` `line-height` for Thai language

https://gerrit.wikimedia.org/r/705410

Patch got merged. Can be tested on beta cluster. Move to sign off if no follows up needed.

alexhollender added a subscriber: alexhollender.

apologies for the delay here, this looks fixed in production:

image.png (316×579 px, 33 KB)