Description

List of steps to reproduce (step by step, including full links if applicable):

View Thai article w/section headers where there are top vowel + top tone mark (ex: sections 3-9 in https://th.wikipedia.org/wiki/สากลที่สี่)

What happens?:
Top tone marks are clipped.

thai_title_vector.png (276×934 px, 66 KB)

What should have happened instead?:
Top tone marks show up (screenshot is from mobile site).

thai_title_minerva.png (208×480 px, 29 KB)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Same issue occurs on Safari, Chrome and Firefox on macOS Big Sur.

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki.skinning: Increase `h2` `line-height` for Thai language	mediawiki/core	master	+6 -0

Customize query in gerrit

Related Objects

Mentioned In: T288540: Font-size rules apply to headings in the interface as well as content area (User menu not aligned on bnwiki)

Event Timeline

• mewoph created this task.Jul 1 2021, 5:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2021, 5:55 PM

• alexhollender_WMF added subscribers: Volker_E, Jdlrobson, Amire80.Jul 12 2021, 2:33 PM

ovasileva triaged this task as Medium priority.Jul 13 2021, 10:44 AM

ovasileva added a project: Web-Team-Backlog.

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Jul 13 2021, 3:41 PM

Change 705410 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.skinning: Increase `h2` `line-height` for Thai language

https://gerrit.wikimedia.org/r/705410

gerritbot added a project: Patch-For-Review.Jul 19 2021, 3:19 PM

Best way out seems to be to add a line for Thai headers in 'i18n-headings.less'.

By setting to line-height: 1.6:

With patch:

Screen Shot 2021-07-19 at 11.28.22 AM.png (312×1 px, 95 KB)

Change 705410 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.skinning: Increase `h2` `line-height` for Thai language

https://gerrit.wikimedia.org/r/705410

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.Jul 19 2021, 6:59 PM

Jdlrobson moved this task from Needs Analysis to Design Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 19 2021, 7:00 PM

Patch got merged. Can be tested on beta cluster. Move to sign off if no follows up needed.

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2021, 7:10 PM

LGoto edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Kanbanana-FY-2020-21).Aug 2 2021, 9:28 PM

LGoto moved this task from Needs Analysis to Design Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson mentioned this in T288540: Font-size rules apply to headings in the interface as well as content area (User menu not aligned on bnwiki).Aug 10 2021, 5:33 PM

apologies for the delay here, this looks fixed in production:

Resolving

	F34556454: Screen Shot 2021-07-19 at 11.28.22 AM.png
	Jul 19 2021, 6:29 PM

	F34629502: image.png
	Sep 2 2021, 4:38 PM

	F34556264: image.png
	Jul 19 2021, 3:20 PM

Thai tone marks in section headers (h2) are clipped.Closed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Thai tone marks in section headers (h2) are clipped.
Closed, ResolvedPublicBUG REPORT
Actions