Page MenuHomePhabricator
Create Task
Maniphest T287234

Move Skin::normalizeKey() to SkinFactory
Open, Needs TriagePublic
Actions

Description

The static method Skin::normalizeKey() makes use of globals and the SkinFactory service, and is used in multiple places were dependencies can be injected. The method should be instead moved to SkinFactory.

Details

SubjectRepoBranchLines +/-
Move Skin::normalizeKey() to SkinFactorymediawiki/coremaster+153 -60
Customize query in gerrit

Event Timeline

DannyS712 created this task.Jul 23 2021, 9:11 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 23 2021, 9:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jul 23 2021, 9:11 AM

Change 707015 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Move Skin::normalizeKey() to SkinFactory

https://gerrit.wikimedia.org/r/707015

gerritbot added a project: Patch-For-Review.Jul 23 2021, 9:11 AM
Jdlrobson moved this task from Backlog to PHP internals on the MediaWiki-Core-Skin-Architecture board.Jul 23 2021, 5:07 PM
Krinkle subscribed.Jul 26 2021, 1:02 PM

Previous patches that tried this:

DannyS712 claimed this task.Aug 19 2021, 10:07 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
DannyS712 removed DannyS712 as the assignee of this task.Oct 5 2023, 9:42 PM

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.

pmiazga subscribed.Jan 24 2024, 12:53 PM

I tried to make a stab at this work some time ago (patches that Krinkle mentioned ) but then I abandoned the idea. Now I want to get this thing done and noticed you made a ticket for it and pushed a PR. Nice. Thanks.

@DannyS712 are you going to work on this? If not, let me take over this work.

DannyS712 added a comment.Jan 24 2024, 4:55 PM
In T287234#9484807, @pmiazga wrote:

I tried to make a stab at this work some time ago (patches that Krinkle mentioned ) but then I abandoned the idea. Now I want to get this thing done and noticed you made a ticket for it and pushed a PR. Nice. Thanks.

@DannyS712 are you going to work on this? If not, let me take over this work.

You can do this, feel free to add me as a reviewer to the patch though

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL