Page MenuHomePhabricator

Remove extra padding above & below "learn more" in user menu
Closed, ResolvedPublic

Description

Description

Currently there is 12px of padding above & below the element

Screen Shot 2021-07-27 at 5.53.03 PM.png (378×607 px, 72 KB)

To do

Change it to only 4px of padding above & below the element

image.png (437×572 px, 73 KB)

Event Timeline

Change 708375 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Fix user menu \"learn more\" link spacing

https://gerrit.wikimedia.org/r/708375

@alexhollender I think I messed up the top spacing on this as well as for some reason there is 12px of top padding + 2px of top margin when T285786 clearly advises only 8px. It should only have 8px of top padding, correct?

8px would be great as we're approaching generalized & unified spacing land with 4px multipliers whenever possible.

@alexhollender I think I messed up the top spacing on this as well as for some reason there is 12px of top padding + 2px of top margin when T285786 clearly advises only 8px. It should only have 8px of top padding, correct?

ah good catch, yes sounds good! and re: @Volker_E's point, might as well go with 4px top & bottom. description updated

ovasileva triaged this task as Medium priority.Jul 28 2021, 3:13 PM

Please move to sign off when this has been confirmed on the beta cluster.

Change 708375 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix user menu \"learn more\" link spacing

https://gerrit.wikimedia.org/r/708375

alexhollender renamed this task from Remove extra padding below "learn more" in user menu to Remove extra padding above & below "learn more" in user menu.Jul 28 2021, 10:07 PM