Page MenuHomePhabricator

Language selector: Show as dialog on wider screens
Closed, ResolvedPublic

Description

Looking at the initial implementation of the language selector (T253303) available for Section Translation at test wiki, the selector takes the whole screen width even when displaying at wider screens.

Based on the spec in T253303, the selector on wider screens is shown as a dialog over existing content with no header element (512px max width):

Screen size

  • Narrow screen. The selector is shown as a full screen dialog. The list of all languages always uses one column.
  • Wider screen. The selector is shown as a dialog over existing content. The list of all languages can use one or three columns depending on the number of languages (see above). The length of the selector will adapt to the available languages with a max height of 312px.

    |Wide screen|Narrow screen| |---|---| |
    Group.png (572×904 px, 41 KB)
    |
    mobile.png (669×348 px, 34 KB)

Layout spacing.png (768×1 px, 88 KB)

Event Timeline

Pginer-WMF triaged this task as Medium priority.Aug 2 2021, 2:55 PM
Pginer-WMF created this task.

Change 714563 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] SX Language selector: Show as dialog in wide screens

https://gerrit.wikimedia.org/r/714563

Change 714563 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX Language selector: Show as dialog in wide screens

https://gerrit.wikimedia.org/r/714563

Screencast as per current version in bn.wikipedia.org

language-selector-dialog.gif (396×600 px, 586 KB)

Etonkovidova subscribed.

Checked on bnwiki wmf.7 and testwiki wmf.9 with RTL variant - works as expected.

lang_selector2.gif (764×1 px, 1 MB)