Page MenuHomePhabricator

Template editors: visualClear class is no longer supported in wikitext / templates
Open, Needs TriagePublicBUG REPORT

Description

Impacted pages: https://global-search.toolforge.org/?q=visualClear&regex=1&namespaces=&title=%5B%5E%5C.%5D%2B
Severity: Low
Impacted templates: https://global-search.toolforge.org/?q=visualClear&regex=1&namespaces=10&title=%5B%5E%5C.%5C%2F%5D%2B
Severity: medium

What happens?:

Historically some code, and some templates have used the visualClear class to clear floated content on the page.

e.g.

<div class="visualClear"></div>

We have been moving away from using the visualClear class in MediaWiki software as there are cleaner more semantic solutions to this problem.

What should have happened instead?:

Going forward templates should not rely on it as this will not work in the future. Instead, they should do:

<div style="clear:both;"></div>

OR introduce a template style using pseudo elements:

.visualClear:after {
 content: '';
  clear: both;
}

Event Timeline

@Jdlrobson How would you like this described in TechNews? What is the timeframe? Perhaps something like this... (please correct as needed)

"The old CSS <div class="visualClear"></div> will not be supported [in the future | in 2 weeks?]. Instead, templates and pages should use <div style="clear:both;"></div>. Please help to replace any existing uses on your wiki. There are global-search links available at T287962.

@Jdlrobson How would you like this described in TechNews? What is the timeframe? Perhaps something like this... (please correct as needed)

"The old CSS <div class="visualClear"></div> will not be supported [in the future | in 2 weeks?]. Instead, templates and pages should use <div style="clear:both;"></div>. Please help to replace any existing uses on your wiki. There are global-search links available at T287962.

That sounds great. In terms of date, we can now put "From August 12th these will no longer be supported."

In terms of date, we can now put "From August 12th these will no longer be supported."

Does this mean August 12 for everyone, i.e. it will be backported on Thursday? Or will it ride the MediaWiki train and hit group0 and group1 wikis on Tuesday and Wednesday respectively?

In terms of date, we can now put "From August 12th these will no longer be supported."

Does this mean August 12 for everyone, i.e. it will be backported on Thursday? Or will it ride the MediaWiki train and hit group0 and group1 wikis on Tuesday and Wednesday respectively?

The latter. This change is riding the train.