Page MenuHomePhabricator
Create Task
Maniphest T288404

Allow pending changes reviewer at idwiki to mark revisions as being "accepted"
Closed, ResolvedPublic
Actions

Description

After T286853 was completed, several idwiki pending changes reviewer reported that they are still unable to mark a page revision as being "accepted"; the current setting only allow sysops to do that.

image.png (1×818 px, 213 KB)

Details

SubjectRepoBranchLines +/-
flaggedrevs: Fix idwiki's autoreview configoperations/mediawiki-configmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

SpartacksCompatriot created this task.Aug 8 2021, 3:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2021, 3:18 AM
Reedy added a project: Wikimedia-Site-requests.Aug 8 2021, 3:22 AM
Aklapper added a comment.Aug 8 2021, 10:08 AM

@SpartacksCompatriot: In the future, please follow https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes when requesting such kinds of changes. Thanks!

SpartacksCompatriot added a subscriber: Ladsgroup.Nov 12 2021, 10:45 AM

@Aklapper: the community has consented to implement this. https://id.wikipedia.org/wiki/Wikipedia:Warung_Kopi_(Teknis)#Mengizinkan_para_peninjau_meninjau

Also notifying @Ladsgroup as the original deployer of PC at idwiki.

Arifin.wijaya subscribed.Nov 13 2021, 11:23 AM
Silencemen21 subscribed.Nov 14 2021, 2:52 AM
Ladsgroup added a comment.Nov 20 2021, 7:49 PM

Can you give me the url to test the problem?

SpartacksCompatriot added a comment.Nov 21 2021, 7:01 AM

@Ladsgroup: sure. Try https://id.wikipedia.org/w/index.php?title=Orlando_Gibbons&action=protect

Ladsgroup added a comment.Nov 24 2021, 7:20 PM

You are talking about "autoreview" then. Let me see what I can do about it.

NaufalFarras subscribed.Dec 2 2021, 1:40 PM
Veracious subscribed.Dec 8 2021, 1:43 AM
gerritbot added a comment.Dec 12 2021, 12:31 AM

Change 745995 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] flaggedrevs: Fix idwiki's autoreview config

https://gerrit.wikimedia.org/r/745995

gerritbot added a project: Patch-For-Review.Dec 12 2021, 12:31 AM
Ladsgroup added a comment.Dec 12 2021, 12:33 AM

This extension is truly terrible. It took me two full hours just to figure out what is the config here and I know this extension very well. I also found like three different configs that are completely unused and can be removed.

gerritbot added a comment.Dec 13 2021, 8:13 AM

Change 745995 merged by jenkins-bot:

[operations/mediawiki-config@master] flaggedrevs: Fix idwiki's autoreview config

https://gerrit.wikimedia.org/r/745995

Stashbot added a comment.Dec 13 2021, 8:20 AM

Mentioned in SAL (#wikimedia-operations) [2021-12-13T08:20:14Z] <ladsgroup@deploy1002> Synchronized wmf-config/flaggedrevs.php: Config: [[gerrit:745995|flaggedrevs: Fix idwiki's autoreview config (T288404)]] (duration: 00m 56s)

Ladsgroup closed this task as Resolved.Dec 13 2021, 8:21 AM
Ladsgroup claimed this task.

This is fixed now. You need to create the message keys for flaggedrevs-protect-autoconfirmed and flaggedrevs-protect-autoreview but that's on your side.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 13 2021, 8:21 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 13 2021, 9:11 AM
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Dec 13 2021, 9:15 AM
Rachmat04 subscribed.EditedDec 13 2021, 1:04 PM

Many thanks, @Ladsgroup. The messages have also been created.

Rachmat04 unsubscribed.Dec 13 2021, 1:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL