Page MenuHomePhabricator

Master tests failing for EntitySchema due to diff class changes
Closed, ResolvedPublic

Description

Seen at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/+/711681

13:39:05 There was 1 failure:
13:39:05 
13:39:05 1) EntitySchema\Tests\Integration\MediaWiki\Content\EntitySchemaSlotDiffRendererTest::testGetDiff with data set "changes, removals and additions" (array(array('test label'), array('test description'), array(array('test alias', 'test alias 2')), 'test schema', 'ShExC', '3.0'), array(array('updated label'), array('Testbeschreibung'), array(array('test alias', 'test alias 3'), array('Testalias')), 'schema updated', '3.0'), '<tr>\n	<td colspan="2" class=...n</tr>')
13:39:05 Failed asserting that two DOM documents are equal.
13:39:05 --- Expected
13:39:05 +++ Actual
13:39:05 @@ @@
13:39:05    </tr>
13:39:05    <tr>
13:39:05      <td class="diff-marker" data-marker="&#x2212;"/>
13:39:05 -    <td class="diff-deletedline">
13:39:05 +    <td class="diff-deletedline diff-left">
13:39:05        <div><del class="diffchange diffchange-inline">test </del>schema</div>
13:39:05      </td>
13:39:05      <td class="diff-marker" data-marker="+"/>
13:39:05 -    <td class="diff-addedline">
13:39:05 +    <td class="diff-addedline diff-right">
13:39:05        <div>schema <ins class="diffchange diffchange-inline">updated</ins></div>
13:39:05      </td>
13:39:05    </tr>
13:39:05 
13:39:05 /workspace/src/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Content/EntitySchemaSlotDiffRendererTest.php:182
13:39:05 === Logs generated by test case
13:39:05 [GlobalTitleFail] [info] RequestContext::getTitle called with no title set. {"exception":{}}
13:39:05 [GlobalTitleFail] [info] RequestContext::getTitle called with no title set. {"exception":{}}
13:39:05 [GlobalTitleFail] [info] RequestContext::getTitle called with no title set. {"exception":{}}
13:39:05 [GlobalTitleFail] [info] RequestContext::getTitle called with no title set. {"exception":{}}
13:39:05 ===
13:39:05 
13:39:05 FAILURES!
13:39:05 Tests: 4677, Assertions: 13520, Failures: 1, Skipped: 1.

Likely caused by T285956: Lock selection to a single side in TableDiffFormatter / rMW9ef58c1d0b60: Lock selection to a single side in diffs

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Tagging community tech since it was caused by some of their work, hopefully they can review the fix too?

Change 711713 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/EntitySchema@master] Update EntitySchemaSlotDiffRendererTest::testGetDiff for core changes

https://gerrit.wikimedia.org/r/711713

Change 711713 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Update EntitySchemaSlotDiffRendererTest::testGetDiff for core changes

https://gerrit.wikimedia.org/r/711713

MusikAnimal assigned this task to DannyS712.
MusikAnimal subscribed.

This was just developer busy work so I think it can be resolved. Tests are passing now, so we're done.