Page MenuHomePhabricator
Create Task
Maniphest T288788

Regression: Monobook shows non-existing own user page in user tools bar as blue link instead of red link
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
• Naleksuh
Aug 12 2021, 11:24 PM
Tags
Referenced Files
F34621129: Screen Shot 2021-08-26 at 2.29.27 PM.png
Aug 26 2021, 9:30 PM
F34618796: Screen Shot 2021-08-24 at 6.38.06 AM.png
Aug 24 2021, 1:39 PM
F34592261: image.png
Aug 12 2021, 11:24 PM
F34592258: image.png
Aug 12 2021, 11:24 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
matmarex
• Naleksuh

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

User page shows as a blue link

What should have happened instead?:

User page should show as a red link

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

image.png (24×511 px, 1 KB)

image.png (42×566 px, 2 KB)

QA Results - Beta

ACStatusDetails
1✅T288788#7304696

QA Results - Prod

ACStatusDetails
1✅T288788#7313451

Details

SubjectRepoBranchLines +/-
Restore red links color to the responsive modemediawiki/skins/MonoBookmaster+5 -2
Customize query in gerrit

Related Objects

Event Timeline

• Naleksuh created this task.Aug 12 2021, 11:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2021, 11:24 PM
• Naleksuh triaged this task as Medium priority.Aug 12 2021, 11:24 PM
Reedy raised the priority of this task from Medium to Needs Triage.Aug 12 2021, 11:26 PM
Reedy added projects: MonoBook, Desktop Improvements (Vector 2022).
• Naleksuh updated the task description. (Show Details)Aug 12 2021, 11:27 PM
• Naleksuh added a comment.Aug 12 2021, 11:29 PM

Yesterday this happened on Meta but not enwiki, but today it is happening on both Meta and enwiki. In accordance with the weekly deploy system, that means it was likely caused by this week's update

Aklapper renamed this task from Recent MW update breaks sign-in screen with nonexistent user pages in Monobook skin to Monobook shows non-existing own user page in user tools bar as blue link instead of red link.Aug 13 2021, 2:00 PM
Jdlrobson edited projects, added User-Jdlrobson; removed Desktop Improvements (Vector 2022).Aug 18 2021, 1:00 AM
Jdlrobson subscribed.

Not related to desktop improvements. This is related to the recent performance refactor in T285492 which has led to the rule not applying because of specificity. I'll provide a patch tomorrow if nobody has beaten me to it.

Jdlrobson added a project: Regression.Aug 18 2021, 1:00 AM
gerritbot added a comment.Aug 18 2021, 3:00 PM

Change 713643 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MonoBook@master] Restore red links color to the responsive mode

https://gerrit.wikimedia.org/r/713643

gerritbot added a project: Patch-For-Review.Aug 18 2021, 3:00 PM
matmarex subscribed.Aug 18 2021, 3:12 PM
Jdlrobson renamed this task from Monobook shows non-existing own user page in user tools bar as blue link instead of red link to Regression: Monobook shows non-existing own user page in user tools bar as blue link instead of red link.Aug 18 2021, 3:16 PM
Jdlrobson assigned this task to Edtadros.
Jdlrobson triaged this task as Medium priority.
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson set the point value for this task to 0.
gerritbot added a comment.Aug 18 2021, 3:18 PM

Change 713643 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] Restore red links color to the responsive mode

https://gerrit.wikimedia.org/r/713643

Jdlrobson mentioned this in rSMNBbf64fa1aec5d: Restore red links color to the responsive mode.Aug 18 2021, 3:22 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 18 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 18 2021, 4:10 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Aug 24 2021, 1:39 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Create a new account
Visit https://en.wikipedia.beta.wmflabs.org/wiki/Spain
Switch skin to monobook
✅ AC1: User page should show as a red link

Screen Shot 2021-08-24 at 6.38.06 AM.png (46×1 px, 28 KB)

Edtadros updated the task description. (Show Details)Aug 24 2021, 1:40 PM
Edtadros reassigned this task from Edtadros to ovasileva.EditedAug 26 2021, 9:30 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Create a new account
Visit a page on enwiki
Switch skin to monobook
✅ AC1: User page should show as a red link

Screen Shot 2021-08-26 at 2.29.27 PM.png (58×1 px, 27 KB)

Edtadros updated the task description. (Show Details)Aug 26 2021, 9:31 PM
Edtadros updated the task description. (Show Details)
• Naleksuh added a comment.Aug 26 2021, 10:14 PM

This seems to be fixed now

ovasileva closed this task as Resolved.Aug 30 2021, 4:13 PM

Resolving!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits