Page MenuHomePhabricator

"Confirm change" shortcut for dialogs doesn’t work in surface widgets
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce:

  1. Edit a page with VisualEditor
  2. Add a Basic reference or edit any one
  3. Type something in reference content field and keep focus (cursor) inside it
  4. Press CTRL+Enter (probably CMD+Enter on Mac) on keyboard

What happens?:
Nothing happens.

What should have happened instead?:
Apply change (for an existing reference) or Insert button (submit button) should be pressed down and dialog should successfully close.

Notes:

  • If you press CTRL+Maj+Enter (“Move focus to contextual popup”), it make what I expected for CTRL+Enter.
  • If you press Escape, dialog well closes cancelling changes.
  • If you press Tab to switch to Reference group input field, then you press CTRL+Enter, it well submits the dialog. So the shortcut is well attached, it is just disabled from Reference content surface.

Info:
Tested with Firefox 78 and Chromium 87 on a Debian system (LXQT desktop environment).

Event Timeline

Esanders renamed this task from Confirm change shortcut for “Insert”/“Apply changes” button doesn’t work from Basic reference editor to "Confirm change" shortcut for dialogs doesn’t work in surface widgets.Nov 8 2021, 4:17 PM

Change 737427 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Handle TargetWidget submit events in dialogs

https://gerrit.wikimedia.org/r/737427

Change 737427 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Handle TargetWidget submit events in dialogs

https://gerrit.wikimedia.org/r/737427

Change 738484 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ef47d7814)

https://gerrit.wikimedia.org/r/738484

Change 738484 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ef47d7814)

https://gerrit.wikimedia.org/r/738484

Tested on both Chrome and Firefox:

Pressing CMD+Enter on keyboard applies the changes as shown in https://photos.app.goo.gl/urjCwywqCCTdwmxd9.