Branch and tag a final version of Parsoid for REL1_37
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Aug 24 2021, 4:32 PM

Details

Subject	Repo	Branch	Lines +/-
Upgrading wikimedia/parsoid (v0.14.0-a19 => v0.14.0)	mediawiki/core	REL1_37	+2 -2
Upgrading wikimedia/parsoid (v0.14.0-a19 => v0.14.0)	mediawiki/vendor	REL1_37	+4 K -462
Bump wikimedia/parsoid to 0.14.0-a19 for 1.37.0-rc.0	mediawiki/vendor	REL1_37	+1 K -1 K

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Reedy	T289585 Release MW 1.37.0
Resolved	Reedy	T289595 Branch and tag a final version of Parsoid for REL1_37
Resolved	Jdforrester-WMF	T295797 Fix mwgate-node12-docker failures in Parsoid branches

Event Timeline

Jdforrester-WMF created this task.Aug 24 2021, 4:32 PM

Jdforrester-WMF moved this task from Blocker to Process on the MW-1.37-release board.Aug 24 2021, 4:51 PM

Jdforrester-WMF moved this task from Process to Blocker on the MW-1.37-release board.

Arlolra added a subtask: T261329: Prepare Parsoid for MW.Sep 13 2021, 9:42 PM

Arlolra edited projects, added Parsoid (Third-party); removed Parsoid.

Jdforrester-WMF removed a subtask: T261329: Prepare Parsoid for MW.Sep 16 2021, 2:14 AM

Change 722442 had a related patch set uploaded (by Jforrester; author: C. Scott Ananian):

[mediawiki/vendor@REL1_37] Bump wikimedia/parsoid to 0.14.0-a19 for 1.37.0-rc.0

https://gerrit.wikimedia.org/r/722442

gerritbot added a project: Patch-For-Review.Sep 20 2021, 11:47 PM

Change 722442 merged by Jforrester:

[mediawiki/vendor@REL1_37] Bump wikimedia/parsoid to 0.14.0-a19 for 1.37.0-rc.0

https://gerrit.wikimedia.org/r/722442

Jdforrester-WMF changed the task status from Open to In Progress.Sep 21 2021, 12:09 AM

Jdforrester-WMF assigned this task to cscott.

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2021, 12:11 AM

Reedy moved this task from Blocker to Process on the MW-1.37-release board.Oct 19 2021, 4:46 PM

Reedy edited parent tasks, added: T289585: Release MW 1.37.0; removed: T289591: Release 1.37.0-rc.0.Oct 21 2021, 2:30 PM

Reedy triaged this task as Medium priority.Oct 21 2021, 9:28 PM

We should get this done this week :)

It also looks like we're still to create a REL1_37 branch inside the parsoid repo (incase of future backports etc).

Can we just use v0.14.0-a19 for that branch point, and then also tag that commit as v0.14.0?

Aaaand.... https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/725913 needs to go into that branch seemingly, based on https://github.com/wikimedia/parsoid/blob/v0.14.0-a19/composer.json#L57

REL1_37 branch created from rGPAR5102525d6f33: Improve mw-empty-elt detection in Cleanup DOM handler, which is also the commit of v0.14.0-a19

In T289595#7507428, @Reedy wrote:

It also looks like we're still to create a REL1_37 branch inside the parsoid repo (incase of future backports etc).

Can we just use v0.14.0-a19 for that branch point, and then also tag that commit as v0.14.0?

Yes, that's a good plan. Looks like you're doing that? I can also do it if that helps.

In T289595#7507608, @cscott wrote:

In T289595#7507428, @Reedy wrote:

It also looks like we're still to create a REL1_37 branch inside the parsoid repo (incase of future backports etc).

Can we just use v0.14.0-a19 for that branch point, and then also tag that commit as v0.14.0?

Yes, that's a good plan. Looks like you're doing that? I can also do it if that helps.