Page MenuHomePhabricator

Investigate whether we can/should integrate Git/Reviewers with GitLab
Open, LowPublic3 Estimated Story Points

Description

I just now became aware of this: https://www.mediawiki.org/wiki/Git/Reviewers

Probably worth thinking about what this looks like in a GitLab world - and/or whether there's some builtin GitLab feature that could handle it.

One complication that comes to mind: GitLab CE really only supports one assigned reviewer at a time.

Event Timeline

brennen triaged this task as Medium priority.Aug 26 2021, 5:35 PM
brennen moved this task from INBOX to Seen on the Release-Engineering-Team board.
brennen edited projects, added GitLab (Integrations); removed GitLab.
thcipriani lowered the priority of this task from Medium to Low.
thcipriani changed the point value for this task from 2 to 3.

If you're mentioned in a MR, it shows up in your Todos (https://gitlab.wikimedia.org/dashboard/todos), where you can mark them as Done. So, one option would be for the reviewer-bot to automatically edit the MR description to tag the reviewers, maybe it could create its own section like:

## Reviewers from https://www.mediawiki.org/wiki/Git/Reviewers
* @kharlan 
* @someoneElse

One complication is that you need a mapping of LDAP names to shell user names, i.e. I'm "Kosta Harlan" in gerrit reviewer tagging land, but @kharlan in our GitLab setup.

Side note – does GitLab have some equivalent to gerrit's stream-events?