Page MenuHomePhabricator
Create Task
Maniphest T290340

Drop the flaggedimages table from Wikimedia production
Closed, ResolvedPublic
Actions

Description

Use dropped from the code in T289248: Drop stable check for images used in pages, landed in 1.37.0-wmf.20; definition of table is dropped landing in 1.37.0-wmf.21.

Progress

alswiki
bawiki
bewiki
bnwiki
bswiki
cawikinews
cewiki
ckbwiki
de_labswikimedia
dewikiquote
dewiktionary
elwikinews
en_labswikimedia
enwikibooks
enwikinews
eswikinews
fawikinews
flaggedrevs_labswikimedia
frwikinews
hewikisource
hiwiki
iawiki
iswiktionary
kawiki
lawikisource
mkwiki
plwikisource
plwiktionary
ptwikibooks
ptwikinews
ptwikisource
ruwikinews
ruwikiquote
ruwikisource
ruwiktionary
siwiki
sqwiki
tawikinews
test2wiki
trwikiquote
ukwiktionary
vecwiki

s4: Not present

s8: Not present

Details

SubjectRepoBranchLines +/-
filtered_tables.txt: Remove references to flaggedimagesoperations/puppetproduction+0 -4
snapshot: Drop flaggedimages from dumpsoperations/puppetproduction+0 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Sep 3 2021, 4:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2021, 4:52 PM
Jdforrester-WMF added a subtask: T289248: Drop stable check for images used in pages.Sep 3 2021, 4:52 PM
Jdforrester-WMF updated the task description. (Show Details)
• Marostegui triaged this task as Medium priority.Sep 3 2021, 4:54 PM
• Marostegui removed a project: Schema-change.
• Marostegui moved this task from Triage to Ready on the DBA board.
Ladsgroup closed subtask T289248: Drop stable check for images used in pages as Resolved.Sep 3 2021, 4:55 PM
• Marostegui subscribed.Sep 10 2021, 6:13 AM

So according to https://versions.toolforge.org/ we are on 1.37.0-wmf.21 everywhere, so this is ready to go anytime after the switch back.

Ladsgroup mentioned this in T281203: dumps distribution servers space issues.Sep 17 2021, 10:54 PM
gerritbot added a comment.Sep 18 2021, 7:22 PM

Change 722026 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/puppet@production] snapshot: Drop flaggedimages from dumps

https://gerrit.wikimedia.org/r/722026

gerritbot added a project: Patch-For-Review.Sep 18 2021, 7:22 PM
gerritbot added a comment.Sep 22 2021, 10:40 AM

Change 722026 merged by ArielGlenn:

[operations/puppet@production] snapshot: Drop flaggedimages from dumps

https://gerrit.wikimedia.org/r/722026

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2021, 11:10 AM
• Marostegui claimed this task.Sep 23 2021, 5:52 AM
• Marostegui updated the task description. (Show Details)
• Marostegui updated the task description. (Show Details)Sep 23 2021, 11:08 AM
Restricted Application added subscribers: Huji, Base. · View Herald TranscriptSep 23 2021, 11:08 AM
Ladsgroup awarded a token.Sep 23 2021, 2:06 PM
Ladsgroup subscribed.
• Marostegui added a comment.Sep 24 2021, 9:24 AM

I am planning to rename the tables in ruwiki and arwiki on a slave host, to make sure nothing reads from it. Writes haven't happened since 2nd sept.
Doing a quick search I only found this: https://gerrit.wikimedia.org/g/mediawiki/extensions/BlueSpiceFlaggedRevsConnector/+/ec2b7a07f93ef92c9b3fd3ade7a7a5a86d6b241c/src/Panel/Flyout.php#124

Stashbot added a comment.Sep 24 2021, 9:25 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-24T09:25:14Z] <marostegui> Rename flaggedimages on db1096(ruwiki) and db1098(arwiki) T290340

• Marostegui added a comment.Sep 24 2021, 9:25 AM

s6 (ruwiki)

root@db1096.eqiad.wmnet[ruwiki]> rename table flaggedimages to TO_DROP_flaggedimages;
Query OK, 0 rows affected (0.003 sec)

s7 (arwiki)

root@db1098.eqiad.wmnet[arwiki]> rename table flaggedimages to TO_DROP_flaggedimages;
Query OK, 0 rows affected (0.004 sec)

root@db1098.eqiad.wmnet[arwiki]>
• Marostegui moved this task from Ready to In progress on the DBA board.Sep 24 2021, 10:31 AM
Ladsgroup added a comment.Sep 24 2021, 12:33 PM
In T290340#7376144, @Marostegui wrote:

I am planning to rename the tables in ruwiki and arwiki on a slave host, to make sure nothing reads from it. Writes haven't happened since 2nd sept.
Doing a quick search I only found this: https://gerrit.wikimedia.org/g/mediawiki/extensions/BlueSpiceFlaggedRevsConnector/+/ec2b7a07f93ef92c9b3fd3ade7a7a5a86d6b241c/src/Panel/Flyout.php#124

that's not deployed in production.

• Marostegui added a comment.Sep 27 2021, 5:05 AM

Dropped in enwiki (empty)

root@db1163.eqiad.wmnet[enwiki]> select count(*) from flaggedimages;
+----------+
| count(*) |
+----------+
|        0 |
+----------+
1 row in set (0.002 sec)

root@db1163.eqiad.wmnet[enwiki]> drop table if exists flaggedimages;
Query OK, 0 rows affected (0.121 sec)

root@db1163.eqiad.wmnet[enwiki]>
• Marostegui updated the task description. (Show Details)Sep 27 2021, 5:06 AM
• Marostegui updated the task description. (Show Details)Sep 27 2021, 5:12 AM
Stashbot added a comment.Sep 27 2021, 5:28 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-27T05:28:09Z] <marostegui> Remove flaggedimages from s2 T290340

• Marostegui updated the task description. (Show Details)EditedSep 27 2021, 5:28 AM

s2

  • dbstore1007
  • db1182
  • db1170
  • db1162
  • db1156
  • db1155
  • db1146
  • db1129
  • db1122
  • db1105
  • db1102
  • clouddb1021
  • clouddb1018
  • clouddb1014
• Marostegui updated the task description. (Show Details)Sep 27 2021, 5:32 AM
Stashbot added a comment.Sep 27 2021, 7:07 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-27T07:07:52Z] <marostegui> Remove flaggedimages from s3 T290340

• Marostegui updated the task description. (Show Details)EditedSep 27 2021, 7:08 AM

s3

  • dbstore1007
  • db1179
  • db1175
  • db1166
  • db1157
  • db1154
  • db1123
  • db1112
  • db1102
  • clouddb1021
  • clouddb1017
  • clouddb1013
• Marostegui updated the task description. (Show Details)Sep 27 2021, 7:11 AM
Stashbot added a comment.Sep 28 2021, 5:10 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-28T05:10:02Z] <marostegui> Remove flaggedimages from s6 T290340

• Marostegui updated the task description. (Show Details)Sep 28 2021, 5:11 AM
• Marostegui added a comment.Sep 28 2021, 5:14 AM

s6

  • dbstore1005
  • db1180
  • db1173
  • db1168
  • db1165
  • db1155
  • db1140
  • db1131
  • db1113
  • db1098
  • db1096
  • clouddb1021
  • clouddb1019
  • clouddb1015
• Marostegui updated the task description. (Show Details)Sep 28 2021, 5:14 AM
Stashbot added a comment.Sep 28 2021, 12:06 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-28T12:06:36Z] <marostegui> Remove flaggedimages from s7 T290340

• Marostegui updated the task description. (Show Details)Sep 28 2021, 12:07 PM
• Marostegui added a comment.EditedSep 28 2021, 12:09 PM

s7

  • dbstore1003
  • db1181
  • db1174
  • db1171
  • db1170
  • db1158
  • db1155
  • db1136
  • db1127
  • db1101
  • db1098
  • clouddb1021
  • clouddb1018
  • clouddb1014
• Marostegui updated the task description. (Show Details)Sep 28 2021, 12:09 PM
• Marostegui updated the task description. (Show Details)
• Marostegui updated the task description. (Show Details)Sep 28 2021, 12:12 PM
Stashbot added a comment.Sep 28 2021, 2:38 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-28T14:38:36Z] <marostegui> Remove flaggedimages from s5 T290340

• Marostegui updated the task description. (Show Details)EditedSep 28 2021, 2:39 PM

s5

  • dbstore1003
  • db1161
  • db1154
  • db1150
  • db1144
  • db1130
  • db1113
  • db1110
  • db1100
  • db1096
  • clouddb1021
  • clouddb1020
  • clouddb1016
• Marostegui updated the task description. (Show Details)Sep 28 2021, 2:40 PM
gerritbot added a comment.Sep 29 2021, 5:16 AM

Change 724589 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/puppet@production] filtered_tables.txt: Remove references to flaggedimages

https://gerrit.wikimedia.org/r/724589

gerritbot added a project: Patch-For-Review.Sep 29 2021, 5:16 AM
• Marostegui updated the task description. (Show Details)Sep 29 2021, 5:16 AM
• Marostegui added a parent task: T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking).
• Marostegui mentioned this in T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking).
gerritbot added a comment.Sep 29 2021, 5:24 AM

Change 724589 merged by Marostegui:

[operations/puppet@production] filtered_tables.txt: Remove references to flaggedimages

https://gerrit.wikimedia.org/r/724589

Maintenance_bot removed a project: Patch-For-Review.Sep 29 2021, 6:10 AM
• Marostegui closed this task as Resolved.Sep 29 2021, 6:55 AM
• Marostegui updated the task description. (Show Details)

All done

• Marostegui updated the task description. (Show Details)Sep 29 2021, 6:56 AM
rook closed subtask T292043: Remove views from flaggedimages as Resolved.Oct 8 2021, 5:21 PM
rook reopened subtask T292043: Remove views from flaggedimages as Open.Oct 8 2021, 6:09 PM
rook closed subtask T292043: Remove views from flaggedimages as Resolved.Oct 18 2021, 1:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL